Date: Wed, 7 Feb 2007 15:39:38 +0100 (CET)
From: Roman Zippel <zippel@linux-m68k.org>
To: Oleg Verych <olecom@flower.upol.cz>
cc: LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Jesper Juhl <jesper.juhl@gmail.com>,
       Bastian Blank <bastian@waldi.eu.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in
 localversion files
In-Reply-To: <20070206012208.050237000@flower.upol.cz>
Message-ID: <Pine.LNX.4.64.0702071537530.14457@scrub.home>
References: <20070206011819.160359000@flower.upol.cz> <20070206012208.050237000@flower.upol.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 673
Lines: 20

Hi,

On Tue, 6 Feb 2007, Oleg Verych wrote:

> -nullstring :=
> -space      := $(nullstring) # end of line
> +pattern = ".*/localversion[^~]*"
> +string  = $(shell cat /dev/null \
> +	   `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)

Calling find here is overkill, if the same can be done with standard make 
functions. I very much prefer to just add the damn $(notdir ...) and be 
done with it.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/