Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Wed, 26 Jan 2022 12:29:00 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Chao Liu <liuchao173@huawei.com>, catalin.marinas@arm.com,
        will@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, hewenliang4@huawei.com,
        zhoukang7@huawei.com
Subject: Re: [PATCH v2] add cpu frequency to cpuinfo in arm64
In-Reply-To: <bf7fdba2-7850-9d38-157d-7a1e726512a5@arm.com>
References: <20220126092349.285642-1-liuchao173@huawei.com>
 <bf7fdba2-7850-9d38-157d-7a1e726512a5@arm.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <c73a9fb20b42f2086a0fb9c068ecc272@kernel.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022-01-26 12:05, Robin Murphy wrote:
> On 2022-01-26 09:23, Chao Liu wrote:
>> There is cpu frequency in /proc/cpuinfo in x86 but not in arm64
> 
> arm64 cpuinfo also doesn't show the APIC ID or microcode version.
> Different architectures are different.
> 
> Besides, x86 cpuinfo only shows MHz if the CPU has X86_FEATURE_TSC, so
> for compatibility we should only do this on AArch64 CPUs which have
> X86_FEATURE_TSC.

/me prepares a patch to be sent in just over 2 months...

         M.
-- 
Jazz is not dead. It just smells funny...