Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c1bfe53abaf24feacb676ce940edcb8899924ffc.camel@linux.ibm.com>
Subject: Re: [RESEND][PATCH] Documentation: added order requirement for
 ima_hash=
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     "Guozihua (Scott)" <guozihua@huawei.com>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        roberto.sassu@huawei.com, wangweiyang2@huawei.com,
        xiujianfeng@huawei.com, linux-integrity@vger.kernel.org
Date:   Wed, 26 Jan 2022 07:47:51 -0500
In-Reply-To: <97142483-d7e7-e310-0cb0-30a81414cb57@huawei.com>
References: <20220125090237.120357-1-guozihua@huawei.com>
         <36b6058f2cdf6bead917c06ecc6e8769bb88130c.camel@linux.ibm.com>
         <3933adf5-4e9d-6b22-2e46-55643c504f52@huawei.com>
         <71508a72b042da330d07a624cf499561c46195f0.camel@linux.ibm.com>
         <97142483-d7e7-e310-0cb0-30a81414cb57@huawei.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2022-01-26 at 15:41 +0800, Guozihua (Scott) wrote:
> 
> 
> The main issue lies in ima_template_desc_current called by hash_setup, 
> which does not just read ima_template global variable, but also tries to 
> set it if that hasn't been done already. Causing ima_template_setup to quit.

Right, which calls ima_init_template_list().  So part of the solution
could be to conditionally call ima_init_template_list()
in ima_template_setup().

-       if (ima_template)
-               return 1;
-
-       ima_init_template_list();
+       if (!ima_template
+               ima_init_template_list();

Roberto, what do you think?

thanks,

Mimi