Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5491734pxb; Wed, 26 Jan 2022 13:18:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJygel/f2f7EbxjFAYHiXr1rCa1ldX32xgXyVAl3S0H9rrICBivIf9U/AwiDiOpa1wRfgjrg X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr880667edd.14.1643231889697; Wed, 26 Jan 2022 13:18:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643231889; cv=none; d=google.com; s=arc-20160816; b=wjcgOLfuF7kvn/KLwJ9fC017M7kyIsVmo1i4DRpIImoC1OCl/y/isIiLTk3wVOrCjJ DNaMZpL1qHTbKrUJxgvTJxjGrHk3dPvtArYVo4G243vMiuI7LtgVD9GA/ZKUE156LgPs XvwdBBGf6AMfS7TKwlJU32Smk8YSxNEceVAgY3PDw2yJxHfJh2OLhETSpzK14Dnv7JVO 60kEJYeV4iDacx5r5A3rtwQ0gIy8E9iRieaYcPMAtygSyv7lb3NgJzGIJevgsFJrAbuT 7rkzyjyg7D7RbjU2QYpF7CN3bHrBnd0LW3zn1y1l2g9jgZKR6B1JPhy7tQbVmZHXgese u9hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=irXwZIV7ke6SpUmJoQHqsbQUk4O+rPey+s7vhsF7z+I=; b=huewRnj85okF/p3vasdS4Gh4eoyuZXmXy3wyddIccl8y+D8ng/vc0Z/IP066oX6+dH ruW0b3n2vdc4TLST5aKLiKqlGN+ZlogU8dc8a04dN+qGYqjpWjpp+rRxryjuNl7aNUld BTjgsUDLEr9sBUW0qZbaUklTyzOyT/rO+94arc5bXIYhmyuagRUAlZIDMhr8F5oOpAfi BpYxP9f0WPB1UA7kYeXqpMNjYKnTYjap15depczE4NIqnAgyqqr8UblkZ3X1HIvl6q+z F+eJjz41CM4yEQxS/9irejoJPAEq/b4/LlwF8MWTno7HrNji93iSTHTw5ZE2/Bf2eNCC /mrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0MYu4r42; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si170798edq.365.2022.01.26.13.17.45; Wed, 26 Jan 2022 13:18:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0MYu4r42; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234333AbiAZNIJ (ORCPT + 99 others); Wed, 26 Jan 2022 08:08:09 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55362 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237285AbiAZNIH (ORCPT ); Wed, 26 Jan 2022 08:08:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=irXwZIV7ke6SpUmJoQHqsbQUk4O+rPey+s7vhsF7z+I=; b=0MYu4r4276Pu3XJXo3uJN03BQg Orpm6ZOMtbz7hah0m8U3mo83UMAj2YCq0nVisusTW4jf2GR44V+5IbqIKJPYG6Bs8cDGl9CZUJ4xT K5tC2WrwC8mdQwcAoQBWqaQWWpl7mprPBmVwlEZt2Q70tiEKimezY297a/7v0ezNCbm8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCi1r-002oAQ-5z; Wed, 26 Jan 2022 14:08:03 +0100 Date: Wed, 26 Jan 2022 14:08:03 +0100 From: Andrew Lunn To: Tobias Waldekranz Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Marcin Wojtas , Calvin Johnson , Markus Koch , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/5] net/fsl: xgmac_mdio: Use managed device resources Message-ID: References: <20220126101432.822818-1-tobias@waldekranz.com> <20220126101432.822818-3-tobias@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220126101432.822818-3-tobias@waldekranz.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 11:14:29AM +0100, Tobias Waldekranz wrote: > All of the resources used by this driver has managed interfaces, so > use them. Heed the warning in the comment before platform_get_resource > and use a bare devm_ioremap to allow for non-exclusive access to the > IO memory. > > Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Andrew