Date: Wed, 7 Feb 2007 18:16:30 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Daniel Drake <dsd@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 3/6] workqueue: make cancel_rearming_delayed_workqueue() work on idle dwork
Message-ID: <20070207151630.GA138@tv-sign.ru>
References: <20070206233016.GA108@tv-sign.ru> <45C9E320.3070001@gentoo.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45C9E320.3070001@gentoo.org>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 37

On 02/07, Daniel Drake wrote:
>
> Oleg Nesterov wrote:
> >cancel_rearming_delayed_workqueue(dwork) will hang forever if dwork was not
> >scheduled, because in that case cancel_delayed_work()->del_timer_sync() 
> >never
> >returns true.
> 
> Thanks! We hit this problem before with the zd1211rw driver and avoided 
> using cancel_rearming_delayed_workqueue() for this reason.

Great. But I am afraid my changelog was incomplete. This patch only fixes
the cancel_rearming_delayed_workqueue(freshly_initialized_dwork) lockup.

The following code

	schedule_delayed_work(dw);
	cancel_rearming_delayed_workqueue(dw);	// OK
	cancel_rearming_delayed_workqueue(dw);	// HANGS!

still doesn't work.

Is it worth fixing? The fix is very simple, and probably makes sense by
itself:

	cancel_delayed_work:

	-	work_release(&work->work);
	+	work->work.data = NULL;

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/