Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jens Axboe <axboe@kernel.dk>
To:     Yu Kuai <yukuai3@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        yi.zhang@huawei.com
In-Reply-To: <20220126012132.3111551-1-yukuai3@huawei.com>
References: <20220126012132.3111551-1-yukuai3@huawei.com>
Subject: Re: [PATCH v2] blk-mq: fix missing blk_account_io_done() in error path
Message-Id: <164320409207.123597.5205274330613779469.b4-ty@kernel.dk>
Date:   Wed, 26 Jan 2022 06:34:52 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 26 Jan 2022 09:21:32 +0800, Yu Kuai wrote:
> If blk_mq_request_issue_directly() failed from
> blk_insert_cloned_request(), the request will be accounted start.
> Currently, blk_insert_cloned_request() is only called by dm, and such
> request won't be accounted done by dm.
> 
> In normal path, io will be accounted start from blk_mq_bio_to_request(),
> when the request is allocated, and such io will be accounted done from
> __blk_mq_end_request_acct() whether it succeeded or failed. Thus add
> blk_account_io_done() to fix the problem.
> 
> [...]

Applied, thanks!

[1/1] blk-mq: fix missing blk_account_io_done() in error path
      commit: 592ee1197f78b30bd60c87db9b6c8c045c8d8314

Best regards,
-- 
Jens Axboe