Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220126144400.130797-1-lzampier@redhat.com>
In-Reply-To: <20220126144400.130797-1-lzampier@redhat.com>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Wed, 26 Jan 2022 15:47:57 +0100
Message-ID: <CAO-hwJ+KyV+Ks38DDF8EuT9kEc9jd9SvNn=nGyTwjkD3GOQ+RA@mail.gmail.com>
Subject: Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id
To:     Lucas Zampieri <lzampier@redhat.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Filipe_La=C3=ADns?= <lains@riseup.net>,
        Nestor Lopez Casado <nlopezcasad@logitech.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@redhat.com> wrote:
>
> As of logitech lightspeed receiver fw version 04.02.B0009,
> HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
>
> With patch "HID: logitech-dj: add support for the new lightspeed receiver
> iteration", the mouse starts to error out with:
>   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
>   slot 1
> and becomes unusable.
>
> This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.

The patch looks good to me.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Ideally, Nestor, can you confirm this is expected and that we won't
have any bad surprises there?

I think we probably want this to be Cc-ed to stable once it gets
merged (we can add the tag as we merge it).

Cheers,
Benjamin

>
> Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
> ---
>  drivers/hid/hid-logitech-dj.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index a0017b010c34..9f68c0631439 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1068,6 +1068,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
>                 workitem.reports_supported |= STD_KEYBOARD;
>                 break;
>         case 0x0f:
> +       case 0x11:
>                 device_type = "eQUAD Lightspeed 1.2";
>                 logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
>                 workitem.reports_supported |= STD_KEYBOARD;
> --
> 2.34.1
>