Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache
References: <20220123115623.94843-1-42.hyeyoo@gmail.com>
 <YfFJuQQBLJRxIJR+@ip-172-31-19-208.ap-northeast-1.compute.internal>
User-agent: mu4e 1.7.5; emacs 28.0.50
From:   Shay Agroskin <shayagr@amazon.com>
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>
CC:     <jwiedmann.dev@gmail.com>, Arthur Kiyanovski <akiyano@amazon.com>,
        "David Arinzon" <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        "Saeed Bishara" <saeedb@amazon.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Sameeh Jubran" <sameehj@amazon.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        "Lorenzo Bianconi" <lorenzo@kernel.org>,
        <linux-kernel@vger.kernel.org>
Date:   Wed, 26 Jan 2022 17:16:35 +0200
In-Reply-To: <YfFJuQQBLJRxIJR+@ip-172-31-19-208.ap-northeast-1.compute.internal>
Message-ID: <pj41zlilu61q85.fsf@u570694869fb251.ant.amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Precedence: bulk


Hyeonggon Yoo <42.hyeyoo@gmail.com> writes:

> CAUTION: This email originated from outside of the 
> organization. Do not click links or open attachments unless you 
> can confirm the sender and know the content is safe.
>
>
>
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the 
> driver
> does not use napi skb cache in allocation path, napi skb cache 
> is
> periodically filled and flushed. This is waste of napi skb 
> cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
>   netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thank you for this work

Acked-by: Shay Agroskin <shayagr@amazon.com>