Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5525876pxb; Wed, 26 Jan 2022 14:09:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJz20IY9JZNezmaGIQkp5087zaVGloZIOhTb0hPSBl+3fCJCGa5yZwHgdipF/7rwQcPc4bh2 X-Received: by 2002:a05:6402:42c1:: with SMTP id i1mr1037720edc.52.1643234956506; Wed, 26 Jan 2022 14:09:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643234956; cv=none; d=google.com; s=arc-20160816; b=XppigFdXWX0b/rCqm0jCeN6CxDE6Nf+jv6Cvw4Nkqky2svn8RrD1YT1aHukf/il55P Uzk8fSjZR2CYlvXe7kZFHj1IloHlQNctHyCTe6pydQLBbIoVLcrH/ThwbcYtixK5/yjs MCK3k/TVJf2ZIuC5zYYxsdr0xfKAKH6SB1c2achjXVnhdTT3KVO98I6YeofwLULUr6AU /8O+rC3t9oM+7hO6EtCtnyIn12KEw74GX4sd4oedWQI2TVeF/feUysRFRAXFr0q1myDQ l1/RZkYaGTs1fkegmzeVZHhFyXsRJ1unLEKTjhVvQYT9ksCXykRIrc6Sl0oIPKxPAX5c YTDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d2hfJnq7WFG6jJbY1jQ64KsykK+O3FA7XQ9vdxvBn90=; b=OKmbHhSKI1tv+cThCw3SB+GDXohw/yrNbcRrSp+jyzU7M55Ir41EpD5QEzAHdiq1xD 40OHjfpDlqDSpXeut9rxKpWi4Blyi9a66Fb2Aht4cpvatcCFkVbqKpVJ1DVSrlkvz5FT ZO7U3JxzH6a5MaQ4Ay8P090xCiYqfwDAHAMLXs3pPY07X+v7KRkJiRGZWuI3pQm9retm ICWO100Z6EccS7FiVAj8228MbNiV3so6WRZ0kOJs++0e0BGpbVPdobSjlk8d5TjtBg2b J25HoFx4W9B4/8t1Ar14UPgagRuh2OCGYkb8ZKxY4iLDWopAD283YxCN+Cvcs6b4wZ2R me9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fxrbuXDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o19si273220edr.209.2022.01.26.14.08.51; Wed, 26 Jan 2022 14:09:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fxrbuXDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbiAZPy1 (ORCPT + 99 others); Wed, 26 Jan 2022 10:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiAZPy0 (ORCPT ); Wed, 26 Jan 2022 10:54:26 -0500 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A984C06161C; Wed, 26 Jan 2022 07:54:26 -0800 (PST) Received: by mail-qk1-x730.google.com with SMTP id b22so4820199qkk.12; Wed, 26 Jan 2022 07:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d2hfJnq7WFG6jJbY1jQ64KsykK+O3FA7XQ9vdxvBn90=; b=fxrbuXDps7bOVDI3Pn+WxxehZMZBBY1HydEO72ENhhutcwBCI+hmGQ+wJgoWASvsgz cjhBQX1tKM9lDW6Zaj6ubROCjBk3rXIHp2R+GTeTBgO11RTbNF7BFgVBUtKgsML1Wp+2 Sw6EZHJNwLfuZumruwVCnPDLIMWCUf3EmLXHCzhXzKpAwc4acw3fAUXRe4lSfG5Y4rBy ffITB/xAhu1rp926aEEHwRaf3FVxINsrX9DdfQu4OyhIbfzpV5SuzqbVTZmhZikxn+8j hGQ2lCR8QvMDeUyH/vCJqjdbNdHTHQM/ajihgBqfMBRE2o7v3Q3tUul1PjQ8vWfNp7GR UlxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d2hfJnq7WFG6jJbY1jQ64KsykK+O3FA7XQ9vdxvBn90=; b=Cj0zKpzavFoYf7jZzY7AhcVsVLLyhD+dLaRO+jPB1Nu6r2mp0OFkydPEzgoBgL0miN zBpK5/aTQoBPMOAYmMon3yEThJpOLDFkuqSyk1BEe46AKHGA25ZVUiPEkzFFBdpzFT51 I8n0R/mwFFqj/GpQcr/RW7nZTc7zIe+JlmM3ff1s6k+u7okbj5VzoP2PWElS0qNpmK13 ywJg5WBB8obFOoA6rbXY+LEYQelainCmznoTSrh8Knd/d/xsIh9FulLj2LvuQIzfX+or w8E9QntuAKMsYjj3nSSQbMOp8PyDp6FhspW3GzoVNelHrqEGV63kjTZHaqH5wxzxPSYu ZkVw== X-Gm-Message-State: AOAM5334zTX6/D0BIpWdvGur5v7Evv/ZgFvlE0Mfbb/SRgyivDvJHAxl LYVNSWjU6rz2dx5xYf7VDII= X-Received: by 2002:a05:620a:2915:: with SMTP id m21mr8359108qkp.374.1643212465186; Wed, 26 Jan 2022 07:54:25 -0800 (PST) Received: from shaak (modemcable055.92-163-184.mc.videotron.ca. [184.163.92.55]) by smtp.gmail.com with ESMTPSA id b4sm10815876qkf.61.2022.01.26.07.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 07:54:24 -0800 (PST) Date: Wed, 26 Jan 2022 10:54:22 -0500 From: Liam Beguin To: Andy Shevchenko Cc: Peter Rosin , Jonathan Cameron , Dmitry Baryshkov , Jonathan Cameron , Andreas Kemnade , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Lars-Peter Clausen Subject: Re: [PATCH v2 5/5] iio: afe: iio-rescale: Re-use generic struct s32_fract Message-ID: References: <20220110193104.75225-1-andriy.shevchenko@linux.intel.com> <20220110193104.75225-5-andriy.shevchenko@linux.intel.com> <20220115185203.567780e8@jic23-huawei> <34c121fa-2a3b-fb6b-f6d5-fc2be2a5c6b7@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Wed, Jan 26, 2022 at 02:04:53PM +0200, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 11:26:50AM +0100, Peter Rosin wrote: > > On 2022-01-25 19:17, Andy Shevchenko wrote: > > > On Tue, Jan 25, 2022 at 03:54:07PM +0100, Peter Rosin wrote: > > >> On 2022-01-25 14:17, Andy Shevchenko wrote: > > >>> On Mon, Jan 24, 2022 at 04:28:09PM -0500, Liam Beguin wrote: > > >>>> On Mon, Jan 24, 2022 at 05:18:32PM +0200, Andy Shevchenko wrote: > > >>>>> On Sat, Jan 15, 2022 at 06:52:03PM +0000, Jonathan Cameron wrote: > > >>>>>> On Mon, 10 Jan 2022 21:31:04 +0200 > > >>>>>> Andy Shevchenko wrote: > > ... ... > The problem here is that every driver would like to do this differently > and since it's related to the calculation we will have all possible error > prone implementations which do miscalculations (yes, one may not notice > traditional off-by-one until it becomes a huge issue by using additional > conversion formulas or so). > > > But sure, feel free to suggest something. But please hold until the > > current work from Liam is merged. > > That series is clearly more > > important, and I'm not really interested in neither adding more work for > > him nor a cleanup of the current code without those pending changes. > > I'm very well fine with that. As I mentioned from the beginning, I may rebase > this on top of the Liam's work. I appreciate that! I'll make time to wrap things up so I don't hold you up. Cheers, Liam > -- > With Best Regards, > Andy Shevchenko > >