Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5526378pxb; Wed, 26 Jan 2022 14:10:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMCuxbZhMGcnWG+I3w91kEVHKtr8ERxOZz9UPowW1/R013E0XgEqiTZrvRt9W25NyRv30W X-Received: by 2002:a17:906:3f1e:: with SMTP id c30mr570615ejj.715.1643235001270; Wed, 26 Jan 2022 14:10:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643235001; cv=none; d=google.com; s=arc-20160816; b=lUASX+AidQ1QXFD1MyjTLA6hWuv1/nOFhwUdME5i7xiV4+KU90nQfk08mOXJEts/+a f8TEMkAY2WJC2Mr0IEw8tF1faYxq/4renOT2QrAz69mEyqFo4ctCSNN7mXtRQBcvdEtb VurduFvH0aE60bfcNNXyEXh5ULCp7Iir9r+LWYuTyYoPJLkgOsjsgnANLbWFfcUDTNAt VZWE3JD2wdkg8y3RYeb3SeqRfR2FApHXT2XSCDE4+ge9pWsbHQDt0Au31ywmbRgvBaur pd/2yVJJwGgo4PubMG6d1ZlAX9DuMO9awqQ3PTvpbPJ2PDcpi42UztqGOqRNTQO3VziG 23JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/OGj9Dh75ecVQT06TTfvUexBVpHyCwtGLuCHJ3kfX74=; b=ShpgNfa9ADXv2Xi6J+rq+icZ1szG9NEf8yBoEQ7E/4wUadMjOdZvQOINcazlYRxU3S SoMO0oQh5yI1l+6xfu+lSwygm+yEKtvZA53cEtVOQYm7YQ8TpWWpbMT8Wle29cFUA84V p3pshkqP2mOH7vcRW2qwwpd1eoE/tFO4tqagC6FgJirJA66KcAlhK3W+PH4d+QuKcQPN bdDa8Id/LvG9CbB+M2X74yj9xmCnLY9i0NztwGY16Yu3lvOE8S2j5J0D7thYehbTLyBN UGYUfgG81CMw9ihphHWgYkl6imOpnH138eQTPTp3hjf84acnJl2p9tb/fPROCZWOc0Qd sidw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J54nB+Bd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn27si251512ejc.879.2022.01.26.14.09.36; Wed, 26 Jan 2022 14:10:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J54nB+Bd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbiAZPzL (ORCPT + 99 others); Wed, 26 Jan 2022 10:55:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbiAZPzJ (ORCPT ); Wed, 26 Jan 2022 10:55:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86D8C06161C; Wed, 26 Jan 2022 07:55:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6C6C7B81EFB; Wed, 26 Jan 2022 15:55:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB77AC340E3; Wed, 26 Jan 2022 15:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643212507; bh=X5P7SypHxAAfJ47P91nn/OKaN+5VlziSqogExTqXlTg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J54nB+BdimL640xPgpt9D+WXeL1/7axgnjfCVyoLTbv5dw5nCraemz2kTli0+Rxv3 TfXuNs/KozWx3J4uFI/t3RCu7mXARI195wwzc2/hWILG2348nJAMqsfsPp8GtyloHi DvRIRMZ7LT1xhDGKrtvYnpPgOSSQnDOqiy+AjTFE7s/uSr1S8d9GNGL3T6PutoM/MP e8nS2LoLCTjayBdDl0/f3pqNnXD4NtbQE3m48oE4R7lvm+RCPYRiWuaqwKyswLK7h9 COxhLA+bf0Nrghs8qgoLNeITA1BZMbDXgqcsx/pEIJMAaGZNdluC+b951WdTU9NZQQ sdQpnB1qVwafA== Date: Wed, 26 Jan 2022 07:55:06 -0800 From: Jakub Kicinski To: "huangguangbin (A)" Cc: , , , , , Subject: Re: [RESEND PATCH net-next 1/2] net: hns3: add support for TX push mode Message-ID: <20220126075506.0d36076b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <83c5ef91-59c0-aa54-b698-9f069a8d8280@huawei.com> References: <20220125072149.56604-1-huangguangbin2@huawei.com> <20220125072149.56604-2-huangguangbin2@huawei.com> <20220125195038.6a07b3c4@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <83c5ef91-59c0-aa54-b698-9f069a8d8280@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jan 2022 14:48:30 +0800 huangguangbin (A) wrote: > On 2022/1/26 11:50, Jakub Kicinski wrote: > > On Tue, 25 Jan 2022 15:21:48 +0800 Guangbin Huang wrote: > >> + __iowrite64_copy(ring->tqp->mem_base, desc, > >> + (sizeof(struct hns3_desc) * HNS3_MAX_PUSH_BD_NUM) / > >> + HNS3_BYTES_PER_64BIT); > > > > Doesn't build, missing closing bracket? > > . > > > Hi Jakub, > Sorry, I didn't notice that net-next has not been merged patch > "asm-generic: Add missing brackets for io_stop_wc macro" at > https://git.kernel.org/arm64/c/440323b6cf5b. > > When that patch can be merged in net-next? Likely by the end of the week.