Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        John Ogness <john.ogness@linutronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] panic: Add panic_in_progress helper
In-Reply-To: <Ye/jhjBaN35L76BF@alley>
References: <20220121190222.572694-1-stephen.s.brennan@oracle.com>
 <20220121190222.572694-2-stephen.s.brennan@oracle.com>
 <Ye/jhjBaN35L76BF@alley>
Date:   Wed, 26 Jan 2022 09:37:51 -0800
Message-ID: <87v8y6wg7k.fsf@stepbren-lnx.us.oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QtCjW9hyJjE58yZ1aOHRXaUy6xsW7wVarMuoM8vU3n7NR6578+VXbLi9nLSw?=
 =?us-ascii?Q?lUBTaBH0WcB+K163oKi305NwtMYGJ+XqoB3Br6NWVJ+Imal1IUzTorFJWm7N?=
 =?us-ascii?Q?Xh/343bKnoIRFVHgO/ZSLGa2DCVhytoGnjV3bK2CnO/+rHxMEtxlCEcXULsk?=
 =?us-ascii?Q?Agqs+FUqgV4eSblbhI/zLmwEL+katdzUfohwywGQSRSEh1lUO2yZ1TPQ+U5a?=
 =?us-ascii?Q?GFjTYlHc4sJtLI0F5XVuWx/F164oGXYBI3R0xKyOOu9RhowlEBIAeysV2NTC?=
 =?us-ascii?Q?T+RX9hoSuFVlw8l+3Vm/xFFlmEORC6omv6EfNOdJTcQbnJY2YffEChlHKVPx?=
 =?us-ascii?Q?EMhPiiUZIgM2iOLM880LqdGfB7dasnZm8b2Azqqw+DPEVuWS4BCqUNl8NixZ?=
 =?us-ascii?Q?PzkUvqVcVuBU6jDzNGFt3ajY53TCRwYGMOOqPYDl0I/9Hjkj0qfbbbeLKHnK?=
 =?us-ascii?Q?PGNjP8cQHJsIR2Jx1Tgx+UM8G9l03eGuYjYTOxZodRzs4GW7pal5mtteM0Qw?=
 =?us-ascii?Q?/TPK+DrPqHcXU/ixn6MzeboJUOS4z+vNE27v7tl/z2+bAzFn/HULYRi92kMl?=
 =?us-ascii?Q?MO6bQAxtqM+bBBi25Ks3w6N6CLWxEuxxd/pmEMR4gtKRxwJ/iyW2n+UUPU83?=
 =?us-ascii?Q?i0vN1FeqfQRn95znNlD0RiPeGcvIxVl9E6iat4K7viVEHIuu+2bJ6DdNPOl9?=
 =?us-ascii?Q?oT8+OTfSklTobgkUGbmcOlo8TQPkUmik73xZXHtr9y0bwjfXW4wRHZU9TKLP?=
 =?us-ascii?Q?eHbL6xGFSpK+pCd4Qs/5BGvcRIIeWatpCzQTN4gKf3bmijJ35HOGsDAmGdpa?=
 =?us-ascii?Q?y7c1ZJ1rBX2fJqSLSD+Db7V1hAF3iRI04fteKO2TeHTeFk11ei4EUBbLD/eU?=
 =?us-ascii?Q?v7F3r082aop+ibxTp9jHbA+kzTzrSKyAv0oGV/7DDRJAmNPmSfW5l5XCZJJn?=
 =?us-ascii?Q?v94rAj+l/09rDxUgXm9CmZMoBZhegKcjssiwLTuf7hLnvyPd6D01omF0iKoC?=
 =?us-ascii?Q?qH43Qwu3LPU2q493ErulQaYK8LubAzj4irqQITEgWg6woFneKnYZU/8tUSkZ?=
 =?us-ascii?Q?9yTBWnX3n4Di71Vt6c/crpC8XZlxZRQB3rzQOggAWZfRomfVVInukBUE/TkE?=
 =?us-ascii?Q?ZAz/eFJBOF5IigX7Gz+m57yV0paSD53nkw0VOc9HEvVP5QWC0ZlZaHOAimIt?=
 =?us-ascii?Q?IHzd2vJqYtOoHgzDebbZkrLS1cu8iAqabXS1lkCmF4/EwaZ5K0y6ThBL4sh6?=
 =?us-ascii?Q?1wFH45WIJk6adAT3MHiQI7jZnYoLaK0KnMLvVhB3hdwf2n3qxMMSCcwNifY3?=
 =?us-ascii?Q?3Qc8ZgMkVszLgDzSe55ECBKnJh3KniUEf23auvHUCIGjJIP/61KQ/LbNiiYR?=
 =?us-ascii?Q?OwXHhWEb08RXcxuvYsP4RQCsiT9OkITargYZIa8cVxH608Qy6WdmZ+pI1JxI?=
 =?us-ascii?Q?RsqsdtvwHUdNTIxUZA2D5NP4fITzJShc30CgP2YdcqLypWfpBSC/y7U7n/O6?=
 =?us-ascii?Q?WyBJO9sXvlNB9OA2lfcG6eLMPLeEMsH3m6OlXFTI5XdfzpbPHuxbI6hVFSTk?=
 =?us-ascii?Q?x80Is5/J5L/L0wU7GzV8lBdRjumk4VQq8omlc+WxcdP44BMeayQV3f0eGAyI?=
 =?us-ascii?Q?PR/W/FA3vMz0bfD0NfqaTJFiitHSvxUu0RcFrKfmpl0gW7ma2Q4SmTeolKKz?=
 =?us-ascii?Q?Jdr6Nw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dfcb827-20ec-4c35-c36c-08d9e0f292a0
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 17:37:49.9334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZFvyoyQrR7aqzkhIJVawJTCClLG7j7Po9fE0Ei6pHG7kSgF80ANIcna3a+fO6PeYCPVu4xyNmFNc5u0yeL6bfu20Z41Fupft2Wk5/oP4nM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1881
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10239 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201260107
X-Proofpoint-GUID: b8AUu6xozdBjSrJe9UHiXN0aK64pKS0t
X-Proofpoint-ORIG-GUID: b8AUu6xozdBjSrJe9UHiXN0aK64pKS0t
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Petr Mladek <pmladek@suse.com> writes:

> On Fri 2022-01-21 11:02:19, Stephen Brennan wrote:
>
> Please, add explanation why the new helper is added. It will be
> used in printk code to reduce risk of deadlocks during panic().
>
>> Suggested-by: Petr Mladek <pmladek@suse.com>
>> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
>> ---
>> We cannot define a static inline without including linux/atomic.h, so
>> I just added a macro for convenience in later patches. Since macros were
>> the only option, I didn't include a helper for
>> panic_in_progress_different_cpu().
>
> What is the exact problem with including atomic.h and using static
> inline, please?

Hi Petr,

linux/panic.h is a commonly included header, and so I didn't want to
pollute the namespaces of many other compilation units. (In fact, for
stable kernels we avoid changing headers to avoid changing the hashes
produced by genksyms). It could impact compile time too.

But I suppose I was prematurely optimizing. I can make them proper
static inlines instead :)

Stephen

>
> IMHO, the define is not a real solution. The macro won't be usable
> without including atomic.h. So, it would work only by chance.
>
> But it is possible that I miss something.
>
> Best Regards,
> Petr