Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e4e1995c-4fc2-96b7-c732-93aa67207802@vivier.eu>
Date:   Wed, 26 Jan 2022 18:32:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: fr
To:     Greg KH <greg@kroah.com>
Cc:     linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        Alessandro Zummo <a.zummo@towertech.it>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org, Arnd Bergmann <arnd@arndb.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        John Stultz <john.stultz@linaro.org>, stable@vger.kernel.org
References: <20220121200738.2577697-1-laurent@vivier.eu>
 <20220121200738.2577697-3-laurent@vivier.eu> <YfFPjOEELiTWr2uj@kroah.com>
From:   Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v12 2/5] tty: goldfish: introduce
 gf_ioread32()/gf_iowrite32()
In-Reply-To: <YfFPjOEELiTWr2uj@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 26/01/2022 à 14:41, Greg KH a écrit :
> On Fri, Jan 21, 2022 at 09:07:35PM +0100, Laurent Vivier wrote:
>> Revert
>> commit da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
> 
> Why?
> 
>> and define gf_ioread32()/gf_iowrite32() to be able to use accessors
>> defined by the architecture.
> 
> What does this do?
> 
>>
>> Cc: stable@vger.kernel.org # v5.11+
>> Fixes: da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>>   drivers/tty/goldfish.c   | 20 ++++++++++----------
>>   include/linux/goldfish.h | 15 +++++++++++----
>>   2 files changed, 21 insertions(+), 14 deletions(-)
...
>> -- 
>> 2.34.1
>>
> 
> This feels like a step backwards.  Why keep this level of indirection
> for no good reason?
> 

It was proposed by Arnd on my previous iteration of the series when I wanted to update goldfish-rtc 
in the same way:

https://lore.kernel.org/all/CAK8P3a1H6-sd_+FqnOq0Zhj=L51EWuW5VCcYeTENcp3+PkTC4Q@mail.gmail.com/

Keeping __raw_XXX() functions works on most of the cases except if the current CPU endianness can 
differ from the architecture one (like a ppc64le kernel (little-endian) running a ppc64 machine 
(big-endian)).

The best solution would be to update QEMU to set the device as a little-endian one, but google 
didn't merge its implemention in upstream QEMU and this would break all other OSes using goldfish 
devices on big-endian architectures.

Thanks,
Laurent