Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 19:02:26 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Alfasys <alfred@alfasys.se>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Damian Hobson-Garcia <dhobsong@igel.co.jp>
Subject: Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices
 using command line options
Message-ID: <YfGMsujnTxIxlXp4@kroah.com>
References: <qFul607Amxy21SnrHljzWlk1zF1aanKgSpEIH0--hvj9t9wRzQR5xx80eFgl_2I6pppi8NNFp0TTHwkQw0uQD0Xl-8vth8-KOsbfwrLIHNg=@alfasys.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <qFul607Amxy21SnrHljzWlk1zF1aanKgSpEIH0--hvj9t9wRzQR5xx80eFgl_2I6pppi8NNFp0TTHwkQw0uQD0Xl-8vth8-KOsbfwrLIHNg=@alfasys.se>
Precedence: bulk

On Sat, Jan 15, 2022 at 04:42:02PM +0000, Alfasys wrote:
> Add an option to bind the uio_dmem_genirq driver to a given device
> using command line options.
> Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
> commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices 
> 
> using command line option")
> 
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> Signed-off-by: Alfred Patriksson <alfred@alfasys.se>
> 
> ---
> 
> git diff c9e6606c7fe92 #(tag: v5.16-rc8)
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index 6b5cfa5b0673..7f6c9b594dd4 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -317,10 +317,13 @@ static const struct dev_pm_ops uio_dmem_genirq_dev_pm_ops = {
>  };
>  
> 
>  #ifdef CONFIG_OF
> -static const struct of_device_id uio_of_genirq_match[] = {
> -       { /* empty for now */ },
> +static struct of_device_id uio_of_genirq_match[] = {
> +       { /* This is filled with module_parm */ },
> +       { /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");

I do not want to add new module parameters, this is not the 1990's
anymore.

thanks,

greg k-h