Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5541919pxb; Wed, 26 Jan 2022 14:35:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIFH6kYyfPbMss0+flkH0CAnp5XK3loE5SBocKEsNM+Uz5A7EDdQpkiBAfcCpVn21UWQlx X-Received: by 2002:a05:6402:5213:: with SMTP id s19mr1033667edd.27.1643236505854; Wed, 26 Jan 2022 14:35:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643236505; cv=none; d=google.com; s=arc-20160816; b=LDDoYJzAEW/dHfaJfGC7wwJ3bSPUZYsba2yBSkYOyi7wf+9dn2tu/e07ZIpwoxk33L OeC+0GuHwWR2zLj58cpOqgWJc33S8Ayv878aXb45RlgaRxQy0oM48yGnYnt6luw5AZn4 wWD6wjxBsHyJJeHSdc27I1+TM26WC5MRf0xUY0SgG1xMHKJMIlaahB6MpjuCf3zMdoEp 1GdV0Vd9On/KuOeCrM21MnspDNzKxw4P6g9mfrTUsX5SLziDpzyrOwA/E+iNZA4qu6w3 KfT5/rBkISjzfcxFxrwJgPFxfo9ZIJR0upeiSmAY9YRhewDM6xK/PR2TgMPhqezp1TmI zJRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=VDOhpqDLAkmVNH0vSKJoGMou1SGqznw9FL9tts+vhro=; b=vCtElQ0PZHnkLvsq7qZDhpR7lf0CRZo/98GzYxpeW4MxmhLILl+wX9h/6ljPovrhYv ULNyGhdPEi7veK7wjynRz468Bbdi6CiFG5uMb1wMPyFNZA5k7mBeQ9cLgwRwYaaIeqc1 lSAqoOxCkvPBhw2WTcVSA11oHWUX3fOlo74iBKEVcfvk3dY4TAK0Z7oFbnBVm3jWJPhc krC/yiy3OO4U+rz7zCfYfaKeEDFVMuLjztpehwsAxgEVRZKyJ/l0YmsuwCNlfciXTCTi 7vbpmmQBR/3NBBjHkK/bDDyeEmjAsuxVVgmKKE3Kk3s/XbGFYdYcM4GU0gZ9ggbaRFAs E8cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=pk7kVJBI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u2si293187ejy.26.2022.01.26.14.34.40; Wed, 26 Jan 2022 14:35:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=pk7kVJBI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244633AbiAZTzy (ORCPT + 99 others); Wed, 26 Jan 2022 14:55:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244622AbiAZTzx (ORCPT ); Wed, 26 Jan 2022 14:55:53 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B89B3C06173B for ; Wed, 26 Jan 2022 11:55:52 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id n10so712715edv.2 for ; Wed, 26 Jan 2022 11:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VDOhpqDLAkmVNH0vSKJoGMou1SGqznw9FL9tts+vhro=; b=pk7kVJBIVlARurWljVTuYqW6e9/jhw0DpwpRvNzFAwwMjW7CJN9QYc5+ablTU8ExNw YnjgmMVS+c4tUnC+cGYGxu89gK/xkRz5f1irk8HUJdyF8JvPcdIplIbxX54exyKv+9hO IiAfL4Exm3Jy34fbBrKIK1fPhixkzPZFmCU9HPxs191eGw1V4AkEvxE+WJcz29D2nD11 uoI9j3OkdZh/ptyRswPcP435zDLxYSrTxnrRVia4OgvMYuarlTNCxa6Rc6OHRSDfPtIS ab4nyCOgMr9QtUfptZuL6ZvK61bW6UtJcV1hSxWDHsMzgQAq2mMyRpoxO1aY8Ujb4rsv cqlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VDOhpqDLAkmVNH0vSKJoGMou1SGqznw9FL9tts+vhro=; b=ITt35p6Hq/UDs75SQZntXwfz4WEmw3A9/SxhNfJBgwlZzXAj6cpOzfNPQ/b4oAXhqz YWTnbWKt378hoVJaSwbevX/b1o/OvLOkeqeOxhxclOpRIL6aFxf2AI97pn4mfyKN+hAR yZSn04FydAFvVXUQMhVYilFT4yz4NZiIvlu+ApPYK7i65Ijv6Uz6RgPnFhau3ZPev5zQ bGDwm4jtGrtBfRYqlBM3Bp7JRRdeXn5/IDKNF3PxWMaQ910cW/gZcM/ouJfkEY0gVyg1 hiIlLd2lK695+lcBSKeWmPzs60jbCrbq5wtd+lmDmv2iOMLxrSHY5I6euy0H6V1i8aes 3B1A== X-Gm-Message-State: AOAM533JvXYvZf671FLM3zjDHqfGDXqqOCoyhyT52/+U0mjzZ0N4AmQI PrIVaFtHwPcZN+kcZpSPKv4LXCOP2E15E9CYGUDvxw6b0jI= X-Received: by 2002:a50:eb46:: with SMTP id z6mr520229edp.229.1643226951036; Wed, 26 Jan 2022 11:55:51 -0800 (PST) MIME-Version: 1.0 References: <20220118190922.1557074-1-dlatypov@google.com> In-Reply-To: From: Daniel Latypov Date: Wed, 26 Jan 2022 11:55:39 -0800 Message-ID: Subject: Re: [PATCH 1/5] kunit: tool: drop mostly unused KunitResult.result field To: David Gow Cc: Brendan Higgins , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 9:19 AM Daniel Latypov wrote: > > That being said, I can live with the current solution, but'd ideally > > like a comment or something to make the return value Tuple a bit more > > obvious. > > A comment to explain that Tuple == multiple return values from a func? > Or something else? Friendly ping. Do we want a comment like this? # Note: Python uses tuples internally for multiple return values def foo() -> Tuple[int, int] return 0, 1 I can go ahead and add that and send a v2 out. FYI, if you do this in a REPL >>> a = foo() >>> type(a) The syntax for `a, b = foo()` is just using Python's unpacking feature, i.e. b, c = (1, 2) So it's all just syntactic sugar around tuples. > > Also ah, I thought we had more instances of multiple return in kunit.py. > Looks like the only other is get_source_tree_ops_from_qemu_config(). > isolate_ktap_output() technically shows this off as well, but via yields. > > > > > Thoughts? > > > > > > -- David