Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 12:30:55 -0800
From:   Martin KaFai Lau <kafai@fb.com>
To:     Pavel Begunkov <asml.silence@gmail.com>
CC:     <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Song Liu <songliubraving@fb.com>,
        <linux-kernel@vger.kernel.org>, Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH for-next v4] cgroup/bpf: fast path skb BPF filtering
Message-ID: <20220126203055.3xre2m276g2q2tkx@kafai-mbp.dhcp.thefacebook.com>
References: <94e36de3cc2b579e45f95c189a6f5378bf1480ac.1643156174.git.asml.silence@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <94e36de3cc2b579e45f95c189a6f5378bf1480ac.1643156174.git.asml.silence@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vYA58QwL/W6clYeiU8oEgGPQXj7+6JXfK0+8XvtO+tra1nrGxdJelHzzDeNt?=
 =?us-ascii?Q?bkCqGXx0UD1PaDTZa02NFRblfw3qqVhOiQxckqmDbxzGYCWuQh16mr3Tw4o3?=
 =?us-ascii?Q?HiZPrjqTo7iOrJ6QcpA8xB7Ho0GDOw1WH7LRpqiI5xPkUCuRqKVvjCKX64tb?=
 =?us-ascii?Q?lB6Ba3ux0IZDug8p9ViA/u1i9z5uMIR9v2roXzEdLDgwTi1vx/IH+O4RDbhv?=
 =?us-ascii?Q?X6mpFaDkm7fMkYlB4GelVR79QGqKrznJ83jJq7nWj0p89qSa1pDp1x1haxAk?=
 =?us-ascii?Q?gA//DT4Fg5oY9EEA19JbkPzM+PMTezBR0TVlJw9im8f6G4NfwxbAzZD8NtbJ?=
 =?us-ascii?Q?/eW9nB2VG/HkKL5p7vpegX82h5R4ZtMghp6nME27kiwQ6Soko/U4j7Vy/V1u?=
 =?us-ascii?Q?JjxVePb51IfW+L6EONerJ6ao3XOHNNH1wekO39Uw757c8+5x2XvZ1etF076Y?=
 =?us-ascii?Q?TB6+cZTFox5R69sxOS16rG2YaBLC2weOwhegJGpyqHrtvlmwY3UFgg5cetzY?=
 =?us-ascii?Q?y4fxm4mZLk4Ee4HGJtIiFupbS4WLxE78A5gnJZLIx9G379HbYOgw9moDKLTh?=
 =?us-ascii?Q?Jm35mag3DhRnCNC0GAzcEPU6l7kBg5zM9Gp+kT2sXnzJDCAwpZ0IUBcZFgxB?=
 =?us-ascii?Q?U/F1CTwtaBevsCJT+T93MmzMB6P5reiRL9aKAqv1TBN0GCCQ4cmSjgq7bFtg?=
 =?us-ascii?Q?RDb7b6odPKNKWT1xOpZY121ju4TTRXMd7c0vVe2sILXXDY+dFPjdQIdKBtmd?=
 =?us-ascii?Q?PkJCkEMlBbHESd+yH+lop55HpPkNMfVtD7XcdrjSWM+Dab3mj8jLZgb/+JUA?=
 =?us-ascii?Q?mZJsvg+Y6t7W4Sck3RnuQKzEPdPG1g+g/bbKO7E4uoMY5ou+di7XUm4WS7+U?=
 =?us-ascii?Q?ncYeeQDTgtxoIKQLCuhPiRkg5y7FcvtUkWoOr/ZcQ7DBJRYeONpM8paR9chO?=
 =?us-ascii?Q?1S/i3v/5JISN3vx5LLKPt+lHFj4KrNb6XOWJnRd3gbGm6SiKdWIFFfDiEqX/?=
 =?us-ascii?Q?UJmpAHC7jub1CDmTQhimLrLeTX3KlrzN1wLXUrXQKdabF++ggtS+R44649Ei?=
 =?us-ascii?Q?8Grx4ipXImqYxKojm/xlnhYvQni8VS0FZ2+i62nYL5bR2HnRb/E0JBcPxGsV?=
 =?us-ascii?Q?ewYxTzUgBPhVhtAl3/GM6UyN9Jnx7875BAcJfYFO+OMl/kzFO+jL4ijYRixU?=
 =?us-ascii?Q?zUF7A+9qGIPwFyLdOToSfyW7Ar+PcR6beYsumJRq/oWFQOUwzLLCi1FQAB0w?=
 =?us-ascii?Q?Wmg6YDCV3iHG/eGXx4mJ0BloemS5YfluvIpWO86vWY5u4gYVkd4HylXSCGNn?=
 =?us-ascii?Q?TL3TOgkfNErA9P+2zOKFJMym9sAL3N+yWO52ezl0CWFBdYYn1Oa0yR+Vn9v+?=
 =?us-ascii?Q?qx1RBUVjWqr0tIXqc6bJq0fhqbE08irjtIYHNDkPwqzCIpI9iP15y/7LfYtd?=
 =?us-ascii?Q?QNBxRtPBS4xGzI8ze5K48Uv15HvPtHPjzAZ+25Zg0q/55mYR4G4aLF1TX4/4?=
 =?us-ascii?Q?5keRppRU6Bnw4y8/KQfP6A5mNf77+CFolKu416GJp8fM8riRnFq1l0aKVw6s?=
 =?us-ascii?Q?3mrt6oj7l+yUpR1cjbdOFx0hlDgUSzGX65tGMDuy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 512cc3fd-29c4-420b-7606-08d9e10ac253
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5016.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 20:30:57.7203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U38anm8q9e7RBdvjN5IDvTonpJXyOOuy8EuFsid01feu4KaTckJZ9Mba2tGcmpuJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3013
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: EemO1T2ny_z3y_TCt_9IuM8Vt5S8vYi5
X-Proofpoint-GUID: EemO1T2ny_z3y_TCt_9IuM8Vt5S8vYi5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-26_07,2022-01-26_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 adultscore=0
 clxscore=1015 lowpriorityscore=0 suspectscore=0 phishscore=0
 mlxlogscore=566 bulkscore=0 impostorscore=0 priorityscore=1501
 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2201260120
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 26, 2022 at 12:22:13AM +0000, Pavel Begunkov wrote:
>  #define BPF_CGROUP_RUN_PROG_INET_INGRESS(sk, skb)			      \
>  ({									      \
>  	int __ret = 0;							      \
> -	if (cgroup_bpf_enabled(CGROUP_INET_INGRESS))		      \
> +	if (cgroup_bpf_enabled(CGROUP_INET_INGRESS) && sk &&		      \
From reading sk_filter_trim_cap() where this will be called, sk cannot be NULL.
If yes, the new sk test is not needed.

Others lgtm.

> +	    cgroup_bpf_sock_enabled(sk, CGROUP_INET_INGRESS)) 	      \
>  		__ret = __cgroup_bpf_run_filter_skb(sk, skb,		      \
>  						    CGROUP_INET_INGRESS); \
>  									      \