Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5617318pxb; Wed, 26 Jan 2022 16:38:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJza4DhrMjT6nPotdyUrRcaFqXsnHRoEyHwpaEeRs4woFRB8G2Jzh3v5Bbx8wsY30UuDCd6B X-Received: by 2002:a17:902:d50a:: with SMTP id b10mr1510173plg.9.1643243924028; Wed, 26 Jan 2022 16:38:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643243924; cv=none; d=google.com; s=arc-20160816; b=AljFUZ1JndrtsLio38GBERnMQpuYSfJsUAXDX2Q3jDvILp/YYwI5kQI3IxxSYb4w6M QCHvDuPYJOTpFWWhxi10PkhRS1IsZhexqBVzx9fSEIJmfbFOjMY7fbGR6IPhwAbw1SBb CA5YHGOBFrJPfpgBK5v6bygsk7/WNSJEECQRYn5zPxHTkJhTngtmie/aHmktsvgTXtCG 0CHZk5bWEhyZM1juddYlCyXRSUl+W3kpwxMxeINDpEPdTBomYMoCsZaRHcVbpZLzqlx/ hPBe7pEI0Jyxpbbupd2UKZpimQMR1QiI78FluLoqqE7ymz6udDPi9HRq41Ybt+2MyzIN nl/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=9eB3sinujdfOKjw1Rq4Yv5m0jvLygDYT+UfsakVwvFY=; b=jq4hD6P7H8TvRTr/ZdniHRGL8OEqBepZeB/0sfplpoN4AUCzUAt4kdoCvtyGLu0FNt HJn0r9N5GxpBFM9G8tf0cetKfuYB4+soFo/Sj6fgq0DjV1wJbpyvYxIJvAydvs/J54BM HmFMovKjUquI4gXktjHlQlLnZwg1yp20elkOi3wcj53kGi3Z/0tjxyJMVPQeVKjaspsT jDWHcfD4eeysSz/1QY5sd9s3Sd16SjDB8xx6cAClKcjTGpCxd8OeU1Q9dToYoNTRJ3at 02iAGEqLzdwK2LnjTBl7kHqSYP0QzKCCkQ+2R/dGGqouqPU2wUL4EMNOsjmLZidyMlBb Qopw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=hWc0SIhS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q39si4042521pja.130.2022.01.26.16.38.32; Wed, 26 Jan 2022 16:38:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=hWc0SIhS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbiAZU7N (ORCPT + 99 others); Wed, 26 Jan 2022 15:59:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231401AbiAZU7M (ORCPT ); Wed, 26 Jan 2022 15:59:12 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FA4C06173B for ; Wed, 26 Jan 2022 12:59:12 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id k25so1254533ejp.5 for ; Wed, 26 Jan 2022 12:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9eB3sinujdfOKjw1Rq4Yv5m0jvLygDYT+UfsakVwvFY=; b=hWc0SIhSU692E7TeE3QERHKR5x+Uc2JnoSd39zct3wR6ZvZdOU20Q/bEetUWnZH2qv k8Y87WwX4DNOZDY7hoIHLsc9RzoCzuP16c0Mu+JCrku3P3474tOJQ88YTSgwbgLVQOT+ p17Rn52sDgl4b9IJo4cMCYZa4M7HXtY7gejYzswVMJo7wrdHQ9ep16fmYu3RxZQdUzfZ vbB9+epHe00IVsZhW5xqE5F+iIEAgrwaQry0tFSp3SRgrGpEemNiJ0xnUbptAQCNgexX lKuc1tIxApWOC8mTKsWuY1RGL78bfxNndcg3XKtb+4eUvrpLhDstJvA1Ol1ZPla5q89D 6b6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9eB3sinujdfOKjw1Rq4Yv5m0jvLygDYT+UfsakVwvFY=; b=HPsYgrlLMCVKn+ALru6l2C7PqAqZBw6w5xPC1Vq+AXowAksQ8skta0XaO1nSYTP7Mq QRB4aSQ++ZYqGNePQ4SNgNbJmxEmcspcd1a8DV/b4qnA5GqZm1Q6zG7JxqDMg4zjXIH9 dk1R/Uw/owf6Z6bThYzl1uJGCLWwp/X4r3qap/Kxvmmx3woRsAH+i3ysZTidAmm/LK33 FC9ftX/QGER2NOl3CwHiEWsGaHQIDLplO+gyN2sywQhsZQnXv76q2fxpeKbp/ebgbCwv Fpph5CfL0jpjKqbr6LrRybFMQshJNr5aC4PwqdicmpXCRgez25Sbc5y/a/4gstBR9Y8+ 4JLA== X-Gm-Message-State: AOAM531rKsq5LLzcxw5+eqHjbB0rjPweSBSUiiqVbnxExWhjVfimhWNj OjEErrmCqxpYBBcinPBCgOgLUM273/J9fUYMypnH X-Received: by 2002:a17:906:2ed0:: with SMTP id s16mr396367eji.327.1643230750765; Wed, 26 Jan 2022 12:59:10 -0800 (PST) MIME-Version: 1.0 References: <20220125141422.32655-1-cgzones@googlemail.com> <20220125141422.32655-7-cgzones@googlemail.com> In-Reply-To: <20220125141422.32655-7-cgzones@googlemail.com> From: Paul Moore Date: Wed, 26 Jan 2022 15:58:59 -0500 Message-ID: Subject: Re: [PATCH 8/9] selinux: simplify cred_init_security To: =?UTF-8?Q?Christian_G=C3=B6ttsche?= Cc: selinux@vger.kernel.org, Stephen Smalley , Eric Paris , Nathan Chancellor , Nick Desaulniers , Jeff Vander Stoep , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2022 at 9:15 AM Christian G=C3=B6ttsche wrote: > > The parameter of selinux_cred() is declared const, so an explicit cast > dropping the const qualifier is not necessary. Without the cast the > local variable cred serves no purpose. > > Reported by clang [-Wcast-qual] > > Signed-off-by: Christian G=C3=B6ttsche > --- > security/selinux/hooks.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. --=20 paul-moore.com