Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 13:28:54 -0800
From:   Saeed Mahameed <saeedm@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND] net/mlx5e: Use struct_group() for memcpy() region
Message-ID: <20220126212854.6gxffia7vj6cbtbh@sx1>
References: <20220124172242.2410996-1-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20220124172242.2410996-1-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j1NQITr0IzDNVzoQD3l7n9B7r/5JAEJfcBw13VtbKd1nJnRlVRLI5s+CWFtF?=
 =?us-ascii?Q?TYd9C2Pci2Qj18FBMtVdqDKYz8l8+VLyCySzqTaOEcXBih73tLkMOIaV60CI?=
 =?us-ascii?Q?8bpTePdQmZ9pN4V1iZjRhUbKh1W2xEn20XkxSdby+vPjdjUJqbawVjX+qEO7?=
 =?us-ascii?Q?Da/3zBFz7Gbk0HNQiLeCKL0f5u6Y8DDvJDElpRQcE97hIk3bhX9s4B2eodKM?=
 =?us-ascii?Q?ZcWk4K2b/o8BlJ/Pkv43Z2op7vdQW8kptX/BUtkp5Z2fAWtXyn/5EytVlkcW?=
 =?us-ascii?Q?V2LCSk27lBC4VThOEAXqMmqOje7bH0et7SY7/wH52u3cXJTvwfk5BnHOQ3f3?=
 =?us-ascii?Q?kf3Mc6WOSpYK6gG+lNufRtrUf2BI8U46bNFu3M2PYD0gVnfw0as/cxULgMfP?=
 =?us-ascii?Q?OKw2yT/3p8E+LexWD3TARM6oX31QCvDxMh7xgAvAXV4VU9S5LUsaEuTbPN79?=
 =?us-ascii?Q?tfzEnorLMkfkp1lf15ONubqwvcXXgWo+kgwE6AtBd9w5pfaBDnhL7H50aQ9D?=
 =?us-ascii?Q?eL7p10uCScGMbEXYkulL/zV0uYYsTm5UceGJFwrhVeBUG4l5o5+b/0+uQ7mb?=
 =?us-ascii?Q?SOsNF/Ec5WBHifIzjooT9GAxvrLwlvg3J5S9Z/Uy93TcUDR+sNMcU9UAuStC?=
 =?us-ascii?Q?KgTBIWK9zNllIOhVi9zrUU2NPqntkZ6vOQV8LIgS6YbI4S13edOm+hMi+i3J?=
 =?us-ascii?Q?hkv5QToJy0ttP/gUk9FNtFT0WxwtJvqcErStmyzrFh9FqRsCplOyxHxFrQ8t?=
 =?us-ascii?Q?y7+eZvsomPWT8b6jIZ9pa1RMXpIHQlE1n+S4wdWVmaFPCqZu9o/qF3in858e?=
 =?us-ascii?Q?4NGJfoNNTfilNgZflR02pcxUaqHwlAy4gg4tuuvNd9Wh/Pz/HQ74+F+AOZ+O?=
 =?us-ascii?Q?dY4rHARyMQTmNr/sjgFu5NSw8D6tlQqy198ALR5yL9i51zFhcNT7eRb8k0Yy?=
 =?us-ascii?Q?JR+TGoZlyN3lEMh0ho/hXvWtN/y239HdqJrJZi1ENYHb57/4SH1r2Eip0ezN?=
 =?us-ascii?Q?cfkjBxufcX0OZn3JTNE0onKaWxFFfWqXjHw0p1z/WKvV5ihItGtC4MoXkJr/?=
 =?us-ascii?Q?NL03fTtO7nNM+k36Ux18rRMzqU+e4eT6NiJ1q6V1rub0T2e2yHdbmW5inQw9?=
 =?us-ascii?Q?dTI0bM1PJoZtxx/e+3qc1u2Oy6tSzCl9fyNmEd5z6yMr1MaRuHQItk2N1cRp?=
 =?us-ascii?Q?5JUuieqNzUsD0XmzE5dvRibmFpcyjkXzqol/ORg0JbYVl/f2IREpPvL8j83j?=
 =?us-ascii?Q?OthADUXcPEz5tnb8XeUvvatJOc1ebqnVqlXSJa9d2llHi5wx+JgMLFfEPomL?=
 =?us-ascii?Q?cjORI/x0L4TgojgOXWOB4yL/FXMI6yKe0zrwK2HfFcCFOSbrnwCmk05/5EK1?=
 =?us-ascii?Q?o8Tmc/i0KpH9QXp536AA8QdwaG0O/3HjQZRi0l/17svSniFnwMplzC5hGxVu?=
 =?us-ascii?Q?wHy2/6sk2/xzydTgL5fn6TNKqrSiqhYoIxxR24Hqrf6pUY+NnG8/yzqrpUPm?=
 =?us-ascii?Q?hSQGJWhzCRz2yQcg6Qu6qnzpALPHbdM5JSkCcACGQVH4jUzTl6K1L0wqsZZl?=
 =?us-ascii?Q?IreCLJNWq+wLu+TIG8ptqo9G7wt/yE9bEtQcZLKjdSQ5Oxtup+IYCY/pZD5M?=
 =?us-ascii?Q?2vTb8nSUOi65wNfB3d5AmE8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b258e0b-9b82-443d-677c-08d9e112db1a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4209.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 21:28:55.2657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KjiQvI+PixBiPe3fBCeaBdNeK9RNEPLws3EMNmVtOt4hqpXE15GJ1q3KZ+Xg65VIvZ63HI+jIRQBIqXSGdRZjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3465
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24 Jan 09:22, Kees Cook wrote:
>In preparation for FORTIFY_SOURCE performing compile-time and run-time
>field bounds checking for memcpy(), memmove(), and memset(), avoid
>intentionally writing across neighboring fields.
>
>Use struct_group() in struct vlan_ethhdr around members h_dest and
>h_source, so they can be referenced together. This will allow memcpy()
>and sizeof() to more easily reason about sizes, improve readability,
>and avoid future warnings about writing beyond the end of h_dest.
>
>"pahole" shows no size nor member offset changes to struct vlan_ethhdr.
>"objdump -d" shows no object code changes.
>
>Cc: Saeed Mahameed <saeedm@nvidia.com>
>Cc: Leon Romanovsky <leon@kernel.org>
>Cc: "David S. Miller" <davem@davemloft.net>
>Cc: Jakub Kicinski <kuba@kernel.org>
>Cc: netdev@vger.kernel.org
>Cc: linux-rdma@vger.kernel.org
>Signed-off-by: Kees Cook <keescook@chromium.org>
>---
>Since this results in no binary differences, I will carry this in my tree
>unless someone else wants to pick it up. It's one of the last remaining
>clean-ups needed for the next step in memcpy() hardening.
>---

applied to net-next-mlx5
Thanks,
Saeed.