Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5663487pxb; Wed, 26 Jan 2022 18:02:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTKDuG05L5K1k/MVO4LK7kmj3o1aUtd/xMmwKStL42d4Pj3XJgCtMkuEEf5Fj0ibLW9o7L X-Received: by 2002:a17:907:1b1a:: with SMTP id mp26mr1264831ejc.450.1643248933136; Wed, 26 Jan 2022 18:02:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643248933; cv=none; d=google.com; s=arc-20160816; b=YYV7h9+vmb6vhnlHPVAUTCr+7fXwDazuKtY/gWlvkjhMU0BTdpI69My4PiBTanRcU2 LRMYmlS6s9pzzoKhisr9Qh53sTyVrlyegExy/DEx+T9OR9X2DmINZKBOqx46vsfHyFb4 xf77FLi4MVbGqXiyFhCQsGyQ5jOsMtoDn8QinvtadZ9m2IZOuOG/1Cgph9SCk4cuJogw dPTiS7oLPOfZM7UhnBHj9uuoH71ObSjyrhVaj9zior/MC2Nx+89ZPQYicfZrFoMJgOQP WvXNqleL6QMgobufljwEXu9GWJdaThkMwTzPmlIeyylGgT0UuPyDIPHmb63lWVJXmKc0 l0kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=AjuEqo/szNdkE8sJZ2LmIS7aoI8q/3oLCqQgzbdOm7w=; b=GJCEh9pwm4IqEMxHOYp60qNE5Vy1uN4FgGRI22FXQVPPylYdNrhZh0Hzkn4U0dREfN pXZL8+w74VnfukPfzIqsT/A/0Sbbup2kZ0mZdvMBr1yJlvEWrVBrzx6AWQP9ybXsPJNe G6QF457k11ClWk/2rX8hv9OetYYjMzXRgbIYhhkMmxD5LG7fd/hyfluf7JEyQLOEGe41 KBmBmIDAN6Eh/iG+L/j/0jOaB8DL0mf9+lNKcEQIxxAf85ZsphB241mbeoAmdtbhRzaI evLlGEh/NSlKM+mSC45O3RVcYMM/jISSbAHCA2GZHug8SPZy2HV7zildBxGTTKiIeF1z cvdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fUylDgRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si732433edd.183.2022.01.26.18.01.49; Wed, 26 Jan 2022 18:02:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fUylDgRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232711AbiAZVkP (ORCPT + 99 others); Wed, 26 Jan 2022 16:40:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232697AbiAZVkO (ORCPT ); Wed, 26 Jan 2022 16:40:14 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADA8C06173B for ; Wed, 26 Jan 2022 13:40:14 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id q63so874493pja.1 for ; Wed, 26 Jan 2022 13:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AjuEqo/szNdkE8sJZ2LmIS7aoI8q/3oLCqQgzbdOm7w=; b=fUylDgRiw2zN+9lqWMjcGPilZXXqjxp5P3NMNG1XyAusP3/ipIkjL+BLrlzOOvcIYM WLXU/UV/c1bOo6tCz6BAClGoSjGm5gqo8CvWFSxm8V0OEQEhQ811Ot6NvTUIouytBpnG /Ovfg1Kpp0Fs0khSxWGc7iRKIhh8jxBNEFATLHARHGrc8+fdAWyeAVJwSQcYcTIlJBt9 /TfqrXFWvnSH3J83P9U0iptSjZRY2pDBJB9rQgPA32IEu5bWAQVmiN7AgnGj4JKTywEM tcDSSXnkV1fUeyhCOxhTckEXzIkbTZrQyY18ng4FIF2PurEo/s6i7TAIhl+GpPVUy3r7 0ugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AjuEqo/szNdkE8sJZ2LmIS7aoI8q/3oLCqQgzbdOm7w=; b=3dVbzl3KwW1hhJxc/SA4wcbmRuruIC6u/nJ+VgGlhOZ6GTUaDprDxGa13wcQVT7eJS S7hLM6ofExZubkUDEtTJWnYaU3xcaeLHMtVUWCKHRoxSn7SwQParpnlBI4yXH6Vdl/ET guYiUeb8rD1q7YMGVQ4rT18K64WWAK9QHX7XqfRoR2ukYSMlmTe4zPzy/yXqOBA3GjYD tAXa5u2jGuOpZ3baNAovYX/MSZSj6Tcr3zE2+R+g2Mg4lgJV2lbwzeAkrFnVgWkeUg1C ijvkHgpUbH9yNIIaAmKy5hs7fs9An7QIDBRDoQTTUUtqYHeF0P7y2/bdBL+WLcUzR2ZA 6T+g== X-Gm-Message-State: AOAM530Xx4WZwOFts9NtVhUnXQgXamz/DdZInLnvotOCCwD/Uul00R+P TFUHVnjYonbwIPGYSvdH7xtRAyy8LwPEAInztLAwYA== X-Received: by 2002:a17:90b:17c4:: with SMTP id me4mr10841971pjb.198.1643233213353; Wed, 26 Jan 2022 13:40:13 -0800 (PST) MIME-Version: 1.0 References: <20220118190922.1557074-1-dlatypov@google.com> In-Reply-To: <20220118190922.1557074-1-dlatypov@google.com> From: Brendan Higgins Date: Wed, 26 Jan 2022 16:40:02 -0500 Message-ID: Subject: Re: [PATCH 1/5] kunit: tool: drop mostly unused KunitResult.result field To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 18, 2022 at 2:09 PM Daniel Latypov wrote: > > This field is only used to pass along the parsed Test object from > parse_tests(). > Everywhere else the `result` field is ignored. > > Instead make parse_tests() explicitly return a KunitResult and Test so > we can retire the `result` field. > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins