Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5686382pxb; Wed, 26 Jan 2022 18:48:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyo7UljKffV9vrM7Xvco8RQ2akNWPBaJmokXBvtMDm9v65cOBCW6JqYx7PbDMC4oj5tuXhc X-Received: by 2002:a17:907:60cf:: with SMTP id hv15mr1320968ejc.702.1643251719739; Wed, 26 Jan 2022 18:48:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643251719; cv=none; d=google.com; s=arc-20160816; b=nc2DQeM6rlJlulgc589SGDRNYmrJ9sbZXAyvZ3Hi0PdZ5GBstUW2sSP0TPvsSvY5e5 a3G5iAiu6G6plBhBFCvYYqniqTI7kDKEK5XnmQM8AXZwZhELev+Gm1zVmSlOODzIJi6R XfTnlgX06mhGMTqLzTs3s7hoFo5fKunXb8x3efY6f0x2kfWUR9x4kGAmrcHb1MaxU79i SNXogAQgG9/j9PXB078Z6XinDWTagzL2KPiqKKtFlidZVkPKjC6JKJDFyynZIHblO+sj YmeFL4h5q9OUkndv7MMrEfznz+6ZKUUdv/PEgCrbHDxBMI6WEzPlekFHmLFS9tr92Npz cR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Jw3oCtQL6BM14oFzDHSC6GNL6FZ460OOEwEn4a6nFF0=; b=OGLt9W8LqSAOWybrRqdJU/TPN9Z7LhzIeukhjgBpGX6uG1AJmaGNSCtpWIGhDWIwfs pIMaFzc6wnu06lHNDK/eiAawVLeOL57op+CtREtSuWmPZCpzufmSFq3ydl4IIhrC0MaF ygrYgUplXOYNReMVaW2nfjwMBheWDupdwq64odQOTraNoaAhGilLgI6ulgx53dyBbeCp /bhSr5BxJZadg6tCgp4obUMXgka97tEgI2ic0RwjJ6wqD3nmg4/ctktUnu9jQRI666dg FZ2P6gxyWnI+v0pkl9rOOzBS7dfB40tudgfHuIahMZB8TrC+BFpbDWsq3iYgzOAYXWLw 6Gpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dz18si820316edb.61.2022.01.26.18.48.15; Wed, 26 Jan 2022 18:48:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233087AbiAZWR4 (ORCPT + 99 others); Wed, 26 Jan 2022 17:17:56 -0500 Received: from foss.arm.com ([217.140.110.172]:43020 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiAZWR4 (ORCPT ); Wed, 26 Jan 2022 17:17:56 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 719E4D6E; Wed, 26 Jan 2022 14:17:55 -0800 (PST) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.196.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFEB43F793; Wed, 26 Jan 2022 14:17:54 -0800 (PST) Date: Wed, 26 Jan 2022 22:17:52 +0000 From: Qais Yousef To: kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [peterz-queue:sched/core 5/8] kernel/sched/sched.h:3006:32: warning: passing argument 1 of 'cpu_util_cfs' makes integer from pointer without a cast Message-ID: <20220126221752.5yaftiwk32jrifll@e107158-lin.cambridge.arm.com> References: <202201270319.tmnG6ICK-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202201270319.tmnG6ICK-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/22 03:53, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core > head: dbaafd0f1651b35e07c20e33f8c3f133fc65705e > commit: 6dd3d475cf576edd705885c66b6f1d638a6818f4 [5/8] sched/sugov: Ignore 'busy' filter when rq is capped by uclamp_max > config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220127/202201270319.tmnG6ICK-lkp@intel.com/config) > compiler: ia64-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=6dd3d475cf576edd705885c66b6f1d638a6818f4 > git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git > git fetch --no-tags peterz-queue sched/core > git checkout 6dd3d475cf576edd705885c66b6f1d638a6818f4 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash kernel/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > In file included from kernel/sched/core.c:13: > kernel/sched/sched.h: In function 'uclamp_rq_is_capped': > >> kernel/sched/sched.h:3006:32: warning: passing argument 1 of 'cpu_util_cfs' makes integer from pointer without a cast [-Wint-conversion] > 3006 | rq_util = cpu_util_cfs(rq) + cpu_util_rt(rq); > | ^~ > | | > | struct rq * > kernel/sched/sched.h:2919:46: note: expected 'int' but argument is of type 'struct rq *' > 2919 | static inline unsigned long cpu_util_cfs(int cpu) Seems cpu_utils_cfs() definition has changed since I posted my patch. Below ought to fix it. Thanks! -- Qais Yousef --->8--- diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index c7bf5309c162..9b33ba9c3c42 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3003,7 +3003,7 @@ static inline bool uclamp_rq_is_capped(struct rq *rq) if (!static_branch_likely(&sched_uclamp_used)) return false; - rq_util = cpu_util_cfs(rq) + cpu_util_rt(rq); + rq_util = cpu_util_cfs(cpu_of(rq)) + cpu_util_rt(rq); max_util = READ_ONCE(rq->uclamp[UCLAMP_MAX].value); return max_util != SCHED_CAPACITY_SCALE && rq_util >= max_util;