Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a4eccced-44d9-d5ae-27b3-5b2832d22561@linaro.org>
Date:   Wed, 26 Jan 2022 15:50:57 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>, peterz@infradead.org
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Zhang Qiao <zhangqiao22@huawei.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        stable@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzbot+af7a719bc92395ee41b3@syzkaller.appspotmail.com
References: <20220125193403.778497-1-tadeusz.struk@linaro.org>
 <bb01425b-0f6a-e69f-c24b-567821c1472f@arm.com>
From:   Tadeusz Struk <tadeusz.struk@linaro.org>
Subject: Re: [PATCH v3] sched/fair: Fix fault in reweight_entity
In-Reply-To: <bb01425b-0f6a-e69f-c24b-567821c1472f@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/26/22 05:53, Dietmar Eggemann wrote:
> Can we then not get rid of `bool update_load` parameter of
> set_load_weight() completely?
> 
> @@ -1214,8 +1214,9 @@ int tg_nop(struct task_group *tg, void *data)
>   }
>   #endif
>   
> -static void set_load_weight(struct task_struct *p, bool update_load)
> +static void set_load_weight(struct task_struct *p)
>   {
> +       int task_new = READ_ONCE(p->__state) & TASK_NEW;
>          int prio = p->static_prio - MAX_RT_PRIO;
>          struct load_weight *load = &p->se.load;
>   
> @@ -1232,7 +1233,7 @@ static void set_load_weight(struct task_struct *p, bool update_load)
>           * SCHED_OTHER tasks have to update their load when changing their
>           * weight
>           */
> -       if (update_load && p->sched_class == &fair_sched_class) {
> +       if (!task_new && p->sched_class == &fair_sched_class) {
>                  reweight_task(p, prio);
>          } else {
>                  load->weight = scale_load(sched_prio_to_weight[prio]);

That will also work. Let's agree on the best way to fix it.
Peter, what's your preference?

-- 
Thanks,
Tadeusz