Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: DqjeYvouhWDSEfeqN0tfSjV5ehC8L3+CdsfO4HckDw6jr8Chxfd4nwriicIXZu7peD/OzNeJnL
 TUXK8iq+E6NsG9HyWuhpcpZcrWS6wRmKFdSbR/ayM2kIN9DvOqJraZb8lLH9DZQQ2a1JyS/8jK
 pziPUAYbZupqD4t8EmAqdZADFW086kXcpIIw7ZGuD7a7YeVfzJrqz/nuzLMN68+PTAtJV31X10
 mnRUq18LZsbI5r3fGnVF15UfDXHv26hHkLVnnUrx4+CCTSVIBgJ47cWm2SJl6VwGNODaN4Zn0T
 vmJGTVwACARMPo1aTNkifr7e
IronPort-SDR: R1lkn6q9xnZ6vyZA9K7xDtoeXXUivnCbNWNDfyuIOSMRS558Df4HdcXQMAXDQxl1dGwqCPbibe
 HukMkvog1OOGwdC0VBvGC4ADTPnbgdyfQse9mKRA3PQCjxyA9SdXwtnrzT57ydTtdt2r5+sTcy
 y+8zsG1TGuJo5mbbcPMVhDLKu4weNCSxrUsuWpbg1VZKd3DnJ+DcHkxUvtykN6qVcwfn+tIFIk
 z41mZakgoB3qsHSFyw+6WS19Xp5RTI0q6QBYcWkWc55oJElf5KqQbVr4ao2K3qI5jGFoAKycUZ
 nh8=
WDCIronportException: Internal
Message-ID: <851b0f18-a95d-cfd1-54df-a6902f251a4e@opensource.wdc.com>
Date:   Thu, 27 Jan 2022 10:54:08 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ata: pata_platform: Fix a NULL pointer dereference in
 __pata_platform_probe()
Content-Language: en-US
To:     Zhou Qingyang <zhou1615@umn.edu>
Cc:     kjlu@umn.edu, Alexander Shiyan <shc_work@mail.ru>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220124164525.53068-1-zhou1615@umn.edu>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220124164525.53068-1-zhou1615@umn.edu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/25/22 01:45, Zhou Qingyang wrote:
> In __pata_platform_probe(), devm_kzalloc() is assigned to ap->ops and
> there is a dereference of it right after that, which could introduce a
> NULL pointer dereference bug.
> 
> Fix this by adding a NULL check of ap->ops.
> 
> This bug was found by a static analyzer.
> 
> Builds with 'make allyesconfig' show no new warnings,
> and our static analyzer no longer warns about this code.
> 
> Fixes: f3d5e4f18dba ("ata: pata_of_platform: Allow to use 16-bit wide data transfer")
> Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
> ---
> The analysis employs differential checking to identify inconsistent 
> security operations (e.g., checks or kfrees) between two code paths 
> and confirms that the inconsistent operations are not recovered in the
> current function or the callers, so they constitute bugs. 
> 
> Note that, as a bug found by static analysis, it can be a false
> positive or hard to trigger. Multiple researchers have cross-reviewed
> the bug.

See below. Reviewing the fix would be good too :)

> 
>  drivers/ata/pata_platform.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
> index 028329428b75..021ef9cbcbc1 100644
> --- a/drivers/ata/pata_platform.c
> +++ b/drivers/ata/pata_platform.c
> @@ -128,6 +128,8 @@ int __pata_platform_probe(struct device *dev, struct resource *io_res,
>  	ap = host->ports[0];
>  
>  	ap->ops = devm_kzalloc(dev, sizeof(*ap->ops), GFP_KERNEL);
> +	if (ap->ops)

This of course should be "if (!ap->ops)", obviously...
I fixed that when applying.

> +		return -ENOMEM;
>  	ap->ops->inherits = &ata_sff_port_ops;
>  	ap->ops->cable_detect = ata_cable_unknown;
>  	ap->ops->set_mode = pata_platform_set_mode;


-- 
Damien Le Moal
Western Digital Research