Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Felipe Balbi <balbi@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Chen Lin <chen.lin5@zte.com.cn>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cai Huoqing <caihuoqing@baidu.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask check
Thread-Topic: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask check
Thread-Index: AQHYEpzAx/O8KtwQ2kKOB4xKcKk7Uax1IAeAgAD+GuA=
Date:   Thu, 27 Jan 2022 02:11:09 +0000
Message-ID: <HK0PR06MB3202A4690440C2123A2D76D880219@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220126100856.3680716-1-neal_liu@aspeedtech.com>
 <YfEnnWuL1cC6airb@kroah.com>
In-Reply-To: <YfEnnWuL1cC6airb@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U2s4jgMpAZRQv9WFhShMntk261KnGdplsSHgXBHWRG2kBMWjakYzj+BaHsgV?=
 =?us-ascii?Q?BZF5WKmOS2nJeRHqEJaM9OyoDrPOPgNmR7o1QyTsPbnMjfPlCe0au6ggbvi1?=
 =?us-ascii?Q?5koNbfrk5UTK8VW+jiN4UAK/Kxss81ymwUgVbb7CHJ1JpqipIHbyXALNkjU2?=
 =?us-ascii?Q?DoZoZCY8m9FnCcpIgRb8nz3MuvvRyyrEFxOQTlh3tXH7iL6a1ehK6R4ngUAq?=
 =?us-ascii?Q?JOOaYdB8DhoxQpdyh/9p6ReqT53FwRdXjWpmOVS2dvvlXxeuMflSjZ+Kh+6X?=
 =?us-ascii?Q?SS5wzKCdqOqpG1SSAvRuDBlZihTj6vr/OAMD6cc39dLiWi6uwmIZh5c8TTAT?=
 =?us-ascii?Q?TVfzTtKHRigC/BWNcTeXC/gLb1RJ8S+VsDN44Auu35ETY/Uf75GeMMmr44RT?=
 =?us-ascii?Q?vu6gPFuWc728XKj7L02J4VlqGEW91gsNjXP27VhlE4VNtDhLAWfPZ3LUy3Zx?=
 =?us-ascii?Q?WBhkj2G0buTLiln/tFkLsudbfrvpqi83HHjfbp5ProyKR/eJ6InBEPlf9siC?=
 =?us-ascii?Q?nsuu5bAv/ZoRjYsa66bLNa9ZhpeECFRKxA4KueoPUWxay75qHPl1JuAWAgTp?=
 =?us-ascii?Q?P7vq8Q3hfMJI8ytDplvFch7Lep2N16OnDqaTA1w4eMVQQMXFtQmM07rpSnE9?=
 =?us-ascii?Q?+EqfaIHSFU3to0A7kpaitAeyrKvxdo5zWMN5NBpxaxeC4cOvMJSdpDI8OHGU?=
 =?us-ascii?Q?g56Epl5XvMUySz04Kkd5yPK97F6e1TD/brQ/+cKrmXJG7G3iAjbRYGUxxKH1?=
 =?us-ascii?Q?+RJCYPKpLSMg2n0eR7wMnK2IYYDoP2MYGWvx/IKaLZRW3l0kip4GFc2peRNA?=
 =?us-ascii?Q?UWgRPnyhHIpcxXZWaTFmZ6kEg+E4jMofjM4qNgwKf+BAeVPU7NmvZwQ4lSQ2?=
 =?us-ascii?Q?81Mntj8TDMNH8ieGVhYHkkaaOSwoJtcrUzrqSjhWQyaVWd/3XZYHeNNFLYEo?=
 =?us-ascii?Q?rmE6mXvFeB+B0XZlfxrqUicNT4Dx189/oc7QSpP4UGYYbsQyEfePOqS7lG8H?=
 =?us-ascii?Q?6Xk5LxBYWRR5JqdyaHrFjgOiR2Dw3LVwjXbSx/it0ATfcbtvMxvZ7erP4KFd?=
 =?us-ascii?Q?IRickXvd1ZIXkSBy6vQfbgSLyliOCrylEzmfjUKDK/MkSyUXIOe2bhFfOZsi?=
 =?us-ascii?Q?YXMi/bhbv0Vz5FPU+XrOwkB1+jd7y16OgYwEjnAqRVxmAE/5FdVS41YCu59l?=
 =?us-ascii?Q?6sOpE2OExoyp6faY+aj2e6pLVkJ+oYLC+iSFvwfYgdUOpLyKhKxTLixkFd+z?=
 =?us-ascii?Q?uFsA7D4P3+BLQYYl2ksohnIKDhbhievpQdYcyK2+cphTxvXQTQLKM9JxVTVP?=
 =?us-ascii?Q?VdQCkPUjbIFEhbyvDRPsTjxTPsy3aQMoLga4PihbhOO6PyLXZqItwuMENoFB?=
 =?us-ascii?Q?HfUtAfEECuz9wdeTpbo9aCxgkoIzkZc2zEbBQCvnjVG6Gi6GcbYZyC8acKLD?=
 =?us-ascii?Q?8cEgjeEXhAyiZtHWakJHIyDUAkK4rZQW/wy/0xKVahRlfY+Okd0hy+01DUkC?=
 =?us-ascii?Q?oxvFArEjp4IsfpwM3czXX6m4ghEs3RIKkSZSyE+c1rACJ43ojBa6gmoC1+09?=
 =?us-ascii?Q?LPau3K8tSDGvW7bKmTfUmlaB5kWJqKgQ4KUM7DDb6Q8Cx9ppktRYGx6WHixM?=
 =?us-ascii?Q?1hrN1NfDrFSXyqIhV46C/RE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26504d23-d97b-4879-442c-08d9e13a4909
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 02:11:09.7145
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Dk3QRT9zUpau+HdA0H5CVwQvmqi7kUenSQbBT87Mz/FJj6n83pBYOJn4NZNPixNOzWaVf/FiU0wLYrqNaKY5CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4028
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Wednesday, January 26, 2022 6:51 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Felipe Balbi <balbi@kernel.org>; Alan Stern <stern@rowland.harvard.ed=
u>;
> Chen Lin <chen.lin5@zte.com.cn>; Wesley Cheng
> <quic_wcheng@quicinc.com>; Nikita Yushchenko
> <nikita.yoush@cogentembedded.com>; Cai Huoqing <caihuoqing@baidu.com>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-aspeed@lists.ozlabs.org; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask
> check
>=20
> On Wed, Jan 26, 2022 at 06:08:56PM +0800, Neal Liu wrote:
> > READ_TOC cmnd[2] specifies Format Field which is defined in SCSI-3
> > spec. Add command mask to avoid marking this sense data as invalid.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > b/drivers/usb/gadget/function/f_mass_storage.c
> > index 46dd11dcb3a8..14d51695b8ae 100644
> > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > @@ -1944,7 +1944,7 @@ static int do_scsi_command(struct fsg_common
> *common)
> >  		common->data_size_from_cmnd =3D
> >  			get_unaligned_be16(&common->cmnd[7]);
> >  		reply =3D check_command(common, 10, DATA_DIR_TO_HOST,
> > -				      (7<<6) | (1<<1), 1,
> > +				      (7<<6) | (1<<1) | (1<<2), 1,
>=20
> Can we have real names here instead of magic numbers?
>=20
> And what commit does this fix?  Is it a regression or has it always never
> worked properly?
>=20
> thanks,
>=20
> greg k-h

This patch fix Windows Server OS installation failure problem.
Since @Roger already sent similar patch fixed, I'll try it.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=3D=
usb-testing&id=3D89ada0fe669a7abf8777b793b874202a0767a24f
Thanks

-Neal