Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Chen Lin <chen.lin5@zte.com.cn>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cai Huoqing <caihuoqing@baidu.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask check
Thread-Topic: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask check
Thread-Index: AQHYEpzAx/O8KtwQ2kKOB4xKcKk7Uax1doYAgACqmJA=
Date:   Thu, 27 Jan 2022 02:11:40 +0000
Message-ID: <HK0PR06MB3202A514A1CE186A29DFFD8380219@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220126100856.3680716-1-neal_liu@aspeedtech.com>
 <YfFwLDLX5D4dYLTb@rowland.harvard.edu>
In-Reply-To: <YfFwLDLX5D4dYLTb@rowland.harvard.edu>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NufrSatL1cU+j73n2oLUWz6uq6PNWo+Edu6x0RltZFGfkGVQP5ei0lwfPFTh?=
 =?us-ascii?Q?w8EFfo8ZK9bVlNbZKJNXnXkLd/LckuxQxABvroVQH2oFsDbbzlv3u+TH4bNw?=
 =?us-ascii?Q?SCZ5SJZRU4px0G3ZCzVHGdNvvcto39R7T1sOJiUZ4M3tbhNFML07XESaV4Q3?=
 =?us-ascii?Q?RnfE53/v8hkw3uTepnHtZAwsxtt/0/Pa+IV9DCvC23Uc5+2eGG2s5tqO8aoi?=
 =?us-ascii?Q?LvXjDG+YaUJd1kNQuux7EO9QIwLbzddXVv6L4DtKaqHY43MS51KgDdl1RWs0?=
 =?us-ascii?Q?mhOJfj8wEvOvajlJ4bwBmqCnH9Hfp/ZgoP/RgcweKwGyRwU8RCnTE7u5ngfv?=
 =?us-ascii?Q?pNIHVkqGMIcjUkxYOpVbAz+zzkFRH71A17lRRkyi6ZO6aA3fcK8/WxtEEsfY?=
 =?us-ascii?Q?+k2EQDtOb5K5PrZz2DedlcxIK95NtMwko7b9mVMEsh4o+O+fwwBNFzwLe6uJ?=
 =?us-ascii?Q?H9BD1UEsk4SuVMjlKxyuvDPXmyHImDP4ekD411KvLxNdzcqsMO3YTsFFJDdH?=
 =?us-ascii?Q?II4JBp/C9U8qaOzU9qcgS9306Ui+PLgQxH4jkKov73Q28oEcJsU2aRVibpsA?=
 =?us-ascii?Q?ehtT2bieveyCwq+ylRJ18BKfbdqBBdHRIWvCZGz5IU9+x4bxTIcfDc/mNWnL?=
 =?us-ascii?Q?Yjkpte9cG8s/dZVh1f+eoso9a9K1CzuaBeANvsdC3DVxC3xYIy3rt7R1dYF7?=
 =?us-ascii?Q?IqyvR+PRKpoQrr+pkrecbDg7s5pyF07H+c436vUwtPbfCTEH+IWvPIGLQ5Nf?=
 =?us-ascii?Q?0s7vjJs9Ntv7gI1NOvJFXisNYM7NjIBYlGCFR3Uz/o62uKGg21igfEAvO1Zn?=
 =?us-ascii?Q?cVYEUULOH67baKV69j4cIoPa7RWtaO5G3e/QZjVbSZvq/O+ON1XdQQxmon5J?=
 =?us-ascii?Q?lO1J79kkerefrokeurz7nBLoq4gpI+KhCaQqntuIoPua4Kd6ZxgVMkpS/8Qz?=
 =?us-ascii?Q?qk9i5s1zFMPkG0ypbZ76W9bjQFRHPviajVP3mYmuAFQjJ1OPhI+FK+6Gx1i4?=
 =?us-ascii?Q?RSdt+locTHUUiS+9Dd6nPHjuYdA0HxyFY8FXjOUdQJvAJZkQv9owF3C8ux2y?=
 =?us-ascii?Q?yC11Fqos2xfmuYTxojlN3HpbpT9+XWLhZImM9ayDwVa1ait/OcsKOfXlwoed?=
 =?us-ascii?Q?/DS3x9ig9G89ZVNqbIsN2uaaDee5zC52T9DdPw8Dw5nlfrelYD59uRLgfBoq?=
 =?us-ascii?Q?xE1pzbKCHdNH0Qjaha8BOR4ds/NkIwamfN3QDSRh2daurY3OVUYALZR5puan?=
 =?us-ascii?Q?Ujqqv2mxqCdJqI1DYMxV+2P7W6FgJf/TsR0edB4V3YB6SZ4HyesJfIajWQO1?=
 =?us-ascii?Q?6U6oEMgr8ugBAVwdabyP8zUipxrxPvB34kN9YHfNeV66lG+cHFipWdgy5j0C?=
 =?us-ascii?Q?FCYfGEyVphX/VY5BPMVO0jeIPWjcM2VyKN2MJs5mzw4dwlmSNBghYuyhXac6?=
 =?us-ascii?Q?PwxyXTAoEdr8TlgN+SSynvSSuPjADSW6exvqCnzQ6wnBcvivTpp9FbzjCy6v?=
 =?us-ascii?Q?jbbIdi96UuIqwr6o7uhRAEoF2g0l4IL4Uh7rDlGFD2hO+pVY7mH0DSvqI0zw?=
 =?us-ascii?Q?4IMAYGOvCU6e5qogJYAHkIrq4K/lFP8xX90RUQitNsokkoQeLpaB7fC2lvjl?=
 =?us-ascii?Q?fHdHldf7qurb83eVA4o3zvI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f25c6d0c-edfd-405d-45de-08d9e13a5b0e
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 02:11:40.0400
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9tJAC1W5BBEOOwGeBbJStzRhOxu3WmBk8c/il0VIC42ZfpG3lahMnVDGMSjLUgs7qS/3tWQRcQtgosfzOafpSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2648
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Alan Stern <stern@rowland.harvard.edu>
> Sent: Thursday, January 27, 2022 12:01 AM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Felipe Balbi <balbi@kernel.org>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Chen Lin <chen.lin5@zte.com.cn>; Wesley
> Cheng <quic_wcheng@quicinc.com>; Nikita Yushchenko
> <nikita.yoush@cogentembedded.com>; Cai Huoqing <caihuoqing@baidu.com>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-aspeed@lists.ozlabs.org; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH] usb: gadget: mass_storage: add READ_TOC cmd mask
> check
>=20
> On Wed, Jan 26, 2022 at 06:08:56PM +0800, Neal Liu wrote:
> > READ_TOC cmnd[2] specifies Format Field which is defined in SCSI-3
> > spec. Add command mask to avoid marking this sense data as invalid.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > b/drivers/usb/gadget/function/f_mass_storage.c
> > index 46dd11dcb3a8..14d51695b8ae 100644
> > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > @@ -1944,7 +1944,7 @@ static int do_scsi_command(struct fsg_common
> *common)
> >  		common->data_size_from_cmnd =3D
> >  			get_unaligned_be16(&common->cmnd[7]);
> >  		reply =3D check_command(common, 10, DATA_DIR_TO_HOST,
> > -				      (7<<6) | (1<<1), 1,
> > +				      (7<<6) | (1<<1) | (1<<2), 1,
> >  				      "READ TOC");
> >  		if (reply =3D=3D 0)
> >  			reply =3D do_read_toc(common, bh);
>=20
> You've been anticipated:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=
=3Dusb
> -testing&id=3D89ada0fe669a7abf8777b793b874202a0767a24f
>=20
> Alan Stern

Thanks for you info.

-Neal