Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5920450pxb; Thu, 27 Jan 2022 02:27:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBuOzDjtY2Y0swUMj2W4JYlxCaqCRC/neW77URCeenCDNnxqAuKMdP+8si9vx27vbRScaY X-Received: by 2002:a05:6402:35d0:: with SMTP id z16mr2984009edc.149.1643279278868; Thu, 27 Jan 2022 02:27:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643279278; cv=none; d=google.com; s=arc-20160816; b=xUILbaA96JuET2Q0gJ8Jl39BWKXKiBfIcPkO0LOPivZQv7SHat8FhhPV4yNg23KAdV ofqlbngwUbgaaG9JHBZruRwF806mXp4VnXslt+bf4XZ4cUODaZtd6ItJIrf/Jojb/Yib zFn6U9YlYBPU6iiQgu8q3jCJRY2csPYTWzUcFA9z+eGfP3DJgQRmPY1tGn5W43AKacdG Jyokl7CUFWzneTyZFliAQe02RlzXVCEUR+iGlFicMcQByyrpEin3dpDdMIrf6d6+P5zY qXJ3o4M8t0TxVXbhBJrubGp1uLKgzEZB266MgyS5mJ9snk9Ji8P1Fkjn6NQC+hvJlQ8X XI+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lKKSXhJS3kPZU8O1eC5c9YKxKPMW4YO4e+4G3CImMlo=; b=PW8m3+1+2PYI5x7fq2WS7pxDlzDPTtk5wd47pUpV+OJHlQ+aqP3MxSKDRXj/SDBu4P WzIiBNRipQDjXEVgTPfhdBgUuDa3LdMVkM7rYUsts/XVSGO9Qnba+Bgc1Bj9VpIoXM6b 1GpEgOC9nOp7XOzJV6wL74b+o5Q7dQmTDU5q3wWheNBKQjoRfHtyTxLne82EAbAxofq7 DN4ZprlLSVB4RFB/r+qVVCgznV4ior3jY/yee9d1QQvOOexpYTvFYBbCAZMci/rFlC2I PueJhHKbqA1BLwx/V9bBa/bpx3uDEwalJlCF75ZJB6YDZ695bYNI/Rk87JYr1I/Noqx7 exIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bsX1Q0Hb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si1060063edb.267.2022.01.27.02.27.32; Thu, 27 Jan 2022 02:27:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bsX1Q0Hb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbiA0Cz4 (ORCPT + 99 others); Wed, 26 Jan 2022 21:55:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235355AbiA0Czy (ORCPT ); Wed, 26 Jan 2022 21:55:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40129C06161C; Wed, 26 Jan 2022 18:55:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2155615C6; Thu, 27 Jan 2022 02:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0323DC340E7; Thu, 27 Jan 2022 02:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643252153; bh=OIXCx8u8XiNTdbHm8Qzedtuglcqhczz5oQQNj2qRhSE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bsX1Q0HbP6j0fkQcAfCAtNBtapvdfKPpgB29m8iiWEEUGhsJT+W+TFdNEsDDTy4lm eJJmF0ux8RrSIcwTF77O2ex9nAdHkDV3ozDR5f/jp1NuBwSRpixAjxufY9d+s/SRGy rEu0EwcWY8LBixDsp3Ni3SfAzsbdj2G4Lv3siVLTlI9w7cUR711HDcZJFvKQ8c+xAD TzPvC0Id+H7+xwffGfFJKDxhiIrlTu7iedvm8yQMzf5QJwmw/MSeurq1nJ0A4Lsw8F cMIdT6SpQ9VlaVCzX/qPNQDQXE20ldcujL/x5KSVF119XLTvrU+w1kJDl7ixHawuuO 8UUhH/pAIFkOA== Date: Wed, 26 Jan 2022 18:55:52 -0800 From: Jakub Kicinski To: Jeffrey Ji Cc: Eric Dumazet , "David S . Miller" , Brian Vazquez , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jeffreyji Subject: Re: [PATCH v4 net-next] net-core: add InMacErrors counter Message-ID: <20220126185552.57d5b99e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220125232424.2487391-1-jeffreyji@google.com> References: <20220125232424.2487391-1-jeffreyji@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jan 2022 23:24:24 +0000 Jeffrey Ji wrote: > v3-4: > Remove Change-Id > > v2: > Use skb_free_reason() for tracing > Add real-life example in patch msg > > Signed-off-by: jeffreyji > --- > include/linux/skbuff.h | 1 + > include/uapi/linux/snmp.h | 1 + > net/ipv4/ip_input.c | 7 +++++-- > net/ipv4/proc.c | 1 + > net/ipv6/ip6_input.c | 12 +++++++----- > net/ipv6/proc.c | 1 + > 6 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index bf11e1fbd69b..04a36352f677 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -320,6 +320,7 @@ enum skb_drop_reason { > SKB_DROP_REASON_TCP_CSUM, > SKB_DROP_REASON_TCP_FILTER, > SKB_DROP_REASON_UDP_CSUM, > + SKB_DROP_REASON_BAD_DEST_MAC, Ah, sorry I missed that you pulled in the reason in v3, I thought you'd leave it to Menglong. Either way is fine, but "BAD_DEST_MAC" is probably not the most fortunate name for this reason code. Menglong had OTHERHOST - that seems more intuitive to me, the MAC address is not bad, it's just not the address of the local host.