Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd
 subdevices
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     robh+dt@kernel.org, s.hauer@pengutronix.de,
        devicetree@vger.kernel.org, festevam@gmail.com,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        y.bas@phytec.com
References: <20211216115529.2331475-1-andrej.picej@norik.com>
 <20220126092426.GJ4686@dragon>
From:   Andrej Picej <andrej.picej@norik.com>
Message-ID: <38498017-dd47-ac02-0db7-85cf7fc48a59@norik.com>
Date:   Thu, 27 Jan 2022 07:28:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220126092426.GJ4686@dragon>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shawn,

On 26. 01. 22 10:24, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
>> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
>> mfd subdevices so they can be used.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>>   arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index f3236204cb5a..2ec154756bbc 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
>>   				regulator-always-on;
>>   			};
>>   		};
>> +
>> +		pmic_rtc: rtc {
> 
> Maybe a more specific label like the following?
> 
> 		da9063_rtc: rtc
> 
> And it's more aligned with da9063_wdog below.
> 
>> +			compatible = "dlg,da9063-rtc";
>> +		};
>> +
>> +		da9063_wdog: wdt {
> 
> watchdog for the node name.
> 

I'll apply your suggestions and send v2.
Do you agree that I also change the commit subject line to "ARM: dts: 
imx6qdl-phytec: ...", as you suggested in patch 2/2?

Thanks for your review.

Andrej