Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded
 MFD-subdevices correctly
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     robh+dt@kernel.org, s.hauer@pengutronix.de,
        devicetree@vger.kernel.org, festevam@gmail.com,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        y.bas@phytec.com
References: <20211216115529.2331475-1-andrej.picej@norik.com>
 <20211216115529.2331475-2-andrej.picej@norik.com>
 <20220126092741.GK4686@dragon>
From:   Andrej Picej <andrej.picej@norik.com>
Message-ID: <b7ce8b9e-e11e-fe7e-bf20-41cee9ee933b@norik.com>
Date:   Thu, 27 Jan 2022 07:29:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220126092741.GK4686@dragon>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26. 01. 22 10:27, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
>> From: Yunus Bas <y.bas@phytec.de>
>>
>> The proper way to handle partly used MFD devices are to describe all MFD
>> subdevices in the devicetree and disable the not used ones. This
>> suppresses any warnings that may arise as a result.
>>
>> Signed-off-by: Yunus Bas <y.bas@phytec.de>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> 
> Use subject prefix like
> 
>    ARM: dts: imx6qdl-phytec: ...
> 
> Shawn

Will send a v2 with this change.

Thanks.

Andrej

> 
>> ---
>>   arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi      |  5 +++++
>>   arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index 2ec154756bbc..3590f439adf5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
>>   		da9063_wdog: wdt {
>>   			compatible = "dlg,da9063-watchdog";
>>   		};
>> +
>> +		onkey {
>> +			compatible = "dlg,da9063-onkey";
>> +			status = "disabled";
>> +		};
>>   	};
>>   };
>>   
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 94b254bfd054..28a805384668 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -116,6 +116,16 @@ watchdog {
>>   			dlg,use-sw-pm;
>>   		};
>>   
>> +		thermal {
>> +			compatible = "dlg,da9062-thermal";
>> +			status = "disabled";
>> +		};
>> +
>> +		gpio {
>> +			compatible = "dlg,da9062-gpio";
>> +			status = "disabled";
>> +		};
>> +
>>   		regulators {
>>   			vdd_arm: buck1 {
>>   				regulator-name = "vdd_arm";
>> -- 
>> 2.25.1
>>