Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1531501c-ec77-5219-8bd7-c9db3ae6f2fb@intel.com>
Date:   Thu, 27 Jan 2022 14:40:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.1
Subject: fs/ext4/super.c:5649:3: warning: Value stored to 'ret' is never read
 [clang-analyzer-deadcode.DeadStores]
References: <202201261659.dZZOrgxb-lkp@intel.com>
Content-Language: en-US
To:     Lukas Czerner <lczerner@redhat.com>
CC:     <llvm@lists.linux.dev>, <kbuild-all@lists.01.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Theodore Ts'o <tytso@mit.edu>,
        "Carlos Maiolino" <cmaiolino@redhat.com>
From:   kernel test robot <yujie.liu@intel.com>
In-Reply-To: <202201261659.dZZOrgxb-lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1o2M29mY3RmcDhWY2k1eml4Zi9xYUNmOWF3KzRidjFvd2dPc29BSjlZeThp?=
 =?utf-8?B?OCs3UkM2NlpqSTdLbTgxQlFyYksyQmhRZzNvT0VBUlc5Yjk4dDEvU3g2NVZv?=
 =?utf-8?B?NWMwMjFacm9kVkpVeHZINHYxTmRySkxIQ1U3aUk4aDhsR2F3L0QxTExDWWFI?=
 =?utf-8?B?RUdhMk5oQnhmZVpPTE1TVCttbEQvSGwxUk1xLy9hS3V4WGEzeTV5Um42bmhR?=
 =?utf-8?B?K00zNUpNSzRYd3dOVkcvSEVWZnpFQWZFSEFvTk5BVy9rOENWc0NlV08rQnJC?=
 =?utf-8?B?ZHlrTUZuemFqUm1SeXlsZEtKa0dhWkFBU3RLWnFjWU9ROCttZTVvYm9HVUhF?=
 =?utf-8?B?bTlHb3Z1ckU1VzJ4akJyRjBNSjNYRWRWc1o3Q1k0RGNXYmJVVk5QcmFYMTdM?=
 =?utf-8?B?RXVaWCszSlZvRjBUL0V6YWprdzkwS0syZkNQRnZHSmU1T1h0S2tFRTFmV1JK?=
 =?utf-8?B?V0R1SUZ5MWhlNkN2WU1vOG9saVlUbEhEd1ROV21jTFd3cS9iK0VzSEtMYWdH?=
 =?utf-8?B?RTZkbEpwdWVhRHBBWHJXNDMyL1NNaWM1ZDQ3Wi9zTkNpMklxVU13KzhnUms0?=
 =?utf-8?B?RGNOOFl1SktkU0c1dVhqeko3TC93MnAzaTF6dGpEcFRNM3JQL3pxSjdjZGlJ?=
 =?utf-8?B?cTBidVA3bmFxdkVRZmVZZGcxb0crem45Y0dUamZ4STlReE5tUmRIV25BVUpq?=
 =?utf-8?B?SFJ5T0hNaDF0ekhRbGFZaGJmN1dNdWd5Nm15VlFnZWg1V3hpcjZENFY3YjR4?=
 =?utf-8?B?STY1NzQrclR5cFJ6VnFpa3NDblZJV0twMk1sREFzYUdzcmZGVU8xaGNQVDlp?=
 =?utf-8?B?dVdEd3R4VGdCRWZGM0E0aHEyb29SVituZU53T1hRSDdkdVdOL2pDbGVISXd6?=
 =?utf-8?B?aFB5VVBPZ08xWXU4NVF5c01VdElXZWl1aGZiaDUrQ0xmWFFvS3Y3QWpoQlBq?=
 =?utf-8?B?RENiZDlVN29rdkZBYWxzMk94T0xMYUF2NTBiaEw3YXliekhRdWtHczgrb2w5?=
 =?utf-8?B?Z0Z5SlNWOUFRRCtYZElSODk3cGdXM0dlUTRCL0kzZHYxdU9SRmVjZitzMHBL?=
 =?utf-8?B?M296ek1mWnFGV1ppajJLaDY1V0Y0VVgzek9sK2hpYUU2THJSQ2xUQi9OMERZ?=
 =?utf-8?B?dEsvZjBPOEs0SENNNXFRTS95OXE1bWM1QS83TCt6cHVUTGJUOVJrc2VqWWlD?=
 =?utf-8?B?RXNVOUw3akx1Yi8yM2NEY1FRSDBqb0ZMb3dwZEh1WmFuem1GZWYzTnA2UzND?=
 =?utf-8?B?U3BIUFc1MExyS3YvZnZ2MmFzM3R3WUhwcGNpZWNOVi9lYlF6OWRHWVpsZ25R?=
 =?utf-8?B?aDM1TFNQUW9wbytIdXlxUDRrQlA0NytUeXBjd2krNWRJcGtCWUlmdEVlZ0l0?=
 =?utf-8?B?aGlpbFNuSDBKdGw2RHFETitTSUxOUk5uWWplQnlacVBHNW5FWndHbHFtZjFp?=
 =?utf-8?B?Zit6amVjaGEwZzNKWjdKQ2FTMDJQaERaV2ZqWS8xcmdUc1VMeDZKTjZXdldF?=
 =?utf-8?B?U3RrV3FtMGhtTzlTZWlKSUoxL1dvTkwvc0tiZk9HVnV2LzBpaDByazBkQWI5?=
 =?utf-8?B?MzVad0Y5dHVwNmVwZ3Vwc3d3cGJXKzd5QXJLS1d3QkhQNnkyV1c1QXh2dWhC?=
 =?utf-8?B?YTIxTGZwckpIUkY5b05lc0N0TnFVWDZJbERoNEhnOHMvcHlTNmN3OGJJVFNh?=
 =?utf-8?B?RStsMXlRaUMzV2VkRnZQOVRSek9SNDhzaS9HZkF5TnpoMDZkUUNmZVM2SDhy?=
 =?utf-8?B?QTdsRmw0NjZFSi9IYWw2ZllZcE5HM2REbVFRazN2Z25xMjZBaHdkSGxxaFI4?=
 =?utf-8?B?WGVWRFZqV3ZLYlZwWGVZN3phUVRiTE1DbGNFZjJzSlJET0hKMEl4NkVGT2My?=
 =?utf-8?B?SjgyNytvZ2h0Y2I2ODlLUWlyTDVlWDV0T2czTW9zRmZjNEJMdFB0ZFk0OHN3?=
 =?utf-8?B?RGRlcmNWNmZ0bk5RMDYrY2p0dFF4Z3dtZ2hiWTcyZGRDR1ZyeHU3dkFjYVg5?=
 =?utf-8?B?NG5wUzFXcGxXQm5Lb0VLSEhJaHE0alVyMzBjQUx4eE1ybDV4QkVKVkFXWjg4?=
 =?utf-8?B?Vy9ITHFWK0FrRzgzdWlDUDB1VXdzSmloMmVTeDQvRlNyZDVXd041TWJkMElL?=
 =?utf-8?B?d3UrRENneGg3VUh6aUlQWlIvVjNyUmJZMU9JRXdoMUprTTJaRHAzVVNHYmR4?=
 =?utf-8?Q?D/ECKhlGLteb/1RA0+xKwds=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e6a8a712-098e-4aa1-dbf2-08d9e15ffe99
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5598.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 06:41:06.1149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q+t3iYkHBhpy2k27/J9haxtrYYOCRAS87B26gczUzQi2g9R0JJReZPh6/WQtyGO+1I3gTiVnL02mjVr/anRXBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1822
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
commit: cebe85d570cf84804e848332d6721bc9e5300e07 ext4: switch to the new mount api
date:   7 weeks ago
config: x86_64-randconfig-c007 (https://download.01.org/0day-ci/archive/20220126/202201261659.dZZOrgxb-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295)
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cebe85d570cf84804e848332d6721bc9e5300e07
         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
         git fetch --no-tags linus master
         git checkout cebe85d570cf84804e848332d6721bc9e5300e07
         # save the config file to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <yujie.liu@intel.com>


clang-analyzer warnings: (new ones prefixed by >>)

 >> fs/ext4/super.c:5649:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
                    ret = -ENOMEM;
                    ^     ~~~~~~~

vim +/ret +5649 fs/ext4/super.c

ac27a0ec112a08 Dave Kleikamp 2006-10-11  5639
cebe85d570cf84 Lukas Czerner 2021-10-27  5640  static int ext4_fill_super(struct super_block *sb, struct fs_context *fc)
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5641  {
cebe85d570cf84 Lukas Czerner 2021-10-27  5642  	struct ext4_fs_context *ctx = fc->fs_private;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5643  	struct ext4_sb_info *sbi;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5644  	const char *descr;
cebe85d570cf84 Lukas Czerner 2021-10-27  5645  	int ret;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5646
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5647  	sbi = ext4_alloc_sbi(sb);
cebe85d570cf84 Lukas Czerner 2021-10-27  5648  	if (!sbi)
7edfd85b1ffd36 Lukas Czerner 2021-10-27 @5649  		ret = -ENOMEM;

can use "return -ENOMEM;" here

7edfd85b1ffd36 Lukas Czerner 2021-10-27  5650
cebe85d570cf84 Lukas Czerner 2021-10-27  5651  	fc->s_fs_info = sbi;
cebe85d570cf84 Lukas Czerner 2021-10-27  5652
cebe85d570cf84 Lukas Czerner 2021-10-27  5653  	/* Cleanup superblock name */
cebe85d570cf84 Lukas Czerner 2021-10-27  5654  	strreplace(sb->s_id, '/', '!');
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5655
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5656  	sbi->s_sb_block = 1;	/* Default super block location */
cebe85d570cf84 Lukas Czerner 2021-10-27  5657  	if (ctx->spec & EXT4_SPEC_s_sb_block)
cebe85d570cf84 Lukas Czerner 2021-10-27  5658  		sbi->s_sb_block = ctx->s_sb_block;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5659
cebe85d570cf84 Lukas Czerner 2021-10-27  5660  	ret = __ext4_fill_super(fc, sb, fc->sb_flags & SB_SILENT);
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5661  	if (ret < 0)
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5662  		goto free_sbi;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5663
cebe85d570cf84 Lukas Czerner 2021-10-27  5664  	if (sbi->s_journal) {
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5665  		if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA)
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5666  			descr = " journalled data mode";
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5667  		else if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_ORDERED_DATA)
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5668  			descr = " ordered data mode";
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5669  		else
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5670  			descr = " writeback data mode";
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5671  	} else
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5672  		descr = "out journal";
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5673
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5674  	if (___ratelimit(&ext4_mount_msg_ratelimit, "EXT4-fs mount"))
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5675  		ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
cebe85d570cf84 Lukas Czerner 2021-10-27  5676  			 "Quota mode: %s.", descr, ext4_quota_mode(sb));
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5677
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5678  	return 0;
cebe85d570cf84 Lukas Czerner 2021-10-27  5679
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5680  free_sbi:
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5681  	ext4_free_sbi(sbi);
cebe85d570cf84 Lukas Czerner 2021-10-27  5682  	fc->s_fs_info = NULL;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5683  	return ret;
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5684  }
7edfd85b1ffd36 Lukas Czerner 2021-10-27  5685

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org