Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a90a0817-07b0-dd11-1bd2-236ca046821d@amd.com>
Date:   Thu, 27 Jan 2022 08:28:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 09/19] dma-buf-map: Add wrapper over memset
Content-Language: en-US
To:     Lucas De Marchi <lucas.demarchi@intel.com>,
        intel-gfx@lists.freedesktop.org
Cc:     dri-devel@lists.freedesktop.org,
        Matt Roper <matthew.d.roper@intel.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        linux-kernel@vger.kernel.org
References: <20220126203702.1784589-1-lucas.demarchi@intel.com>
 <20220126203702.1784589-10-lucas.demarchi@intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220126203702.1784589-10-lucas.demarchi@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmtQSjRiYVRtY2s4Wk5wSGRqTXdudUEyZHVWYmlkWWVTQ2s3VXk2Qi8vdzRX?=
 =?utf-8?B?L1FRQW1JVU9ZU25Rc0RPSkFCeVBEclFOS1hsb0hiRSsxVFpCd0ZXZHB6RzQv?=
 =?utf-8?B?dHlMd0luYlJZUGRoaXgxOGF2WElqTi8yTTRseUc0b0ltMFNvd0FCbzUyRkZ3?=
 =?utf-8?B?NGEwNjJRajdQSGRGL20wZjNFWnRaZzRzVHZEbDFTdS82L0RMaSs2MUhCRFFI?=
 =?utf-8?B?a1U4dXpTSG9EdjV0cmxpL0QyRndSZEFONm5OWXE5SkxONTVoeVJEZWJIWFh4?=
 =?utf-8?B?UW9hREU2OWNEUEFuT1BZNEgydnZ5OTNQUjBCOEtwSkE2TTVlc3g2SWcxYkNF?=
 =?utf-8?B?UktDTnpwSktLZjBMQnVodldPM29BUi81Q0g0T25lZzhscStTdjVUS3pkMFlw?=
 =?utf-8?B?Z1hBcjREQVRrVEo3cFlTYnlYeU5IZGc1ZWxHWk5ZNnlvTHBqaW5WUDhkbmlX?=
 =?utf-8?B?Y3hFUkdrUDJjbkE5RHpSTCtyQ0hJNitVUlY0OFZNNlMwTlJuMy9RU3JZNzNs?=
 =?utf-8?B?QjRRN2xJOVJuTUsxVXpaQjBCZUt2TndhMmRJZUZCZWZ6VnJxTGhRcERwaUpv?=
 =?utf-8?B?OWNuYW12TVg2a3k5UjR0K050NEFBTW5zcDhHQ0F0WFR3N0xyRHhta1hPbjZm?=
 =?utf-8?B?d0UxRzBzSURNbjlMcUp1VE51MWZ4cDFrVHJTVXNNVXdIWU9Rb1FHd1BuUGpX?=
 =?utf-8?B?blpTMTNvYmJ6enNKdlUyT3NFUEY3VVVmQ3lnbW13S1VLSXd1RVpndVVUc3Rh?=
 =?utf-8?B?VHhhL2hYYVc0ZnJPYmhibU1iRytPNHh6Z2pWMmJIVlI0N05tOVhFTVR5ajBT?=
 =?utf-8?B?SGJQMFQ3aGZjeC90NVJCWFNZdSsvTTlneSsxdy9IK3puSmJhWTkrdERnalVl?=
 =?utf-8?B?L1V1MDhORmVwOW5rWUFtc3dtL2xHemt1RDRwWjVKcVZ6TXlqUk9zdkl4Nmtj?=
 =?utf-8?B?a2FseFZScVBWRFFWay9vQWg5OFM5cEs4eXFLNEFNMTYzeWZSYnd1Y0ZiMmZa?=
 =?utf-8?B?OHEwdzBBMGl5RVJIV0p4TWtTcGpPcWVmV2VpeHJoTm9tNmR0VGQ5VnMxY2JF?=
 =?utf-8?B?b3BHK041NXlaS293TEIrQ0JEeS9odWRvK1VuMDROSEI5M3VodUNoTEJWakRp?=
 =?utf-8?B?bXlzOXFONVRMYmZvTktYWE9yRlZyYU9QZzFwaC91aFFFTk5leFFiSDFtdkxu?=
 =?utf-8?B?ajJ2RTlrUUlnRFpyY0wwTVdNQjRpS1J0MXAwdktBcXlzSGxTUCtaMlZ4ZGZM?=
 =?utf-8?B?SzlONU1KQW9DQTJzN0JkcjVLU09tTVJ5dkxDYTRoSUJCZDBNM2x6ZmVRK3Ni?=
 =?utf-8?B?WGVkTHh1WkREYmFOWCtQYVhzSkNPZkJlOVlIZ2Fmb1Vwb2IvVWZjSFBmVlVU?=
 =?utf-8?B?WG02U0RhdFNsbWVPT1VKcExFWFpmM1hwRGdxbFAxc1F6d2hNRXBUUzRYVW5J?=
 =?utf-8?B?M3N6NEVsU1NwVVpyRmRqOFdFdFZHelFVRU1EdHNyTW5EQzF4VldGakdxNk1E?=
 =?utf-8?B?WVpMTkcyeklwU2JvTVJJc2pYb0NRbHJuS2gwSnZPNkNyN2dSeHBSbW8yby8z?=
 =?utf-8?B?SjhhZGRycGNLUnp4a2VOaG9RZGVvMFlRVUhsenJUYWoyM2VoRE1rS2ZzS1Bt?=
 =?utf-8?B?Y29uN1dGWlNFWkZMVDRxei9KZGpUSkd2MkJMNEV4YzY0ZGR1UmFVTHp4aFBy?=
 =?utf-8?B?eVhmY21mQjJtUGZsTExFcjdCSDRZbXNzTlh2dW1NNFV0eDZ1aG1VWG1NcjZP?=
 =?utf-8?B?VndGZGo5NmlWT2NyYmJNNHZtZUlUQzJyMysydHFncHpnM1VZQXVQZ0JlSjVa?=
 =?utf-8?B?dWU5b1pJL3JNdEsyY2hkYjhYb1ZzRlZNUU1KZEpIdGRldmhyelo1ODgzTU91?=
 =?utf-8?B?MC9QU28xSTBoWThQeHB4QkI0QUhselB3Nmh2a08zKzZEcmF5aHFHenhRZzA2?=
 =?utf-8?B?MEo0aS9KdTFES0FEV3MvWDh1ZC9tT2NhcEtpQmdRclF4RzhoeVFFekxOaFFm?=
 =?utf-8?B?eENhN2c5dGFMUWJvV2JXckh4bStrdkJ0YWlRZlBLZk1Vd3gxRkZ2YlpIYkQx?=
 =?utf-8?B?U1QzUS9ObGM5cFl5OWZjUThRdXljaHhtV2ltbjBuS1E3NkczcmNuenVmZnUr?=
 =?utf-8?Q?ri7U=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5c42e0e-2ba6-49eb-659f-08d9e166ade0
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 07:28:57.1588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fJtacokKJuWFriPYq1m5zRyYb3FVEheZa+6u7AVytTQcVHKfc72gQHKUlfYhhcHm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2603
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 26.01.22 um 21:36 schrieb Lucas De Marchi:
> Just like memcpy_toio(), there is also need to write a direct value to a
> memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io()
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>   include/linux/dma-buf-map.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h
> index 3514a859f628..c9fb04264cd0 100644
> --- a/include/linux/dma-buf-map.h
> +++ b/include/linux/dma-buf-map.h
> @@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct dma_buf_map *dst, const void *sr
>   		memcpy(dst->vaddr, src, len);
>   }
>   
> +/**
> + * dma_buf_map_memset - Memset into dma-buf mapping
> + * @dst:	The dma-buf mapping structure
> + * @value:	The value to set
> + * @len:	The number of bytes to set in dst
> + *
> + * Set value in dma-buf mapping. Depending on the buffer's location, the helper
> + * picks the correct method of accessing the memory.
> + */
> +static inline void dma_buf_map_memset(struct dma_buf_map *dst, int value, size_t len)
> +{
> +	if (dst->is_iomem)
> +		memset_io(dst->vaddr_iomem, value, len);
> +	else
> +		memset(dst->vaddr, value, len);
> +}
> +

Yeah, that's certainly a valid use case. But maybe directly add a 
dma_buf_map_memset_with_offset() variant as well when that helps to 
avoid patch #2.

Regards,
Christian.

>   /**
>    * dma_buf_map_incr - Increments the address stored in a dma-buf mapping
>    * @map:	The dma-buf mapping structure