Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Randy Dunlap <rdunlap@infradead.org>, akpm@linux-foundation.org,
        broonie@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-next@vger.kernel.org, mhocko@suse.cz,
        mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)
In-Reply-To: <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20220127050456.M1eh-ltbc%akpm@linux-foundation.org>
 <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org>
Date:   Thu, 27 Jan 2022 11:44:18 +0200
Message-ID: <8735l9y0lp.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 26 Jan 2022, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 1/26/22 21:04, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to
>>=20
>>    https://www.ozlabs.org/~akpm/mmotm/
>>=20
>> mmotm-readme.txt says
>>=20
>> README for mm-of-the-moment:
>>=20
>> https://www.ozlabs.org/~akpm/mmotm/
>>=20
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>=20
>> You will need quilt to apply these patches to the latest Linus release (=
5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated =
in
>> https://ozlabs.org/~akpm/mmotm/series
>>=20
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
>
> on x86_64:
> (from linux-next.patch)
>
>
>   HDRTEST drivers/gpu/drm/i915/i915_gem_evict.h
> In file included from <command-line>:0:0:
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:15:15: error: =E2=80=98struct =
i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible=
 outside of this definition or declaration [-Werror]
>         struct i915_gem_ww_ctx *ww,
>                ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:21:14: error: =E2=80=98struct =
i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible=
 outside of this definition or declaration [-Werror]
>        struct i915_gem_ww_ctx *ww,
>               ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:25:16: error: =E2=80=98struct =
i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible=
 outside of this definition or declaration [-Werror]
>          struct i915_gem_ww_ctx *ww);
>                 ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Thanks for the report.

This is only visible with CONFIG_DRM_I915_WERROR=3Dy which depends on
COMPILE_TEST=3Dn. We use the "HDRTEST" and -Werror for development and CI
to keep the driver clean, but it's not really intended for general
consumption. Usually when something like this even hits the tree it's
because of a merge mishap somewhere down the line.

BR,
Jani.


--=20
Jani Nikula, Intel Open Source Graphics Center