Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6236823pxb; Thu, 27 Jan 2022 09:14:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4jgOVEJhaHu4LLsUS753QzXpB14Uhkx2VdzuIY3VkNAjbiKqKvbsWjXKHaiPsU54HV6ZH X-Received: by 2002:aa7:cd7a:: with SMTP id ca26mr4640432edb.42.1643303679300; Thu, 27 Jan 2022 09:14:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643303679; cv=none; d=google.com; s=arc-20160816; b=MoQ3FE7Qpq+yDTZnm708ZMDeiEwxOuWuIHIuI+MAxnSs1m1rWMn9Q4YBa62tK+z/1h OqXJQe0dS/VKu8/PkI1lcIJI8mIApsugOJI4ULNniee8sfvC5S/S/Q4gC+RX0k8evBcX bEo3ADlmhs16sh3EvrXq5kGKM7mHe9PFeIgZ4JnbcjCOQ8r9Jqn2tD5iQiU0+YZuGDSb E8ZFsBO/xL4BF0N4UCOGga1UZfRHTak05cnoENteO6Ae7FS5F82wqOoAoSkGCm2uDwRC OY2Uqs7eU59sFafrX7/B3cM69uPsSVrLseIPlz9Nt3Aq9uOi87/59T/Fze5DpXF0YYf/ V6ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0NAy8wocvqsiALK9bDMO3lSLn+RuXKvaS9DlBcJzgmc=; b=XQ52wSeLRgWAjA9BL3OrMHIYWqsl4Pud1Aj0MZqee8L+KExWbumY00yj1CJwXA+ruZ c6jP9qPicDdrgkqbccyl5AYaZOl6f+uEylX6wHhTnmXQYW2/xom3GDlvptG/j2lxA2pZ W7gs1NOl6aFbmPu4uJ/v6rdY4RJV9I+lylWpYZiHlfkBmubO5ZkJ91Q8ZC8ZlLE8SbEk 1rKPIoSjn0BBTDV8oJRCumDFHQaUpQr0IIB6pmShGYs6fRnZurcqJAeH75FpPneK9U42 TD4Q7XUZnDBMXXaXIpgFUhtbOkLKwpHSQHMSOCePnTikkHZMHs0CZ8qJoswNo7W0BH4q q4Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yR+aEqUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f3si1465568ejj.22.2022.01.27.09.14.13; Thu, 27 Jan 2022 09:14:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yR+aEqUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238855AbiA0JwK (ORCPT + 99 others); Thu, 27 Jan 2022 04:52:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbiA0JwJ (ORCPT ); Thu, 27 Jan 2022 04:52:09 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F251C061714; Thu, 27 Jan 2022 01:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0NAy8wocvqsiALK9bDMO3lSLn+RuXKvaS9DlBcJzgmc=; b=yR+aEqUOzXhIW8RsCKe5wiswgh b2BubhjdXNuFofnaLH/syQjatt96PFaRhSVq4gOD+RPYlsDnCYdML+2TxHa9YXdMflneayNrrCuQz WNI/r1iqmooa/DN2IMs3qJ+gyjS9vVopjdIqkyh+odnD8qKohq9mw8YmfU0prAOYrQsFnvdlWA0dQ Blklpaia1EI6QohM9cNafspBks8j6+in+IPGLHyJOf4T83TVLXAzjEFjQMAq+DxMS6BRlRPxWO7yX LFWfZIELFcWslK4cGpTBqoQ3a1CYasIv7IT91lsSQCz8IVJHjqim4Nh127Zl4H70xMBGJJ+5VbTAF Uxd4Nojw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD1Rn-00Ez4V-7y; Thu, 27 Jan 2022 09:52:07 +0000 Date: Thu, 27 Jan 2022 01:52:07 -0800 From: "hch@infradead.org" To: Chaitanya Kulkarni Cc: Yang Shi , "xiyou.wangcong@gmail.com" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "axboe@kernel.dk" , "hch@infradead.org" , "rostedt@goodmis.org" Subject: Re: [v5 PATCH] block: introduce block_rq_error tracepoint Message-ID: References: <20220126185153.417948-1-shy828301@gmail.com> <8de293cb-168b-5a52-3791-dba36ef4217d@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8de293cb-168b-5a52-3791-dba36ef4217d@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 08:02:26AM +0000, Chaitanya Kulkarni wrote: > > + __field( unsigned int, nr_sector ) > > + __field( int, error ) > > + __array( char, rwbs, RWBS_LEN ) > > + ), > > + > > + TP_fast_assign( > > + __entry->dev = rq->q->disk ? disk_devt(rq->q->disk) : 0; > > + __assign_str(name, rq->q->disk ? rq->q->disk->disk_name : "?"); > > Did you verify that rq->q->disk NULL checks are must in this checkout > for blk_update_request() ? Yes, we need this.