Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6237843pxb; Thu, 27 Jan 2022 09:15:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+NuwyT69Vy4yzqUTW45Gfd5V7mYYAdFT6IgtEY0Mhwbn+cfOb3dxzCOaOwbTqOJaCVmwZ X-Received: by 2002:a05:6402:254a:: with SMTP id l10mr4429341edb.318.1643303749201; Thu, 27 Jan 2022 09:15:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643303749; cv=none; d=google.com; s=arc-20160816; b=zRMMpTHMuQAv/LKar3Sa6SUMNL0dauw8WhXrbo2LkQJO0qA/jAW92aB695XuikAHF8 EGiA3gSa9kq5g6gVwrioQvUBoWlNO2rC72j/Udkr4pEwVQOnoSBC6nSWvgIN2onOZL8h fLzubp/ASDyB5LBwKbFY8CX6DcJov6vLhYMGlvm6Zw6Wfehk2dpwdfYcDZfPo67yNZqZ f+3QO+clB3vulFpi3IqyTOL09n7VsrwCw6hL9hBKr3Sjl3XiSGMVu9sWQTzW5J2/Xkyl RAH39KBhv9W4LEp2MhCYkbhDe+1lYjlwa+28OlLv5r0c/9nlMWOFbEZsxGWD3Bc8bU7j YzNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f7MlaSEz6umLGGRRw+gzvEQHKmGazXR+6FAeeKIYXok=; b=MBflhlAj1Bt5s6qZpfBOMu511f0vf3YVk10J2lSPkxxLnh5hAv+JABVan/4TaYUvmi UhyN6JlDcNd366lnO/7904So8c6dS0GUbD6AlbdiXfP/bdlR3ifVc7ZMGPNUKd/45RGZ GGC5fiNV2GCmsi5LG4G/NyYq7Kmk5L0zmZUPd0f6qWj+Xh+WcCawmRnE8PRiXotBAsqi 2BK/SAbg0jAljZFZ3jx18Xfe29kzOyG5PQ7F9kt9ekUA4gkCf0RpVhzPuanvuhGVfhVs G28BfsX/2mg/eKU65qsi0bxJKQWcZyRWOP2DNQoUOTRdYA/6Aa86cw79zwkkjGZ3Nw8Q Dzbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nCtelemW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si1390962ejl.369.2022.01.27.09.15.23; Thu, 27 Jan 2022 09:15:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nCtelemW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237932AbiA0Jx5 (ORCPT + 99 others); Thu, 27 Jan 2022 04:53:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232109AbiA0Jx4 (ORCPT ); Thu, 27 Jan 2022 04:53:56 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6481C061714; Thu, 27 Jan 2022 01:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f7MlaSEz6umLGGRRw+gzvEQHKmGazXR+6FAeeKIYXok=; b=nCtelemW8pNoZKhelkxFwgSLGo 7g/YeHr4rfvd+kkipunDzfRg43eQr4RBKgBmoyYFi4sMqTOcnbb/HtD3ubsVeS/mhNCRQftkctSCn /n30/GhgqdHDdjLOLKq80fI8Ve3E2kUI7e17VhTGAmwQPUXg4mcNscWy7SJiqpphil/1+7WEaz5tD P72UnFCyMC8iYAdkE2d4kZR15UJuxhCspBeF1xrKdxfqMlZolfz08qMjOJimuqZNR0R7wON52e31N wYNHBzxezBSVBVA9uNGQSRF3gWtosXvoUv9JlkhlaRIP2vaBBvE1ExJkigA7Ihz3qZ/kbClm9Ahu+ m/s4yM8Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD1TW-00EzYz-Gn; Thu, 27 Jan 2022 09:53:54 +0000 Date: Thu, 27 Jan 2022 01:53:54 -0800 From: Christoph Hellwig To: Yang Shi Cc: axboe@kernel.dk, hch@infradead.org, rostedt@goodmis.org, xiyou.wangcong@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v5 PATCH] block: introduce block_rq_error tracepoint Message-ID: References: <20220126185153.417948-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220126185153.417948-1-shy828301@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 10:51:53AM -0800, Yang Shi wrote: > + __entry->dev = rq->q->disk ? disk_devt(rq->q->disk) : 0; > + __assign_str(name, rq->q->disk ? rq->q->disk->disk_name : "?"); None f the other tracepoints has the disk name, why does this one need it? And if you add it please avoid the overly long line. > + __entry->sector = blk_rq_pos(rq); > + __entry->nr_sector = nr_bytes >> 9; > + __entry->error = blk_status_to_errno(error); This still converts the block status to an errno.