Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 11:04:14 +0100
From:   Aleksa =?utf-8?B?VnXEjWtvdmnEhw==?= <aleksav013@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     salah.triki@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: dio: Fixed coding style issues
Message-ID: <20220127100414.o3hj63sirlavyb33@artix.localdomain>
References: <20220126195341.5154-1-aleksav013@gmail.com>
 <YfI7rZrYn4liKuPB@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfI7rZrYn4liKuPB@kroah.com>
Precedence: bulk

Hey,

I made a really simple patch fixing coding style errors.
Could you please review it, and tell me how to prevent errors like this:

> - Your patch did many different things all at once, making it
> difficult to review.

from happening in the future.

Should i split changes into 2 patches? One for upper half and one for
lower half of the file I changed?

Many lines have multiple errors, so if I fix one error, I also need to
fix the other one. So I can not just have patch fixing one thing at the
time. Should I try to fix error in this manner:
[PATCH 1/3] fix lines that have ONLY spaces to tabs error
[PATCH 2/3] fix lines that have ONLY braces error
[PATCH 3/3] fix lines that have spaces to tabs error AND braces error
or should I have a different approach?


Sorry for bothering, this is my first time submitting patches.

Thanks in advance,

Aleksa