Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6282076pxb; Thu, 27 Jan 2022 10:12:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxW3eUf/2o0kpB+muxFSQsIVWGG6TcIb94B5e9nNkNouNLxvgzj6/AmJcp5p6P893heDzQd X-Received: by 2002:a17:907:97cd:: with SMTP id js13mr3873353ejc.41.1643307162981; Thu, 27 Jan 2022 10:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643307162; cv=none; d=google.com; s=arc-20160816; b=AbPTGzpYVnemNsvLY7sMdypUPAIeXiaM0N2Q+cMbQECIBDcqfsirft9Hs9eePgzH0Z 2c7dsdfJIsUdk0Guhf/skpiU1+p2eBkuSXdDzNQInur3K4HbA+lEHcrMJyvRwKUKUJza VLX11p8LxTrzPnEbUkeEDD/kyvBBPGlUXpz5aCkITNF51oI8co4yaT/w+qvRMgQzEook y4XVYePPWywNZcELTHNSqAZDuBrD+zOjwurCYxBTY03X7KmIonzkg8yuI3TE9x+jbRNM rEYon734OYcBNFrpRwSdE0DrRd+8X0lF3/by4N7VeRtUa4yeAJKWObiRybJ6mz27qnhK xRTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=h7VN6MYiKCeMKXYR9qFW4fG+DxRWIMSo7IdB60OkWT8=; b=DSJ4qpsJmY+BadCo33n8z+aeZLNFZ2jWODSmR3LirKG3rO/eTUZAEn30OFTg1TJx3W GDkmQw+y196eYL6yfb9YZr4aW9x5cKsa362ZuYzU2JoaRoHs39MK66ry5LqsePlcQzpL VoAQ3XXsQ7S0m9QQ3dXXFHECvD7DXVZVr7vTRIyVZPfJiH4HwhdlieW5YWoZum4zVmI0 SO0P9pOua3LIcN8T0iQtfQHvCJY5QcLWLJwp/GLcwky0/3jpm5kozn2q3Rrt7CbMilcA C6bS4c/ayqqeINdyHiOD7woEqUNrAaiZQlpgavUmX7/aQbUkjvmtjZikrY1sM7KLAAD1 1ikA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Caw17/VT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si2005774edc.222.2022.01.27.10.12.16; Thu, 27 Jan 2022 10:12:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Caw17/VT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbiA0LAJ (ORCPT + 99 others); Thu, 27 Jan 2022 06:00:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231221AbiA0LAH (ORCPT ); Thu, 27 Jan 2022 06:00:07 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA62C061714; Thu, 27 Jan 2022 03:00:07 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id A55B71F45069 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643281205; bh=ANnHQ3AW7cDcFPINFPyo+6Bw6O0a8MPJooTmRyKn1hE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Caw17/VTX8SU25VO7GP+5IiEs1dWo3oL/oYurRO63dZMfiD658/+0GTHMpC+GisE1 lWS7UzOfaW8MWrVl7WYfDzdSQMNihCeu4FGO71j/YRQ/27J2ALxag45996kyXvtbSH QJJVIzvmiXDpWGMbTtKF5pWTD2V2fSI8LjekX7tdGRbgac5fjfWx9SgJCkNQnzF/vT NAgc1ZxUvsccvUC5S3aUN/TU8jU+o37BlVLMwllnO5CGAUXFoL1FIJ/Y410Cm1SZas 9u5WQxsoYUbcohM2ohbOBvPOtb5G7Hn1UEhFk4tRNJwv2Ib6Zixedmhj7Jd5uM4lHE of0t90CtngClw== Subject: Re: [PATCH v4 03/35] iommu/mediatek: Fix 2 HW sharing pgtable issue To: Yong Wu , Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon Cc: Robin Murphy , Krzysztof Kozlowski , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Hsin-Yi Wang , youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, yen-chang.chen@mediatek.com, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com References: <20220125085634.17972-1-yong.wu@mediatek.com> <20220125085634.17972-4-yong.wu@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: Date: Thu, 27 Jan 2022 11:59:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220125085634.17972-4-yong.wu@mediatek.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 25/01/22 09:56, Yong Wu ha scritto: > In the commit 4f956c97d26b ("iommu/mediatek: Move domain_finalise into > attach_device"), I overlooked the sharing pgtable case. > After that commit, the "data" in the mtk_iommu_domain_finalise always is > the data of the current IOMMU HW. Fix this for the sharing pgtable case. > > Only affect mt2712 which is the only SoC that share pgtable currently. > > Fixes: 4f956c97d26b ("iommu/mediatek: Move domain_finalise into attach_device") > Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno