Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6342960pxb;
        Thu, 27 Jan 2022 11:40:14 -0800 (PST)
X-Google-Smtp-Source: ABdhPJy/5S91SZTZFeyRbyftGVNRLNzncgouqTXFAjJbp7Aaab1cCAOBoEXvA+ZmHZd8rX3Rt9Ri
X-Received: by 2002:a63:530c:: with SMTP id h12mr3854529pgb.273.1643312413784;
        Thu, 27 Jan 2022 11:40:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1643312413; cv=none;
        d=google.com; s=arc-20160816;
        b=clzuSzwt2d8C9M3xRgiexu+aPPWEaCD+tV93qy40Bj01XlMkz/86U6qbO2oj+8a8aq
         Nvtu8d36kRQoDvNrVtTqmYYF/lX5K/1VwxAMmmWgmJ8tRxdi3X4TNOLgnECpQ/KFf/1Y
         wTdFfVUEBt2j+FPYZe7ZGC8S3J1W+Lbaz5biOFQUFV0oNhs4qZCibHmIuKKjP0aryE/d
         oBtWK+yPOlD1uNf2iuZZZ60rTeKfYl2A4eTlGYe6g+8hultw5eYsqYGvxbFXkNtcmDg4
         2knXwOGQPi8uhT1NRgobR/03zmH2U/Mrpda+sFMbFeK6MBCb6MBeAO7qqjTIstjiG1no
         uHTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=mhYhD39941ZkHSgnKHXqmDWsmhdkK7GBtKy3mfXsQts=;
        b=SVGnm6/6ZaG1TmpfuOTERB7L7fJprRVxqcFdzrQ0S+Q5IsxSJPBa/e5zSP8863HGsl
         DBNFBlmvZghGFaw4M8htCPtpj4DKYOGIMtYaYBkxBo10bhjqtk5k1uDHCUmph+YPI0qL
         V+aqLzXcXuBpjxtQtuekLA8xUwGQAisQr330sZN0iQ76H2c4KsS9T60ta1lZq7p5bDdj
         eUIISxJMlmGTK0Ad5BN/9ki5L9hjl5Wf+gNlph1h0NDq67w7Egizay8rZ6lUQBckYbZO
         C4MaCljgoF/25+oCURY4z5rR+GR9iogs4QuYWqjKDTaKWUckW7H3nc/MJJiUosC9AdG0
         UIYw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZP7hMg+X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id k190si738320pgd.701.2022.01.27.11.40.01;
        Thu, 27 Jan 2022 11:40:13 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZP7hMg+X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229484AbiA0LOA (ORCPT <rfc822;sshegde.linux@gmail.com>
        + 99 others); Thu, 27 Jan 2022 06:14:00 -0500
Received: from ams.source.kernel.org ([145.40.68.75]:48230 "EHLO
        ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233389AbiA0LN7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Jan 2022 06:13:59 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 64EBDB821EE;
        Thu, 27 Jan 2022 11:13:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA00C340E4;
        Thu, 27 Jan 2022 11:13:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1643282036;
        bh=1iWMjgJQHCCxYrBwu4Lbg5lRy+4oxDRGMKV7x5712Fg=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ZP7hMg+XeiSp8zezCJlwfyQ6OVUgmpg5veAuBQoAz4irmeQjX41BTmXViWj1H691g
         /YUlYS81UKBzptd4p9dGZwVBf8Qvt0HSL4UNcebVL1jVkhn1Hye9KnVXPWlgY62sZJ
         b8pNS3CR6dNRudjE3JFhEbHwcP9qmbLmvkTrSGBk=
Date:   Thu, 27 Jan 2022 12:13:53 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Oliver Neukum <oneukum@suse.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support
Message-ID: <YfJ+ceEzvzMM1JsW@kroah.com>
References: <20220127110742.922752-1-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220127110742.922752-1-o.rempel@pengutronix.de>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> The weakest link of usbnet devices is the USB cable.

The weakest link of any USB device is the cable, why is this somehow
special to usbnet devices?

> Currently there is
> no way to automatically detect cable related issues except of analyzing
> kernel log, which would differ depending on the USB host controller.
> 
> The Ethernet packet counter could potentially show evidence of some USB
> related issues, but can be Ethernet related problem as well.
> 
> To provide generic way to detect USB issues or HW issues on different
> levels we need to make use of devlink.

Please make this generic to all USB devices, usbnet is not special here
at all.

NAK.

greg k-h