Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6356801pxb; Thu, 27 Jan 2022 12:01:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8vmRKwF1AyueZMdOm8LQP4MEf04SDmyfyJONP8fuwg+B+9aWcv9SoMrmmUdWVWDd6jXj2 X-Received: by 2002:a63:81c6:: with SMTP id t189mr3888092pgd.417.1643313695009; Thu, 27 Jan 2022 12:01:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643313695; cv=none; d=google.com; s=arc-20160816; b=zaY2XF+yEcPdU9LS58A0Sicexc1ErshI2+yDTtkD08VHk6yddtIlwV4LmMRAab0dPe LZ5MWjR7N/5J75BW8HleoZstIA6C1xi7ycvgqTG3EnsCqAl10meDiar+jxJPv/kiRTrc 79/UZZRYUW7y/Y6SZWOqjzlCQZmyC8ZyZsRmGadjdf3qkI0qobJFiY6OiwayVUbmULr2 a/JwmAZzCsFu8Hd1hHAVmYEsHsEMdjEOmP3jDPDqbHVww6Pn9V5RQLJ3gKJY6sQBD8PU 8Eiyd2ec+cWstGCV0N3FAopRauIn+GjpQwWUSmwMuUQ1HreqE2gI6BawA2LX/gQnmjEh ilRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nFOmUPA+4JwWgK5Q3mWTfDAOQhAJdtAHA+sEGQIBP70=; b=OLJMSvycYbxcjjbarxTxrzFdhs+qGn5eZC1+OWXmHHsMkklu+Ym3IZbbb6FQxr2Z2P IfylG4Pap4tKpRBVYcCwJ/dfABZvUzT0Vf6GOdgPXyegnDiDUJpRHQWjBQkviXDn0MZ9 XMJU0FMBxhj3peB5sq/eHkS9zHpn4wziEwcjs1mhjbuMtNlD3BgSDwNL5ykLzKDDVDfW Za/fAEA8S9tokaMYEY76bygMPrbEN/aUglS9TDPb0i4G9CbHoAi7JkJcFP+7YhLlOt/G mfUgOz8ZbXAstu8I52FgbP2ZbMZLdw/Rl852Xssc8vofRpdSqOCofEgs0RTBe9DaPmhS j9vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I+r9F3AW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k10si3196792pff.167.2022.01.27.12.00.59; Thu, 27 Jan 2022 12:01:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I+r9F3AW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240134AbiA0LSk (ORCPT + 99 others); Thu, 27 Jan 2022 06:18:40 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:57308 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231251AbiA0LSi (ORCPT ); Thu, 27 Jan 2022 06:18:38 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E368460C0F; Thu, 27 Jan 2022 11:18:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D741C340E4; Thu, 27 Jan 2022 11:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643282317; bh=MHx8Ll56fdbfHbMZIJzpqKohDBZqdKnjvZtgrGP4EGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+r9F3AWRPENrkGX/mc61dBrNNS/VRaS+ly2y83/zGId8MpRx4GrQFE6yYDPFWWTP nTiq/E/hQoOQPpgw4hWYLzA4xN+aZ+7Mw9uAmNMGD/KsmQSLOBXKV0mvt7xbOlUpgj gS+D0BLhXiVV3xGOBNwWBPT1UvwG9D+h5RSdbxJA= Date: Thu, 27 Jan 2022 12:18:34 +0100 From: Greg KH To: Oleksij Rempel Cc: Oliver Neukum , "David S. Miller" , Jakub Kicinski , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support Message-ID: References: <20220127110742.922752-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127110742.922752-1-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote: > @@ -2137,9 +2183,10 @@ static void usbnet_async_cmd_cb(struct urb *urb) > struct usb_ctrlrequest *req = (struct usb_ctrlrequest *)urb->context; > int status = urb->status; > > - if (status < 0) > + if (status < 0) { > dev_dbg(&urb->dev->dev, "%s failed with %d", > __func__, status); > + } > > kfree(req); > usb_free_urb(urb); Also watch out for not-needed changes in your patch submissions. greg k-h