Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 14:33:50 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        robh+dt@kernel.org, gregkh@linuxfoundation.org
Cc:     lkp@intel.com, kbuild-all@lists.01.org, devicetree@vger.kernel.org,
        ekangupt@qti.qualcomm.com, bkumar@qti.qualcomm.com,
        linux-kernel@vger.kernel.org, srini@kernel.org,
        bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v3 01/12] misc: fastrpc: separate fastrpc device from
 channel context
Message-ID: <202201271857.MGiOkhFo-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220126135304.16340-2-srinivas.kandagatla@linaro.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sf+4P1ad/4PfKMPPK0B2B3gLTrIGOr1RuZWgAEYMzQ+zKRx1Ru0wd1bcY4Lz?=
 =?us-ascii?Q?k1jHv8A9Ub5KNFDp+hqrLHvKR5l6iwVJ6hTzgh1NEmFqBozvbFLCEHgo46+W?=
 =?us-ascii?Q?WYnNYHJ7FEL3Izi+gFrxy/ENPYjJO78wfa4mxpnUmGeMp/zpbI+E1xFfM3EJ?=
 =?us-ascii?Q?sYhpLbGliSMSXrg0ewC2JdlbxD95fzy5mOiRGXinGegn+Eezxa683BU7ycrk?=
 =?us-ascii?Q?N5R86BHMmy13c8CWJ/2HFu83oOjy41fYDJspu84agZUXNG6h0MUdgYH9qer6?=
 =?us-ascii?Q?Ckdg/q10eTzWwMdebO4xccCRo+UsLRv9KpIcEdFKucss5XRvts9Dic4xGd0x?=
 =?us-ascii?Q?nrUXtmV5JUfJwSwFVHYYy5ZgD2vwiySP1z8N/EtsnQSQ56hWiwOuAGm6OFY/?=
 =?us-ascii?Q?yEVTHenIMrfM+bI93fr5iwUX6t/N/X2WwBMx0rPIoqwm9fjHgiGI/2DMZ8VU?=
 =?us-ascii?Q?3QWWW9CAYCgYypoY6MDKLCaZGl27R2NPsojxdpCu4bMFynW8jRGu/b+7JMrS?=
 =?us-ascii?Q?8KECVNsCey1yDJuvw4rez39T3V9BzeVSSI6AYQi1RkGJuN/vekrPWGa6mle2?=
 =?us-ascii?Q?pXv0rYT3malasrzzeRiPZvviVaGfa0iikVyTnX8R9wx01k2zL2dAza/MrhS3?=
 =?us-ascii?Q?OgAzNj20cg40ojxcIo8ip8RSIzJ3T+XtQVvb+woHW1LbsCfEqo9YraHgHZC5?=
 =?us-ascii?Q?kcYHG2gQfe9D62YD1fPPrT8Huv3aqkLM0JLfFfLcHoJuJ25nGizCLqBErHSc?=
 =?us-ascii?Q?w2861LJ4AGTca1IMCQJY6VbfukKPpzhNaOCz8P8+vp2tYaeZ45EoPfYo9vXo?=
 =?us-ascii?Q?PUIDpXjSOEnTZB3NtKibGJe374ZPq6QBcdhcKAZ1C0k0yB9QlL5GSWn6OITf?=
 =?us-ascii?Q?D0a8yoc6f7VczHJl9LNc0U3y4vEmmaYlh6GLMH4bqeUCmnLSe7Mj6ycpLu+i?=
 =?us-ascii?Q?DuyaRIkSXQ0oe8Bhh+5FQcSRy/Pm+C6kXetEPxTsXOfko35rmFtakFvPaUgc?=
 =?us-ascii?Q?s1e99JH69B/CNNNPEZ/DDJMvmMJrrnuyOym+JjqNg2fgj4wtjZRsNoIdM/58?=
 =?us-ascii?Q?eABex9BMqiYwBOJBdAnKJQTDJnlrhMsy1M/HFLoZ7aqRHRghOu0rpGF8riGK?=
 =?us-ascii?Q?yTEpgrrW8LsVXMCkAfJcsi9MCenTE3+uv+jrkBDd+uX3cni4Qpdq6yiAYjc0?=
 =?us-ascii?Q?yzRDNYQBdkFNGaymndLDs/ootYzFgAtRfcxBBszdBZw03tNLUT8laiA8zElO?=
 =?us-ascii?Q?wmBAD8+Q9qMT1uFDlcxcnx7CvzqXCz5E23sDGz1ZN+g86Dqn4AB8vPNOQaoY?=
 =?us-ascii?Q?SWdSG/z6NgHRu6q9bQXdStysavi3Gb8ExMSvevfgwQKewKDHztPOZ37ZiyvA?=
 =?us-ascii?Q?vr9+EZHN3UnNwShOavdqI/7exfNKu2Yljja/EWCm7NezoCavnEi6OsOPHV91?=
 =?us-ascii?Q?JC1q4oXzIM74w05lBDoPF6lER9VjiHpMSkv2QPem8l3O5XUK3kpfTQ37yBOA?=
 =?us-ascii?Q?Humdgu6i9ldfdeAmhgr1YLVOlKb8Wq00OQ2AR5xEpi8yia0J1BLwGk9LoQbp?=
 =?us-ascii?Q?1twHAXGJpaZ0zHTYXiJYXxYC5nNyVEAxcwXSr3YWDVGDlWf3j+qIvKddjFPe?=
 =?us-ascii?Q?ZwgGD1Yq0Fm4xdtJhD4oU/ZjkxHImWGIdA+vMFcRHP2wpgeuV265YYudtkU6?=
 =?us-ascii?Q?3CTdJw7b/zj1L6M5iRbhn10LVRo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 658d0cdc-18aa-45fb-863f-08d9e188f29a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 11:34:15.4150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E9Nar5Wievufr/xoeMENZd36hKs9Lf8gBFK8+G2KrimLez7yN2npkmy+5NY2/UxPAS2fe28lGZgMt7FKyuI1GyfNNQGGMPoM3i9xfmMogvk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4281
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10239 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201270070
X-Proofpoint-GUID: 792luorSvMCfHdA5FXNAdWze0d36scVl
X-Proofpoint-ORIG-GUID: 792luorSvMCfHdA5FXNAdWze0d36scVl
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Srinivas,

url:    https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/misc-fastrpc-Add-missing-DSP-FastRPC-features/20220126-215705
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 515a2f507491e7c3818e74ef4f4e088c1fecb190
config: openrisc-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220127/202201271857.MGiOkhFo-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/misc/fastrpc.c:1636 fastrpc_device_register() warn: passing devm_ allocated variable to kfree. 'fdev'

vim +/fdev +1636 drivers/misc/fastrpc.c

99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1620  static int fastrpc_device_register(struct device *dev, struct fastrpc_channel_ctx *cctx,
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1621  				   const char *domain)
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1622  {
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1623  	struct fastrpc_device *fdev;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1624  	int err;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1625  
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1626  	fdev = devm_kzalloc(dev, sizeof(*fdev), GFP_KERNEL);
                                                        ^^^^^^^^^^^^^^^^^^^

99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1627  	if (!fdev)
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1628  		return -ENOMEM;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1629  
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1630  	fdev->cctx = cctx;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1631  	fdev->miscdev.minor = MISC_DYNAMIC_MINOR;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1632  	fdev->miscdev.fops = &fastrpc_fops;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1633  	fdev->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "fastrpc-%s", domain);
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1634  	err = misc_register(&fdev->miscdev);
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1635  	if (err)
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26 @1636  		kfree(fdev);
                                                                ^^^^^^^^^^^
Double free

99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1637  	else
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1638  		cctx->fdevice = fdev;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1639  
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1640  	return err;
99d9d7a1c5f2dae Srinivas Kandagatla 2022-01-26  1641  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org