Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp6358947pxb; Thu, 27 Jan 2022 12:03:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCguWyU5lR3GgTa6ohDCH+UKLLK8xaaaqcGpnxDXyo6X1M/YhmRKVWLSiyftSLV2xLbl8c X-Received: by 2002:a17:902:a9c8:: with SMTP id b8mr4817772plr.30.1643313832398; Thu, 27 Jan 2022 12:03:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643313832; cv=none; d=google.com; s=arc-20160816; b=P6ZceXWhIsIFmjlqpYSZE3y/ZrSvPSD7GPSIK2fZ1ioxjDOkVU07dShki8D8+U/t1f SrT7EL/bs+pho28UpZ7gob9rIDSsTx5vf22YZFox5i/MFyBaejcVZcZAng09JBNyGwQ1 mye1ECXq+ssmQNTcGB2xtvjkfqQ7ksAciipH0rqGR+22YKVmWyLBTCu4Cw24qINe6gn9 9J39Uu0CN5ylLmPjNEHHPag/Z32GSictqVTSCwEklXtKJSWy8rGRXd99GlBLEOhDEY2e 8Z7PMhwS2Q57l9l/HlxkGDvt8sliuaG6/0xNirlFJZ/FsPE6c7xTBmW3SpoNVs2BO2XD yUqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=kVlPTMDntv41BuaIBVh4q/kKYYaaoCfGMJweU6kQ6GM=; b=r/nz8AhAEh8JPzEdVvvKHJXUuGrrxyY9R8B1JZxTtW4TXi/XA7+hoqfFdHRKrI8mGZ AVuD6x+ODkhPOBpUeuHckXFTIBF95Pu/mSctZGp96yYGEH5hMpY5HwVSN//ieCTIzE20 eMAYP3x9CyNQbgsM8F7IGmsqJc6YZ5KXnnYYiXUQNAhtbiFjcK7MmCzuUhvoAWYSl3Pd 2nb7SiZ2T3zOvClashfrR9JG4av8+Tv6u/JEjeEhw1JHpemFsH/Qk8sFnjxDEDepH9AQ Bx1pHsDCFi16yRl8+Xed2wk7D9gNdJQ4oUxrm72OJUfS04RiM10CP0sq57Zdp5lMe1X7 Iazg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=1lx9niiI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Ez758sB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x67si2727758pfx.122.2022.01.27.12.03.20; Thu, 27 Jan 2022 12:03:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=1lx9niiI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Ez758sB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240431AbiA0Ldc (ORCPT + 99 others); Thu, 27 Jan 2022 06:33:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240493AbiA0LdT (ORCPT ); Thu, 27 Jan 2022 06:33:19 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6110C061747; Thu, 27 Jan 2022 03:33:18 -0800 (PST) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1643283197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kVlPTMDntv41BuaIBVh4q/kKYYaaoCfGMJweU6kQ6GM=; b=1lx9niiI8RRioyHNdrmVhjrW1KCB/zoquFCf9TJgs2Uq21WSsw28rWdIvFUxceQvO6pJKF UiFUea6uHg2UdxjqRDa0qej1X8oQAfysrkyvWiYfq+TQgc2jWSXssQJm7sdYqPOj+n9oVD NajTw7lyWg33dfO29HLLLi3oSNpQMwI3rDam34WHPjIrnEuVJ/12Qys7Z0dn7PCA5iXbjx 7KmYPa05CPQLX6xcxxXjcWGUk+twV/+l24UZN68nisyKE/CFXdCyuxwFKgA8+pooy32TSs Zme9QX79lV694NSsLuR8bWGZhEXT/AUxl2H/QOvKEi7eXWOSw+7VroIIIZjndQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1643283197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kVlPTMDntv41BuaIBVh4q/kKYYaaoCfGMJweU6kQ6GM=; b=Ez758sB8dJOJPOxiDBVk13iEEcMxNSfJ4V1ID+WIb76mNC9VLRRakMKQoXDdneK8cXd8R5 UT5PsJEZNEqX3FBA== To: greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: "David S. Miller" , Alex Elder , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Jakub Kicinski , Johan Hovold , Lee Jones , Rui Miguel Silva , Thomas Gleixner , UNGLinuxDriver@microchip.com, Wolfram Sang , Woojung Huh , Sebastian Andrzej Siewior Subject: [PATCH 6/7] net: usb: lan78xx: Use generic_handle_irq_safe(). Date: Thu, 27 Jan 2022 12:33:02 +0100 Message-Id: <20220127113303.3012207-7-bigeasy@linutronix.de> In-Reply-To: <20220127113303.3012207-1-bigeasy@linutronix.de> References: <20220127113303.3012207-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of manually disabling interrupts before invoking use generic_handle_irq() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/usb/lan78xx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index b8e20a3f2b84e..415f16662f88e 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1537,11 +1537,8 @@ static void lan78xx_status(struct lan78xx_net *dev, = struct urb *urb) netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata); lan78xx_defer_kevent(dev, EVENT_LINK_RESET); =20 - if (dev->domain_data.phyirq > 0) { - local_irq_disable(); - generic_handle_irq(dev->domain_data.phyirq); - local_irq_enable(); - } + if (dev->domain_data.phyirq > 0) + generic_handle_irq_safe(dev->domain_data.phyirq); } else { netdev_warn(dev->net, "unexpected interrupt: 0x%08x\n", intdata); --=20 2.34.1