Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 14:41:30 +0100
Message-ID: <s5ha6fhjnxx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     trix@redhat.com
Cc:     perex@perex.cz, tiwai@suse.com, nathan@kernel.org,
        ndesaulniers@google.com, kai.heng.feng@canonical.com,
        jiapeng.chong@linux.alibaba.com, giun7a@gmail.com,
        colin.king@intel.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ALSA: usb-audio: initialize variables that could ignore errors
In-Reply-To: <20220126182142.1184819-1-trix@redhat.com>
References: <20220126182142.1184819-1-trix@redhat.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 26 Jan 2022 19:21:42 +0100,
trix@redhat.com wrote:
> 
> From: Tom Rix <trix@redhat.com>
> 
> clang static analysis reports this representative issue
> mixer.c:1548:35: warning: Assigned value is garbage or undefined
>         ucontrol->value.integer.value[0] = val;
>                                          ^ ~~~
> 
> The filter_error() macro allows errors to be ignored.
> If errors can be ignored, initialize variables
> so garbage will not be used.
> 
> Fixes: 48cc42973509 ("ALSA: usb-audio: Filter error from connector kctl ops, too")
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks, applied.


Takashi