Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 14:41:30 +0100
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     linux-iio@vger.kernel.og, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Message-ID: <YfKe7wmORV/NB6K6@gmail.com>
References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de>
 <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="+v5ovSx6NdfX+t2+"
Content-Disposition: inline
In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
Precedence: bulk


--+v5ovSx6NdfX+t2+
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-K=F6nig wrote:
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>=20
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> ---


>  drivers/iio/adc/mcp3911.c                             |  4 +---
>  drivers/iio/dac/ltc1660.c                             |  4 +---

Acked-by: Marcus Folkesson <marcus.folkesson@gmail.com>

--+v5ovSx6NdfX+t2+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmHyoQQACgkQiIBOb1ld
UjKpzw//X302S4XWfBm4ad7jJOQHD3UX9Jh7ivlcRV8k5Fqn6BKDlq50UmSrP1AC
U1KO86IUTq8yOSaPKztHY1SA9mUkXAGom1Pk56fdGbSf9k7f1ILd+n1Cp/U8XaYS
UArOTZHvDuy0LhUkIQfUqqqwbSxw2ibLHC0eFzCibWga+0Fi8cp/wWVwfgLlgL1H
6dOtU9w8y4s2qiyDKFQPqix4SdTcbIw1hV8RR1rmUgpsxzeo7/0JW7ogW5y64K/l
ctTNvWYEcIAofoA+Cu1eZXn2sXhIpd571tXbemzdWN9HgidnECsp+fv2o9JKdHOI
6hM6Rdv4l6ZQAnb8C5uuUmDiqpCDWOIGUlVX/fz4eVJjST+pl/OIJMavtpjzEASb
gHn2kOui8ZxixyUhaNW5k0tL63NVg7VoOfJqx8aP0DKvg34Px9ONX6iWioMZV7zT
FOYZdkJTZHlftmmHZcttEy3w3XxjfrqPhs74viq96k0mRthycfcTry+McLyi6ZyL
RW48Gu/JKfO9cLRw98uxYAd3cTj/jUh2PxPhH0nFE//VNi5QKhlQFjomXysxuXfp
wx5WFlTJrzM04hvwtbMglSuXyqSFqNzxrxfni+Gd1SqsBNwE4d/gBHvswnjV0raa
WbvpDgwsmHhRtOXgH4kzAsXIqva5hUZcrDaBHd9Tpk6rDoys8EE=
=Opui
-----END PGP SIGNATURE-----

--+v5ovSx6NdfX+t2+--