Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220104095954.10313-1-angelogioacchino.delregno@collabora.com>
 <CAMty3ZAojTyw3H8VprH9aiyTyWjeL8oqPxNNr=J33_5FrcUj9Q@mail.gmail.com> <4b46b8ce-7300-ef42-eb17-efd87ebdf773@collabora.com>
In-Reply-To: <4b46b8ce-7300-ef42-eb17-efd87ebdf773@collabora.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Thu, 27 Jan 2022 22:21:35 +0800
Message-ID: <CAAOTY_-FZ_pCpvZyNOcEMHOk1k5re51uGYY1jCxNxQuu7CQ-5A@mail.gmail.com>
Subject: Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with
 external bridge
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Jagan Teki <jagan@amarulasolutions.com>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        andrzej.hajda@intel.com,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Collabora Kernel ML <kernel@collabora.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Angelo:

AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> =E6=96=
=BC
2022=E5=B9=B41=E6=9C=8827=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:3=
2=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Il 12/01/22 08:09, Jagan Teki ha scritto:
> > On Tue, Jan 4, 2022 at 3:30 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com> wrote:
> >>
> >> DRM bridge drivers are now attaching their DSI device at probe time,
> >> which requires us to register our DSI host in order to let the bridge
> >> to probe: this recently started producing an endless -EPROBE_DEFER
> >> loop on some machines that are using external bridges, like the
> >> parade-ps8640, found on the ACER Chromebook R13.
> >>
> >> Now that the DSI hosts/devices probe sequence is documented, we can
> >> do adjustments to the mtk_dsi driver as to both fix now and make sure
> >> to avoid this situation in the future: for this, following what is
> >> documented in drm_bridge.c, move the mtk_dsi component_add() to the
> >> mtk_dsi_ops.attach callback and delete it in the detach callback;
> >> keeping in mind that we are registering a drm_bridge for our DSI,
> >> which is only used/attached if the DSI Host is bound, it wouldn't
> >> make sense to keep adding our bridge at probe time (as it would
> >> be useless to have it if mtk_dsi_ops.attach() fails!), so also move
> >> that one to the dsi host attach function (and remove it in detach).
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@c=
ollabora.com>
> >> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> >> ---
> >
> > Eventually I've observed similar issue on other Component based DSI
> > controllers, hence
> >
> > Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
> >
>
> Hello dri-devel,
> can you please pick this patch?
>
> All MediaTek platforms are broken in v5.17 without this one.

Please add Fixes tag [1] to this patch.

[1] https://www.kernel.org/doc/html/v5.16/process/submitting-patches.html

Regards,
Chun-Kuang.

>
> Thanks,
> Angelo