Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 15:47:40 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Mike Rapoport <rppt@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Dennis Zhou <dennis@kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Oscar Salvador <osalvador@suse.de>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        Nico Pache <npache@redhat.com>,
        Wei Yang <richard.weiyang@gmail.com>,
        Rafael Aquini <raquini@redhat.com>
Subject: Re: [PATCH 2/6] mm: handle uninitialized numa nodes gracefully
Message-ID: <YfKwjAlPW2kJUv5w@dhcp22.suse.cz>
References: <20220127085305.20890-1-mhocko@kernel.org>
 <20220127085305.20890-3-mhocko@kernel.org>
 <YfKgE5hTgbaBeaMa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfKgE5hTgbaBeaMa@kernel.org>
Precedence: bulk

On Thu 27-01-22 15:37:23, Mike Rapoport wrote:
> On Thu, Jan 27, 2022 at 09:53:01AM +0100, Michal Hocko wrote:
[...]
> > +		if (!node_online(nid)) {
> > +			pr_warn("Node %d uninitialized by the platform. Please report with boot dmesg.\n", nid);
> 
> Do we assume that platform code must allocate node data for all nodes in
> the system? Because if we don't this warning is misleading.

At least x86 does that (init_cpu_to_node). Now that you brought that up
I guess you are right that this could be more misleading than helpful.
What about
			pr_info("Initializing node %d as memoryless\n", nid);
Is this better?

> > +
> > +			/* Allocator not initialized yet */
> > +			pgdat = arch_alloc_nodedata(nid);
> > +			if (!pgdat) {
> > +				pr_err("Cannot allocate %zuB for node %d.\n",
> > +						sizeof(*pgdat), nid);
> > +				continue;
> > +			}
> > +			arch_refresh_nodedata(nid, pgdat);
> > +			free_area_init_memoryless_node(nid);
> > +			/*
> > +			 * not marking this node online because we do not want to
> > +			 * confuse userspace by sysfs files/directories for node
> > +			 * without any memory attached to it (see topology_init)
> > +			 * The pgdat will get fully initialized when a memory is
> > +			 * hotpluged into it by hotadd_init_pgdat
> > +			 */
> > +			continue;
> 
> This can be made slightly more concise if we fall through after
> arch_refresh_nodedata(), e.g. something like
> 
> 			...
> 
> 			arch_refresh_nodedata(nid, pgdat);
> 		}
> 
> 		pgdat = NODE_DATA(nid);
> 		free_area_init_node(nid);
> 
> 		/*
> 		 * Do not mark memoryless node online because we do not want to
> 		 * confuse userspace by sysfs files/directories for node
> 		 * without any memory attached to it (see topology_init)
> 		 * The pgdat will get fully initialized when a memory is
> 		 * hotpluged into it by hotadd_init_pgdat
> 		 */
> 		if (!pgdat->node_present_pages)
> 			continue;
> 
> but I don't feel strongly about it.

I do not have strong preference either way. Unless this is considered
better by more people I would stick with what I have.
-- 
Michal Hocko
SUSE Labs