Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp340427pxb; Thu, 27 Jan 2022 23:43:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMxEHjng36jFVLhg4PaHVMbaD3PSEnrsGj6XwCFVsX9tECbhTuOjLqBnCLaRutABSYdETG X-Received: by 2002:a17:902:d509:: with SMTP id b9mr7033223plg.42.1643355787571; Thu, 27 Jan 2022 23:43:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643355787; cv=none; d=google.com; s=arc-20160816; b=JbRVMQkz1a2qVvHy1WxQr9HLWJiRJO5zA7h0T+zUtc2ysp3wuVH8ipIOjsvlgR7Q22 AyqmDVitGR2dJGRyBG5SRa6dxlk3gs95ltY+5ZdV8Dvv2jnzIZFFdQbw9JLAjZPdhoW3 c6iCmD+gPu/fIfwSsAfghaiqj9brgxTXij04J5/IYTsJ+LalJWXXaK/TPETmwuyNpts6 PFwesWsb50smMTAyOUTUeAL9TXsK4zBj1CVLTOHCVbcyKbQg/y/uk3F9AaeM+mzgbhuu i+1ZKUf1PsX4rzf6ZXA+NIqJuO636+47FQtfK1cZyoKvkxMefb6C3Jo8YuOvAxS2c23z gNjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=q4hN31DFix83b+813CIE6qg0d571Nvvx4wdt5OwGgLk=; b=ZSBemVulnwMunAQZqmfhLR48zbw8wPXUdzD+udOG1U3DdF8SXE4Hp/Wc1PeZOYYwkm 8aNLSbfFl087m7xFDJFY/upHOEPqQC1I+Y36EgJr5O5cx06gu6/KrjXU7R5k3leiLR1v R2Yk3WgZ7rUvBRMA4/m+j8l6YmdJcsDtSzlwuBTlDvyYSEecA5vNTLu4+LOJ5Vo/n6rU f1piXX6UUr2cXE0xhEzyqeb8KY0Eb/JcYLIN1oAy3fCe+0Cc4diXO7fgmFAl9qArWQQE nueW88pLdHcLF+LLnkIAEIsqHcQj5M+mH70JnbAUaofE53xyXz3Uepja+11Ng/Sub0Kq CumA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLwgz938; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s29si4773772pfg.76.2022.01.27.23.42.55; Thu, 27 Jan 2022 23:43:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLwgz938; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243079AbiA0PRY (ORCPT + 99 others); Thu, 27 Jan 2022 10:17:24 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:41614 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242862AbiA0PRO (ORCPT ); Thu, 27 Jan 2022 10:17:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15D71B821D8; Thu, 27 Jan 2022 15:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAD09C340E8; Thu, 27 Jan 2022 15:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643296626; bh=4k0tSXLcNsarciiJDhYBERcvL1GeH1zf/piiMpfQoXE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nLwgz938ewNDCP9Eo0yKQEdPmSikefTRwOBnAqzAHDS6IA+dWnxKu+qiiTvys5mL5 vYV9uHqDjD18x4Blro49u9B9A1E3yEFWNsGlrXbYB7DZdzlU1WQIpPN9twPym2M0Bg UyTTrV/MJ3SZ5vcf8QH2eU1ugYM50Kyc0QRU0wY/XoD0voEjzp5HO+pBQKdzQq63EO Om29w2edtCom3ua/RZjIq8Nqs9f4lH44g7Q9upp8UJAmoMyN9bmmiE7cvHZVuuFo5g e7rmxAcT4QiWLXQ1RCwFYqiE8lpS54bmdMBUeJBNiDplyG4yvePloxqLjR8Xatmtdf Tyz5Ltw5phfww== Received: by mail-ed1-f54.google.com with SMTP id u24so4069644eds.11; Thu, 27 Jan 2022 07:17:06 -0800 (PST) X-Gm-Message-State: AOAM532qU6eqiJTXuKgwHjP3QoniWpu5YXZauIQcDNN0Hwb+/ZVlBrga HS1WbXOPb72gcySt6wi5yNj01NypRO9VrGAQHw== X-Received: by 2002:a05:6402:4401:: with SMTP id y1mr4039309eda.215.1643296625254; Thu, 27 Jan 2022 07:17:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Thu, 27 Jan 2022 09:16:53 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 2/2] dt-bindings:spi: Add Sunplus SP7021 schema To: Li-hao Kuo Cc: Philipp Zabel , Mark Brown , andyshevchenko@gmail.com, linux-spi , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= , "LH.Kuo" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 18, 2022 at 2:42 AM Li-hao Kuo wrote: > > Add bindings for Sunplus SP7021 spi driver > > Signed-off-by: Li-hao Kuo > --- > Changes in v6: > - Change the interrupt-names > mas_risc to master_risc > - Addressed comments from Mr. Andy Shevchenko > Change the function name: mas is master and sla is slave. > Add temporary varilable (as suggested by Mr. Andy Shevchenko) > Modify clk setting > Modify the master-slave detection of the probe function.(as suggested by Mr. Andy Shevchenko) > Modify the return value of the probe function.(as suggested by Mr. Andy Shevchenko) > Change GPL version(as suggested by Mr. Andy Shevchenko) > > .../bindings/spi/spi-sunplus-sp7021.yaml | 81 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml This is now failing in linux-next, please fix: /builds/robherring/linux-dt/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml: properties:reg:items: 'anyOf' conditional failed, one must be fixed: ['the SPI master registers', 'the SPI slave registers'] is not of type 'object', 'boolean' 'the SPI master registers' is not of type 'object', 'boolean' 'the SPI slave registers' is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml: ignoring, error in schema: properties: reg: items Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.example.dts:19:18: fatal error: dt-bindings/clock/sp-sp7021.h: No such file or directory 19 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:390: Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.example.dt.yaml] Error 1