Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2fa9246d-eddf-dd4e-17c6-8d6565237afa@oracle.com>
Date:   Thu, 27 Jan 2022 08:02:19 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/4] panic: Add panic_in_progress helper
Content-Language: en-US
To:     Petr Mladek <pmladek@suse.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sebastian Reichel <sre@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        John Ogness <john.ogness@linutronix.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20220126230236.750229-1-stephen.s.brennan@oracle.com>
 <20220126230236.750229-2-stephen.s.brennan@oracle.com>
 <YfKtZUiLWkrUIkwn@alley>
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
In-Reply-To: <YfKtZUiLWkrUIkwn@alley>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjJEcWpSUDhkdXZZTEVpMll1UW1CYTNIUTBEUld0MXlaemc4VUhCUlBGUEpt?=
 =?utf-8?B?c2dIK2hQeGpUWUlqU2E0aVNtV2JnUng2bDNvK0d6N3I0N04weGkwaXlzbEZW?=
 =?utf-8?B?ZHZ0QzUwdWhGaFROUlQvcTYrd1JVSUF0NFV4Z2RvVERZTmVrcitqMFhqaXNs?=
 =?utf-8?B?bjAzc0VjTm5rK2JIcVVOTXdFOFIxaVBkNGNlQVpQZTUzbEZLbWVkOWJkL0NW?=
 =?utf-8?B?eWJGOWlhMHpUZzk0SmliNlEveVE0SUJrVWh5SFZrUUFYSjQvVXk3OUI1N0xn?=
 =?utf-8?B?cXFTb25ZTFd5QWhSWjJZTERhVGRPbVZ5VlQzNHRaK2R1NWdsRUFqZHcrWmY4?=
 =?utf-8?B?cmhrc1dueXF2cnBodllwcThSNTRQczhUY2wvaEFaTzh5aG9OOHc4RDMvb0x3?=
 =?utf-8?B?Y1RsSHlzL1Jwd1NZNUxrc0hkV3VEUTIxcXhFNVF6TXZTQWJOMUhCZ0I4QXpV?=
 =?utf-8?B?Ulk1dEQvWHI5ODVvblBGa1VWSjMwTngzQ0VNYkhOLzlaeS85ZTk2ZmVrdTBZ?=
 =?utf-8?B?K05idmtMQVVGTXUvbUVBVlVsZHQ2WjYwMEVYeGpHdHR1ZWFhK0dZVUErNVpH?=
 =?utf-8?B?d1hYaGFheDB1eDZDQ1REeUoxdWlTRmlZWWFyUStoU0tHa1NKS1EvMnoxaEda?=
 =?utf-8?B?T3h2bkoyb1JHcUNLbmZkZmZNVk1iVzBDQ3FnTmcxTHZOKy83Nk5lZjZMa2Nx?=
 =?utf-8?B?a05IeVVkVXNTbVQrOGFQSnZPaExEa2VYVkZaSWZuT3g4MVlxem9OVE03Tk5x?=
 =?utf-8?B?VlJwQmxRcnRIKytGclloSFdGMjVLVDV2Zm1WM0JhcGpnbTdKM2x1SjMxUnRm?=
 =?utf-8?B?Qy9kZk9YdFkyZjFBelNiWVZPSThsditEOFlYaGpkeno0d3NDdlMyT3p1SHhT?=
 =?utf-8?B?cXhYaUkwcXFhaFRYV0NMUFN5OS9qVTVuaHdZeTBWZG9TY2psVmduSDVSNFpK?=
 =?utf-8?B?K3Q0cXhpbGhSQnc5aDFEbHJCeGRzL0hiZ1V1bW9nc3RaM3FIQ24wRXpPWG10?=
 =?utf-8?B?VHlMWStZaFY4TFZTRDFDTlhYbHBwZk50UXFWNU5kb0RlMjV1bzVtWFV0aUVj?=
 =?utf-8?B?WEg4cFJSRXR6VFFvQ2IwYks1YnBzWmRaaXkxV25yKzBOamdoTVNMc2Q3U2hj?=
 =?utf-8?B?QVRralNkR29rSWZzS0NaYkx1NEpyR2djQWppVytsYTNzck1XZ0tmUEhVcENn?=
 =?utf-8?B?a1BpeVFHbGpiSGE0eER3cnVuMGlSdXY3YnV2d2IyVFNzdS9ybnhhK0hmcDJN?=
 =?utf-8?B?b3ZXTnRhdjRQVng4YXNaKzcxSVhTVlVCYlYxamdpa3hpZ3V6QkF5bS9kVURr?=
 =?utf-8?B?WVpOWEcxeFIrU3RpUkx3RjR0c0k1cW5KNzlqQmJTMTExNk5VYXdSRGlDblBX?=
 =?utf-8?B?bG1JWVVHRytXQWI5eC9ydWxkUEJ4WnVZOGorUlpoL1NQQ0hmSlBESlpjTUR6?=
 =?utf-8?B?aFdyalQ5NE9pTFRMWEdyK0JqZDJ0QkJkU1NyVnZ3MXJqU25UWjhpczB2TGFT?=
 =?utf-8?B?eVR1c1l1SjJOVU5RWUZTZGdNb3hIVE1NYnhESFhLUm1TREx3bmk4UFdqeTha?=
 =?utf-8?B?VGVySHVQVEFKcFJFeFM1REFPd1VQaW9JZDFMZEpzS2RDd3RGZVRZZW81NDZ1?=
 =?utf-8?B?TkZ6ZlhnRitTM3pyR3FoOVRSaS9XSDIzQUV2MVdFRzJjOHcwc2RzUUwyNmQ5?=
 =?utf-8?B?allHUHlaUWRReDJYM1hienI0Q1U4R2Y5WWtMbGVYLzdKOEpjbmhncGNEQ0Z0?=
 =?utf-8?B?QWtuV0lMZENYeVo2Rmp4VUxESjdNYjdyYlEyeUoyWVUyZlptWTVVQXhYem1q?=
 =?utf-8?B?L0dtczF0QUlmSmxjN3hya1gvd0JSVVBXWEVyWU43VUduTGsvSzkvNk94a0Zj?=
 =?utf-8?B?Um1sWVJOQUNPeWN1cktZQzluS1JDSFNmUXJNbWozSWNaUitJZnZNTnZPbDBo?=
 =?utf-8?B?TFdkS0ZhdG45eGdLUDlwS1hLL2M1NGNhRGx2dEFxWEkvaUFrWnR5TlZraU9H?=
 =?utf-8?B?OW5tNXRzK04zZ2V5LytMZE50ZjlEaG94bG9QZDFuOVlzUzgwNXBSOUN6Ujdl?=
 =?utf-8?B?M0FPemJ5d0pqSUFidmh1c1NCb1kydGR2ekhMR3l4bFdqNTlqYTR0ejRIeGdZ?=
 =?utf-8?B?L3g5c0VsY1luR3c0MkxLUVBCeldHSFBGclJudXBqRE02RC9wMHRKOTV5VWpk?=
 =?utf-8?B?Wk50cnRmSkFaZUE4V0dqYlR3WXhBSGcvNnZOZGFKVUxNN3dyTWVWQzBldHVh?=
 =?utf-8?B?R2xYTmdYaTZaYlhGTTh6NXI0UE5RPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b923f02-f97d-4d43-3c0b-08d9e1ae640c
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 16:02:17.0916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PLU8uCo/oLtxpX1TlD4Y/v1FvYcxsF/RbeDQjBn4eY/cGwmFdwmzLdCGadTzZdMpWTZt5JBNrpud7c3prMNtbEW6qQI9QZVlP3U0lwHXdeY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2174
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10239 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201270098
X-Proofpoint-GUID: 1Vo_gIcZgY7_6kfi90GKlNtrKiPNxQY6
X-Proofpoint-ORIG-GUID: 1Vo_gIcZgY7_6kfi90GKlNtrKiPNxQY6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/27/22 06:34, Petr Mladek wrote:
> On Wed 2022-01-26 15:02:33, Stephen Brennan wrote:
>> This helper will be used in printk code to avoid deadlocks during
>> panic().
>>
>> Suggested-by: Petr Mladek <pmladek@suse.com>
>> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> Best Regards,
> Petr

Hi Petr,

Thanks for the review, however over the night I received two kernel test 
robot emails. One indicating a new build error caused by this change on 
m68k arch, and the other adding a new warning on riscv. From what I can 
tell, the issues are circular dependencies in #includes. So it may be 
better to either return to the macro, or move this static inline down to 
kernel/printk/printk.c. I think moving it into kernel/printk/printk.c 
makes most sense given that the macro requires the correct #includes anyway.

Thanks,
Stephen

------------- m68k

    In file included from include/asm-generic/preempt.h:5,
                     from ./arch/m68k/include/generated/asm/preempt.h:1,
                     from include/linux/preempt.h:78,
                     from arch/m68k/include/asm/irqflags.h:6,
                     from include/linux/irqflags.h:16,
                     from arch/m68k/include/asm/atomic.h:6,
                     from include/linux/atomic.h:7,
                     from include/linux/panic.h:7,
                     from include/asm-generic/bug.h:21,
                     from arch/m68k/include/asm/bug.h:32,
                     from include/linux/bug.h:5,
                     from include/linux/page-flags.h:10,
                     from kernel/bounds.c:10:
    include/linux/thread_info.h: In function 'copy_overflow':
 >> include/linux/thread_info.h:214:9: error: implicit declaration of 
function 'WARN' [-Werror=implicit-function-declaration]
      214 |         WARN(1, "Buffer overflow detected (%d < %lu)!\n", 
size, count);
          |         ^~~~
    include/linux/thread_info.h: In function 'check_copy_size':
 >> include/linux/thread_info.h:230:13: error: implicit declaration of 
function 'WARN_ON_ONCE' [-Werror=implicit-function-declaration]
      230 |         if (WARN_ON_ONCE(bytes > INT_MAX))
          |             ^~~~~~~~~~~~
    cc1: some warnings being treated as errors
    make[2]: *** [scripts/Makefile.build:121: kernel/bounds.s] Error 1
    make[2]: Target '__build' not remade because of errors.
    make[1]: *** [Makefile:1191: prepare0] Error 2
    make[1]: Target 'prepare' not remade because of errors.
    make: *** [Makefile:219: __sub-make] Error 2
    make: Target 'prepare' not remade because of errors.

----------------- riscv:

    In file included from arch/riscv/include/asm/atomic.h:19,
                     from include/linux/atomic.h:7,
                     from include/linux/panic.h:7,
                     from include/asm-generic/bug.h:21,
                     from arch/riscv/include/asm/bug.h:83,
                     from include/linux/bug.h:5,
                     from include/linux/page-flags.h:10,
                     from kernel/bounds.c:10:
    arch/riscv/include/asm/atomic.h: In function 'arch_atomic_xchg_relaxed':
 >> arch/riscv/include/asm/cmpxchg.h:35:17: error: implicit declaration 
of function 'BUILD_BUG' [-Werror=implicit-function-declaration]
       35 |                 BUILD_BUG(); 
             \
          |                 ^~~~~~~~~
    arch/riscv/include/asm/atomic.h:249:16: note: in expansion of macro 
'__xchg_relaxed'
      249 |         return __xchg_relaxed(&(v->counter), n, size); 
             \
          |                ^~~~~~~~~~~~~~
    arch/riscv/include/asm/atomic.h:295:9: note: in expansion of macro 
'ATOMIC_OP'
      295 |         ATOMIC_OP(int,   , 4) 
             \
          |         ^~~~~~~~~
    arch/riscv/include/asm/atomic.h:299:1: note: in expansion of macro 
'ATOMIC_OPS'
      299 | ATOMIC_OPS()
          | ^~~~~~~~~~
    cc1: some warnings being treated as errors
    make[2]: *** [scripts/Makefile.build:121: kernel/bounds.s] Error 1
    make[2]: Target '__build' not remade because of errors.
    make[1]: *** [Makefile:1191: prepare0] Error 2
    make[1]: Target 'prepare' not remade because of errors.
    make: *** [Makefile:219: __sub-make] Error 2
    make: Target 'prepare' not remade because of errors.