Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp408036pxb; Fri, 28 Jan 2022 01:40:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYn09paxtOT3SyJhs88e0MSLqCP3SOqQK+eCy3poi7OHFwKuG7mtnwxbjER81WxqFHEzvY X-Received: by 2002:a63:c007:: with SMTP id h7mr6137427pgg.422.1643362832945; Fri, 28 Jan 2022 01:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643362832; cv=none; d=google.com; s=arc-20160816; b=0369iWArbuBg4FpU7L5zsFGYlUgtv2zFsU6Bv9H+QAatJb1zmn7NiIgCtqoWkNFfAU GnbZjk3wdRAoLYogdF1PJpJ45IzzTCL+0Wx+4iJJpqbrKQmbK5QXeCKSTA1Z7o5lpK+l RmQZm9bqt45ILrXdMrWIgQp14mI2a4APcN9DwSjpyQfdF2eqk5jp4TWj655GIa4DkwPO GqCCqpDpHk89UrweAXY7k+duH/m1Kx31CA0k/F0cAHkrVYTQnNKe8l1/AXERSHF7nLB3 1CCIze85GT430YnI+IIlHI98KQY8aIlEkOs/j8/tIL0l012bHI26CI2KEjT6gid8CyC5 hE3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t/MCe4N7Ko6is9DLB7uPGMJ/tYaOgslIsh77bZ85QzU=; b=dfcfNV8tNK1sQG0t2iuLSU2VaKpTCS6KVL+viZAplR4FiUwf4vvWFnSH4m2LVvU6Sy JpEoHVnZadH6JVaGbP0ZOjmO3I7EH6SWig8S69VbJyz/IUGFO90WZKekb5OR5D2DSRd6 MvDpuWRrl2Bilirj+M1BVzMyxBpoGlbTBxRtnLJIObFCEfKHGXV6vA99s9Q5mYhatJHN XSCk/IR2niCR8ap42qnCwleKLaCtTBj9MwhMv7lNpjC4VfBQgQWeJbjL3hI5ZCgo4CBf /2P5+VJYCS1hSdgBTI19CMHR11qfkgotnlp4Z83/K2cShUaJNM9M6KZseQ/2YQV7LqKx U0VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=pzgmDHJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si4020128plr.353.2022.01.28.01.40.21; Fri, 28 Jan 2022 01:40:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=pzgmDHJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243832AbiA0Qfh (ORCPT + 99 others); Thu, 27 Jan 2022 11:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235234AbiA0Qfg (ORCPT ); Thu, 27 Jan 2022 11:35:36 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA26C061714; Thu, 27 Jan 2022 08:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t/MCe4N7Ko6is9DLB7uPGMJ/tYaOgslIsh77bZ85QzU=; b=pzgmDHJPfnOclTpFQU6PM7WHhS SUsJNzZTuhvkvo3z27n5iqlhd975F9rMLJaopHIZKJez/FChf7KM/zQOtSJdyZGTegGNQNsfswHje MEGDkb3uy+WqvrGjvC4GBwnD69G2eLmvBh5Q0uyazG7jt9lq3/oGRsoOQveG4F44of14B4yyHuT+z oSbGYyvlQhTnZuCTg2CjOPpqbAmoMZJwdrkOixGLuvLWM2mnwwbV/IJUvkJj7FwY68dh0Wi6eqafY qQug+QiAKvXjq4f7SH2EQiv4Dh3GTAL1dh4oPKQCSDdyWXuuQNjMp4k6b0UK/bMG0uR7+6v3dFXCn k1SBUSuQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD7jt-005QJL-E4; Thu, 27 Jan 2022 16:35:14 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id B6891986245; Thu, 27 Jan 2022 17:35:12 +0100 (CET) Date: Thu, 27 Jan 2022 17:35:12 +0100 From: Peter Zijlstra To: Peter Oskolkov Cc: mingo@redhat.com, tglx@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, x86@kernel.org, pjt@google.com, avagin@google.com, jannh@google.com, tdelisle@uwaterloo.ca, posk@posk.io Subject: Re: [RFC PATCH v2 5/5] sched: UMCG: allow to sys_umcg_kick UMCG servers Message-ID: <20220127163512.GR20638@worktop.programming.kicks-ass.net> References: <20220113233940.3608440-1-posk@google.com> <20220113233940.3608440-6-posk@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220113233940.3608440-6-posk@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 13, 2022 at 03:39:40PM -0800, Peter Oskolkov wrote: > --- > include/uapi/linux/umcg.h | 10 ++++++++++ > kernel/sched/umcg.c | 7 +++++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/umcg.h b/include/uapi/linux/umcg.h > index 93fccb44283b..a29e5e91a251 100644 > --- a/include/uapi/linux/umcg.h > +++ b/include/uapi/linux/umcg.h > @@ -148,4 +148,14 @@ enum umcg_ctl_flag { > UMCG_CTL_WORKER = 0x10000, > }; > > +/** > + * enum umcg_kick_flag - flags to pass to sys_umcg_kick > + * @UMCG_KICK_RESCHED: reschedule the task; used for worker preemption > + * @UMCG_KICK_TTWU: wake the task; used to wake servers > + */ > +enum umcg_kick_flag { > + UMCG_KICK_RESCHED = 0x001, > + UMCG_KICK_TTWU = 0x002, > +}; > + > #endif /* _UAPI_LINUX_UMCG_H */ > diff --git a/kernel/sched/umcg.c b/kernel/sched/umcg.c > index b85dec6b82e4..e33ec9eddc3e 100644 > --- a/kernel/sched/umcg.c > +++ b/kernel/sched/umcg.c > @@ -669,12 +669,15 @@ SYSCALL_DEFINE2(umcg_kick, u32, flags, pid_t, tid) > if (!task) > return -ESRCH; > > - if (flags) > + if (flags != UMCG_KICK_RESCHED && flags != UMCG_KICK_TTWU) > return -EINVAL; > > #ifdef CONFIG_SMP > - smp_send_reschedule(task_cpu(task)); > + if (flags == UMCG_KICK_RESCHED) > + smp_send_reschedule(task_cpu(task)); > #endif > + if (flags == UMCG_KICK_TTWU) > + try_to_wake_up(task, TASK_NORMAL, 0); > > return 0; > } I'm thinking the simpler thing is this.. (also note the task ref leak fixed) --- a/kernel/sched/umcg.c +++ b/kernel/sched/umcg.c @@ -719,16 +719,22 @@ void umcg_notify_resume(struct pt_regs * */ SYSCALL_DEFINE2(umcg_kick, u32, flags, pid_t, tid) { - struct task_struct *task = umcg_get_task(tid); - if (!task) - return -ESRCH; + struct task_struct *task; if (flags) return -EINVAL; + + task = umcg_get_task(tid); + if (!task) + return -ESRCH; + if (!try_to_wake_up(task, TASK_NORMAL, WF_CURRENT_CPU)) { #ifdef CONFIG_SMP - smp_send_reschedule(task_cpu(task)); + smp_send_reschedule(task_cpu(task)); #endif + } + + put_task_struct(task); return 0; }