Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 4/7] usb: dwc3: Program GFLADJ
To:     Felipe Balbi <balbi@kernel.org>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Balaji Prakash J <bjagadee@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Robert Hancock <robert.hancock@calian.com>,
        Baruch Siach <baruch@tkos.co.il>
References: <20220119002438.106079-1-sean.anderson@seco.com>
 <20220119002438.106079-5-sean.anderson@seco.com>
 <4696c5a4-5921-f7cb-196c-5ad956e696f9@synopsys.com>
 <f528aeb5-6155-a75e-9d35-9bf473e0bbc7@seco.com>
 <3ca6fb9e-94cf-6483-26a6-ae2682d1f55e@synopsys.com>
 <2831e216-737f-41b2-1aa0-4af56615e3b7@seco.com> <87mtji7onx.fsf@kernel.org>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <5756b3c4-02eb-8156-f973-bd592fa139ef@seco.com>
Date:   Thu, 27 Jan 2022 11:45:25 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <87mtji7onx.fsf@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3hZMUJ5VWVJc0xFZ3MvR0NzL2M3cElOV2swdUlmbHd4YUlVMTFMQ2NuaGU5?=
 =?utf-8?B?VlpVSDdiQ2FGbzZRci91RmZnZWlUZERMK01lNGp3RkhCNFRKM0lweW1yVnJI?=
 =?utf-8?B?MmJVSXpVTDFzcEhvTU5lZ3BLcmhhOEtrTVBReEZCSHNHSG5oQSt6OUtmZDUr?=
 =?utf-8?B?ckpVSjFXV2V6VFg2aVF2VldKOEFvR3FSVkd0Und2cEdWQ1VSMEZxYnFEakx6?=
 =?utf-8?B?YXpuNmErR2V2RllQeEhSV3JYOVdyWEtMS1EvRlJMdVB5YnlFT1Evalh0MEl1?=
 =?utf-8?B?b0lNZUZrZXBkNjIrR3ltVm9YelZnRVNkUno5SVUyelc3V3BkTTFSZHd3VlV6?=
 =?utf-8?B?L1VnMEZKb0ZRZDB2TGJXTk0wQm5kdFh5QXluMzM5OWxmRlpmUzEvc0Z2bElO?=
 =?utf-8?B?Y1EwUWk4dVFnbFVsSlJzWVhNbGdHUEg2Qm5iOGJHeE5OV3UvQTlCSjh6SmRO?=
 =?utf-8?B?YXVON0dJVW11SUY5blUvQUx6dFBtUUdMVnhNUnQ2ZWw1dnBkdHNLWmlWbENW?=
 =?utf-8?B?VTlsNm1ReXhZT09CU210S0oyaXY2SlRJUEphRTVOL1RML3ZERzkvYTZEOUUr?=
 =?utf-8?B?bGlObDRKRVRlUWFzQjhYcGdWN0NhMncyY2NHeFhRN1dxS0dKN1ZQeDBLY0dG?=
 =?utf-8?B?K2xrRC8vMUJJc05MdVhXUHBubmdQYWp2R3BYNEJrMmE4cVlGeDFSTWRkdkRW?=
 =?utf-8?B?cllZbkw2aTdCYWZCejFmN3ZGOU4rUWxpQ1RFWnRVQW4xNGxZajZ5QUxpM2x2?=
 =?utf-8?B?V1BTRGNPZnE4QXEvMURyeC9RS2ZmMlhnRU45NzdCQUNEMlIxVlB5TXhibjhy?=
 =?utf-8?B?QnJkWHQ1WmxveFh0STF0MXRQNlpVdXNDRFQvMHZxOXkyQi90Tnl0NlBjWk4z?=
 =?utf-8?B?a2ovTTRYYjhjWHZVWWtTaCswemlYN2lNWGx3eWg2WmlCUTA1ait5T1RqR1Zx?=
 =?utf-8?B?SWJkall3RG9acTJMSWZWSllQTDM2TjRxeW43TTVvUVYyNWZlTENPejg5cFcw?=
 =?utf-8?B?cWI2QnRQWW1zcFBJVzlQbjgxdE9WbHEzUER5Rk9EUjJKT0dlTk1rZWZSUkI3?=
 =?utf-8?B?TTliWXdWczRWaGJISXczOVBVT2ROUDZmNTNtVzdqVGdvUXVxMVBHY3Y1ZXhP?=
 =?utf-8?B?NFZBTURlNHVleDFkc3RWeGxVSEpVNEpCeEZRZm5kd0JwaTdzVklYVU5XcnJG?=
 =?utf-8?B?NUVEanZPMUUyM3lQcGpMNmdLV3UyT1A3ZkFnNEhTME9aWC84WDZYRys0dEZC?=
 =?utf-8?B?Q0RORmdUTStrWWY5U0NNZFZ0djI2aTFFRDgzZHFGSGpCRDFtWkVnbDBVVWRW?=
 =?utf-8?B?WlJVZzdkZ0ZMWFhMRGdMZzFoZFZsL2Q3VnByZVBqbGpBVnhvZ0RFa0lpWFZD?=
 =?utf-8?B?SlFOTlBiakg4dFY3MGhzNkpLblgrNys4V1I5STB2MVQzR28ySW55aUJZTTZ5?=
 =?utf-8?B?d3ptemwrY3EwWitTYTVHeURWZ3YwTDNpeUluVnE0TE5QS1FzN3NvYkNYZkJB?=
 =?utf-8?B?WEdMVG0xaDg1anh3Wk9TTldXOU1neXBMSU9FV2lCeW0rM3pRczNUZC9pZWg4?=
 =?utf-8?B?OXB3dkRpbXhlSXJPdHdqMGVDV1cyVUNDajZpbThhU0o4TnN6cGNydUp5TjJj?=
 =?utf-8?B?aDAvQi9PeXJudEJCUXUwRDNtN2toY1YraXpSeGszMXRpWlFZQmhUSWl0QXpZ?=
 =?utf-8?B?TzlWVVdVOTVtYjlIZ01vWVdZMExkVDVCYkEvdG02TU1WSThERHhFMTBBaDJh?=
 =?utf-8?B?cmFEWVAwYlVtN2xYVG5JcSt5WmxKU2QyaGtwMmNiTC9yK09BODd5NHJvTUU2?=
 =?utf-8?B?OVRkSXFvV3JndmFJODRyU2hRcHJpMWE3ZndjSEZGbzNPZG9QNlF1ZEJsUkJp?=
 =?utf-8?B?SmZaSExqWlVsclo0bklHSzdGYXBoZUVDWVB0cURYdGVFR3U4Ym4zRVo0RktV?=
 =?utf-8?B?S24rU2JyTmprY3lHYmMrUVM3dW9wOUlKSUkwak5YRElhOXJiUjNDSDVKcU5E?=
 =?utf-8?B?cU1SWFVpQkdPY0VSQ3NFVmxRVHlqQ0NmZ0h6NVhIYUFaTzlPTG5DdEFPUmFy?=
 =?utf-8?B?Y3AxeW9rTVB2WXpQbzQwemhjZFA3MHpBOThYaEl6RFpVc09ISUgzRmxNSWhC?=
 =?utf-8?B?UmJ5WXBEUUdzRUQrWmVQN2hFMFVuUCtPNEpCelBNVjI5bzd1NkdrK2NlN3FD?=
 =?utf-8?Q?q/NgbMoCwnnhb6yM/RNdFmM=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c076a276-5a0c-4991-8d8e-08d9e1b46dd1
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 16:45:30.3385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TcCC/eRzjG0Ydb4Ru0voBeuUhXMYvqNJN9CowAlZImwv/g6vBkaxHxO3wwbmiFRa8egYJGlmRoq5K+iUCTUtkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4484
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/26/22 5:53 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Sean Anderson <sean.anderson@seco.com> writes:
> 
>> On 1/24/22 9:11 PM, Thinh Nguyen wrote:
>>>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>>>>>> index 5214daceda86..883e119377f0 100644
>>>>>> --- a/drivers/usb/dwc3/core.c
>>>>>> +++ b/drivers/usb/dwc3/core.c
>>>>>> @@ -348,7 +348,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 *dwc)
>>>>>>  static void dwc3_ref_clk_period(struct dwc3 *dwc)
>>>>>>  {
>>>>>>  	u32 reg;
>>>>>> -	unsigned long rate, period;
>>>>>> +	unsigned long decr, fladj, rate, period;
>>>>>
>>>>> Minor style nit: Felipe prefers to keep the declaration on separate
>>>>> lines, let's keep it consistent with the rest in this driver.
>>>> 
>>>> So 
>>>> 
>>>> unsigned int decr;
>>>> unsigned int fladj;
>>>> unsigned int rate;
>>>> unsigned int period;
>>>> 
>>>> ?
>>>> 
>>>> Frankly that seems rather verbose.
>>> 
>>> A couple of the benefits of having it like this is to help with viewing
>>> git-blame if we introduce new variables and help with backporting fix
>>> patch a bit simpler. Mainly I'm just following Felipe's style and keep
>>> it consistent in this driver, but I don't think it's a big deal.
>>
>> *shrug*
>>
>> If it's the subsystem style I will rewrite it.
>>
>> (btw is this documented anywhere for future contributors?)
> 
> https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
> 
> "To this end, use just one data declaration per line (no commas for
> multiple data declarations)"
> 

This is just if you want to add comments.

--Sean