Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 08:56:27 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Andrew Lunn <andrew@lunn.ch>, Oliver Neukum <oneukum@suse.com>,
        "David S. Miller" <davem@davemloft.net>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support
Message-ID: <20220127085627.70b31e30@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <YfK9uV0BviEiemDi@lunn.ch>
References: <20220127110742.922752-1-o.rempel@pengutronix.de>
        <YfK9uV0BviEiemDi@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 27 Jan 2022 16:43:53 +0100 Andrew Lunn wrote:
> On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> > The weakest link of usbnet devices is the USB cable. Currently there is
> > no way to automatically detect cable related issues except of analyzing
> > kernel log, which would differ depending on the USB host controller.
> > 
> > The Ethernet packet counter could potentially show evidence of some USB
> > related issues, but can be Ethernet related problem as well.  
> 
> I don't know the usbnet drivers very well. A quick look suggests they
> don't support statistics via ethtool -S. So you could make use of that
> to return statistics about USB error events.

On using devlink health - it is great when you want to attach some extra
info to the error report. If you're just counting different types of
errors seems like an overkill.

> However, GregKH point still stands, maybe such statistics should be
> made for all USB devices, and be available in /sys/bus/usb/devices/*