Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 36/40] x86/sev: Provide support for SNP guest request
 NAEs
To:     Borislav Petkov <bp@alien8.de>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-37-brijesh.singh@amd.com> <YfLGcp8q5f+OW72p@zn.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <87d4999a-14cc-5070-4f03-001dd5f1d2b1@amd.com>
Date:   Thu, 27 Jan 2022 11:02:13 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YfLGcp8q5f+OW72p@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDRlMUUrQmJwZGhkbWlMaW4rT0lJTi9uUkZZV0duQVlGTzJzOHA4cVViZWg3?=
 =?utf-8?B?VGg2dXdqWlE1TFptVnRFenRacXFteENHdFR6VHVLcytUU3VwR0hjK3NRTWdm?=
 =?utf-8?B?a2lJRDlxb0VZVGlDY09DU1FDbWpmTGxGS1Fob1lXUDBwdU1TTmZuRVVYdDJ2?=
 =?utf-8?B?cFY1d3F1cnFka202SVhBc0FCZFFJMlkrUFRGWWtuTzhQTzhWbjdYY1d4cVZJ?=
 =?utf-8?B?N0RMVjV3L3p2Wklkank2MTVWYnZqY1pZS0o3V3NaczZXdTNMaVM2QjJHTWdJ?=
 =?utf-8?B?Tmc5TjVzMjRqVkRERmMrZXUxY2dadEU5eWJoT0dLVHJPUDQ2NlBiZCtjUkdk?=
 =?utf-8?B?bFM4RTZnNlZ2TGdFeG5uVzVJQUVhUnNoenJOQ1IvajdyUmhqQkdBeFFpSEg4?=
 =?utf-8?B?RGhwdUZTb2pXRnhZNktoUGRrYTRpVmEraEJ2T3I4NWM2eHVmMjZzRmxlQW9C?=
 =?utf-8?B?YnlDUFEvNUI0SGFsR2lpZGZvZnZFNGI3MWFQSnFrOURwZDhKdjZFaEVTNTFM?=
 =?utf-8?B?NGtveFp6ODBrTS90enNkY1EvMURpamxxQmJMbGQ0QWNCK3A5TTZDRnBmT3Nn?=
 =?utf-8?B?M1NFTTFycklMYWVkbFdVdlptekZRTnZrbnZOWGlFK3ZVRUxjRmhPaWlsSEk1?=
 =?utf-8?B?QzVYVHJYalhpdS96MzNjZDJqUk9uaGoyTjFuLzRmbUtTRjNEdmlWb3VBdlZh?=
 =?utf-8?B?bitvK0RTZ1c3OEgyY0VQS0loN3h2TGdEd2pnZ2QrSjMwMk81ZEF3c0pNQXRZ?=
 =?utf-8?B?bHA4d1JIT2R5bk5UM201T1QvTFFSaXk0UHBRcHNQU1FVS09mNU4wQlBhODdl?=
 =?utf-8?B?VVpJbFdjUEh4aXdiVVc1U1dicWV2UXpPNU95SzlMTHpnbDAwSEk4c3BHWU9m?=
 =?utf-8?B?UlMwMXBnTkpNWVZNT2hGQU1pQkhaRSsxMXU4UnRTN3hmUXRWQm1JYjd4S29k?=
 =?utf-8?B?bEV5anNaaEUrbG1aVEhqM1Q2QnQvYkJNU3dnOVNib2xvT0o3bGYwV0Q3Vldt?=
 =?utf-8?B?a3VEeU00QWdaRGppZ1pSWW05V043cFVpaWgrNWloQkZnYzJVTnQ2TGlFL0cw?=
 =?utf-8?B?RUVlbStyajd5TzRCaFpOb1BmM0tqYnBZbUJzaDN0NFpEbVo3d2laUWlkcStU?=
 =?utf-8?B?MzQ0enZBZkRkeE43QXdzTWtZZHhicDdGTmFMczhxcFdtem15cXNMK1kxODFr?=
 =?utf-8?B?YjZZZlZTY1ZDTjJ3T2FyMy9tM2VVbjBuSU9rZVFCZXFvR0IyMFJLVnRrL0ND?=
 =?utf-8?B?Q0Z2SDBxZ29xK3Vob1ZjZm56aHlWNm1QTU1GRWVpY2p6S2xoK2pVNFBjRVpm?=
 =?utf-8?B?VHY1WE9LNWpIbGNCV3JBUEd5UjRuOHVsNTEzWmFtVWg2VTg1WU1WSWp0cEFU?=
 =?utf-8?B?NWl2VzZUMWRnZmlFcENDVTk1SHlGS1JMbmZLUDBQZm5JZDk0aHh5bUFJUnYw?=
 =?utf-8?B?YjhNMzBpdDNNclBjTHBtbFlIclRZYkZ3cnczdm16VzJBdjY2ejF3M2VxQ2Zk?=
 =?utf-8?B?V1ZoTlZnQlF6dmo5RWFRVnNjNzBTNzgwSW5scjg4UW56T29TVEVNWDhWSFZF?=
 =?utf-8?B?UUM0V3lSNm5xVXNESGZ1SFpZRnFxU2lrZmhhT1l6dEJubkJ2WUFjaEVDZ3gz?=
 =?utf-8?B?RDU4N00yanloWXZOWDFqT2lUN1Vhajh4KzNXSkg3YUljY3M4RzNIbkVwVzhk?=
 =?utf-8?B?TWE3RGtKMVcyM3dvaFpmbDlBbU9RczdNOFNTdFFiazhJeEp4Qng3TXVkNk12?=
 =?utf-8?B?WE5BbW90Q1kzcWFuNDR0RWJrOVlSY2IxWUZmOWhjdWdTMlh1aXdNTXY0OFVa?=
 =?utf-8?B?WFo5QjMya2t1U0tVY2ZyNE5LSkhXWlg4OWJhbDBRV29ZNjZrVmlsM2lSR1I2?=
 =?utf-8?B?R2RnR0xOVmhpQUlOZjZPOGJsZ1R1RlM2UGpMUms0Sko4clJHRWtWOVhYWkwz?=
 =?utf-8?B?TEdsSGVYMFprSDRhK1hZOFhHZ0lldEdSVkdQYmplbVcwUHZmc21LWjl2VTRF?=
 =?utf-8?B?blVTdE1Dem1EbEU4VVBwUlZISmF1L1NIMXZZMVFZVkZRMlFWL2pKdE9PL1Rm?=
 =?utf-8?B?RmFCUE9CdXBVM2Y3ZzRxVHR5VnF3RjZaM1QwdkRmQ0QyNmlKMEU5SGs4OFFO?=
 =?utf-8?B?Vk5ocGc5T0IyN3BEUGVGU2U1d0NRTnlYOG9jbHZIV0RVQWpnZFhlMzllTUh5?=
 =?utf-8?Q?Op8yyh96za7vugvtPR99Pdo=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 875508c0-c8ba-4b29-f45d-08d9e1b6c6e2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 17:02:18.8964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bL7aB4z4ofC8QE5eC1SzfF5WrG6qBJ9dN4Z6j+pSfbc6rVSgHouSYgHChnaW/TBlFEHwdaznrV0estM9dPfstQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4888
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/27/22 10:21 AM, Borislav Petkov wrote:
> On Fri, Dec 10, 2021 at 09:43:28AM -0600, Brijesh Singh wrote:
>> Version 2 of GHCB specification provides SNP_GUEST_REQUEST and
>> SNP_EXT_GUEST_REQUEST NAE that can be used by the SNP guest to communicate
>> with the PSP.
>>
>> While at it, add a snp_issue_guest_request() helper that can be used by
> 
> Not "that can" but "that will".
> 
Noted.

>>   
>> +/* Guest message request error code */
>> +#define SNP_GUEST_REQ_INVALID_LEN	BIT_ULL(32)
> 
> SZ_4G is more descriptive, perhaps...
> 

I am okay with using SZ_4G but per the spec they don't spell that its 4G 
size. It says bit 32 will should be set on error.


>> +
>> +	ret = sev_es_ghcb_hv_call(ghcb, true, NULL, exit_code, input->req_gpa, input->resp_gpa);
> 					      ^^^^^
> 
> That's ctxt which is accessed without a NULL check in
> verify_exception_info().
> 
> Why aren't you allocating a ctxt on stack like the other callers do?

Typically the sev_es_ghcb_hv_handler() is called from #VC handler, which 
provides the context structure. But in this and PSC case, the caller is 
not a #VC handler, so we don't have a context structure. But as you 
pointed, we could allocate context structure on the stack and pass it 
down so that verify_exception_info() does not cause a panic with NULL 
deference (when HV violates the spec and inject exception while handling 
this NAE).

thanks