Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 18:11:16 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Michael Below <below@judiz.de>,
        Salvatore Bonaccorso <carnil@debian.org>
Subject: Re: [PATCH 2/7] i2c: core: Use generic_handle_irq_safe() in
 i2c_handle_smbus_host_notify().
Message-ID: <YfLSNNDVtAFx1P9u@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Johan Hovold <johan@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Michael Below <below@judiz.de>,
        Salvatore Bonaccorso <carnil@debian.org>
References: <20220127113303.3012207-1-bigeasy@linutronix.de>
 <20220127113303.3012207-3-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Tote0/I6gsw1g9Hy"
Content-Disposition: inline
In-Reply-To: <20220127113303.3012207-3-bigeasy@linutronix.de>
Precedence: bulk


--Tote0/I6gsw1g9Hy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 27, 2022 at 12:32:58PM +0100, Sebastian Andrzej Siewior wrote:
> The i2c-i801 driver invokes i2c_handle_smbus_host_notify() from his
> interrupt service routine. On PREEMPT_RT i2c-i801's handler is forced
> threaded with enabled interrupts which leads to a warning by
> handle_irq_event_percpu() assuming that irq_default_primary_handler()
> enabled interrupts.
>=20
> i2c-i801's interrupt handler can't be made non-threaded because the
> interrupt line is shared with other devices.
>=20
> Use generic_handle_irq_safe() which can invoked with disabled and enabled
> interrupts.
>=20
> Reported-by: Michael Below <below@judiz.de>
> Link: https://bugs.debian.org/1002537
> Cc: Salvatore Bonaccorso <carnil@debian.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

I guess you want this to go together with patch 1, so:

Acked-by: Wolfram Sang <wsa@kernel.org>

I agree with adding the kernel bugzilla entry at least:

https://bugzilla.kernel.org/show_bug.cgi?id=3D202453

Probably the others which Oleksandr metioned, too.

--Tote0/I6gsw1g9Hy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmHy0jQACgkQFA3kzBSg
KbYF0w/+OqNuksglO0/K1veCj0S4r5AKF+9L/Je8+51hxkfVPXaASw8QBtWXEZC0
AcMCb214DRxTXFl+lIT44Y+BRht09eKKFj3BN6eFi26ROn6kiLs4RwU8vyEM2JoZ
vgwUs1+qGgOa9CAw5nY1x/DO+8nyJeNrzX0FNIrbjMsKCbFjBNPKdyARdSRqackX
sxg/DoBd3kAtWaQoedAMl4WyEYHGx5GV6WB1nLsk0Uzr2oF1+0yx5iApJf6OdXot
5j1vM/7RUr4dDftefslKzATo8sLvH9FhQeyfbHYpnqnssYjHHIc6iaLwH8m93jQB
CVrgihGYW+4sqxHzdgPYiZHNLxct8WnTb0KblrLc21su9ZpZN9DtM3ySShj+Ok0/
lhUQijKmWpx0U/QTJZ3Smyk0s+Eg87iBFL+rIzPUF0Se8vNybRpYVeNAWWZDM0nN
R/vkF2ZUKAEBxnZtL6Scr9eu2REC95bQtJ5LYNYRgH+3y7L5uMIDUGcb1UZBVXTK
++20+4nO9oCG8HE8RJLJmI2ULo2HrkQ293ROjwMzgLqxgL+C+Llu4bfkTI1MwjQd
2ZZ3qLdRwQakXceVfOuIH0bNeBdzFIuR6Q5eE+NJpD2R8DeToIt7j+rUTnWSjgcL
MOlt3i6hTrTxKfp6LF81bI0z1AetI7I1JmDvdvR4Zu76s2ZPj1E=
=0Whn
-----END PGP SIGNATURE-----

--Tote0/I6gsw1g9Hy--