Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp757642pxb; Fri, 28 Jan 2022 09:18:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJykHAjGa9qO80vq7kmjQwtXElkBiwoqXeR7WpLDilbw3ahiiDGEmQAaZBhPhivv/9yyH76W X-Received: by 2002:a17:902:9306:: with SMTP id bc6mr9469420plb.93.1643390332062; Fri, 28 Jan 2022 09:18:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643390332; cv=none; d=google.com; s=arc-20160816; b=EcQlel6cnZTPSISj9+KIhFwcDDgiwRycEKB4OIyTejrZDALp4WGpF7sPyOmeIyYD9I fbHCtQm+qQxutXgjEasyZlHlIk2cRkLKeopzHjvUejmkXQhcvhkR48tZ1aKYcQw6eQ5W qHDZ0d6JSG+vpXGDBJ5lD4tjvTuFnOhdTGDfj7VPInHHNyRo08hhBWwjP3az1c5zYJ7A Aq3IbJ9zxZ8QUa5QYePqIEHI5y5SZi7zbRFfXMMLy32W/RQKOz1G7qk/cvKFNI5dWdRS w2txwpQj2qHLTwlBL7CsxTqb0JAZnfu80SLN2mycABrfHgBDD5atjSIUIG7E4Uh6LRrs 25tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iMJcZepLim/YpIi7Y7hIab1z+GE+IIU8h9QgrFmMU/0=; b=lbZ3HbUwr4JBY/vHITjGAax60N6BRvtYWIpOdmtA2DUG7YHEhnQ3IteLpcYUHEZez6 DU6S+LvT229E433Q/opxQ/nPI5XQkzjHxs7Xrua7Yd0esiidJI8su30TUF6VtftV+DII OJ4KAbDqjuyo1bhASNSAKFwRnrYIm5s1ry25n80GZhMdxPvv61G6SrIuE6McNkQhvHHS SuS5taPeqzvLGkNc4kqpGHO2O8E+DcEr8cXXAbF1Esu09+QywTFFZDFn6iyVutgfxM8I zo6UV2uFpSMHmwnAxaBKZzhp2WzHaTnxtdsPk0GPLSN30jlnjX7s8lZmmCpuGLtAhCT4 XNBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OZNuVGwm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lk11si3678479pjb.67.2022.01.28.09.18.40; Fri, 28 Jan 2022 09:18:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OZNuVGwm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343740AbiA0UCU (ORCPT + 99 others); Thu, 27 Jan 2022 15:02:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343672AbiA0UCG (ORCPT ); Thu, 27 Jan 2022 15:02:06 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD9FC061755 for ; Thu, 27 Jan 2022 12:02:05 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id h20-20020a17090adb9400b001b518bf99ffso8673251pjv.1 for ; Thu, 27 Jan 2022 12:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iMJcZepLim/YpIi7Y7hIab1z+GE+IIU8h9QgrFmMU/0=; b=OZNuVGwmg+5DpXtgxq+BMEkKae3EDK19392kSo4/J2z3xPzFGcdXFvJ1uC38LmN+lD RCdoVkHQwjCTjT9aJVj8uGSKfPaj4VhZ6b3P8SwCCKGRNX03bgKzXtD2isYFr1AFNjHr VPrC3gXCOEEDHIF0ibxT9aiOAQxnq9XdvcSRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iMJcZepLim/YpIi7Y7hIab1z+GE+IIU8h9QgrFmMU/0=; b=V05IvajxqwTlOm4egtz5KXeQpu42lyZzK2yP0UJr/QXjedWUX/PdtUeBBp5+nVXEon gvXXjRfR8RKJPd979ZrT+Vp5gTnNI3rT1yIq0QiFyKfe6PIRrM7dgpLg3tacjN0p0Zyj 4CmRjwUWmWs2eQfAQXvMKRzWt46rLVBmUNpdSH04AwY1yEhA7K/Li+jmnOTs8RLHKak1 oOna/5f2V9MTjRfmAgN95upA6tz8N9B+lQcwtOA1aSQy8wlI0K36umZk0popPzWKoI8o zTGDpMXeYBekwT6UKLylJCaraEnrcHLkK+9a4k6GBtfch0V00ifeoShmJaA66Jp6c6mw fRrA== X-Gm-Message-State: AOAM532tb5AwF3QdXTGBnZWg9i11G3CH2+8sl/hkTWyTxepwbQDFjzqJ LMAWbb1ScOivcTODro9S5M2ai/sBncohLA== X-Received: by 2002:a17:902:ab49:: with SMTP id ij9mr4763950plb.1.1643313725021; Thu, 27 Jan 2022 12:02:05 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:9246:1838:3243:3071]) by smtp.gmail.com with ESMTPSA id k21sm6561190pff.33.2022.01.27.12.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 12:02:04 -0800 (PST) From: Stephen Boyd To: Greg Kroah-Hartman , Douglas Anderson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Liviu Dudau , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan Subject: [PATCH v6 08/35] drm/arm/hdlcd: Migrate to aggregate driver Date: Thu, 27 Jan 2022 12:01:14 -0800 Message-Id: <20220127200141.1295328-9-swboyd@chromium.org> X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog In-Reply-To: <20220127200141.1295328-1-swboyd@chromium.org> References: <20220127200141.1295328-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/hdlcd_drv.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 479c2422a2e0..e3ed925797d5 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -270,8 +270,9 @@ static const struct drm_driver hdlcd_driver = { .minor = 0, }; -static int hdlcd_drm_bind(struct device *dev) +static int hdlcd_drm_bind(struct aggregate_device *adev) { + struct device *dev = aggregate_device_parent(adev); struct drm_device *drm; struct hdlcd_drm_private *hdlcd; int ret; @@ -344,8 +345,9 @@ static int hdlcd_drm_bind(struct device *dev) return ret; } -static void hdlcd_drm_unbind(struct device *dev) +static void hdlcd_drm_unbind(struct aggregate_device *adev) { + struct device *dev = aggregate_device_parent(adev); struct drm_device *drm = dev_get_drvdata(dev); struct hdlcd_drm_private *hdlcd = drm->dev_private; @@ -367,9 +369,13 @@ static void hdlcd_drm_unbind(struct device *dev) drm_dev_put(drm); } -static const struct component_master_ops hdlcd_master_ops = { - .bind = hdlcd_drm_bind, - .unbind = hdlcd_drm_unbind, +static struct aggregate_driver hdlcd_aggregate_driver = { + .probe = hdlcd_drm_bind, + .remove = hdlcd_drm_unbind, + .driver = { + .name = "hdlcd_drm", + .owner = THIS_MODULE, + }, }; static int compare_dev(struct device *dev, void *data) @@ -390,13 +396,12 @@ static int hdlcd_probe(struct platform_device *pdev) drm_of_component_match_add(&pdev->dev, &match, compare_dev, port); of_node_put(port); - return component_master_add_with_match(&pdev->dev, &hdlcd_master_ops, - match); + return component_aggregate_register(&pdev->dev, &hdlcd_aggregate_driver, match); } static int hdlcd_remove(struct platform_device *pdev) { - component_master_del(&pdev->dev, &hdlcd_master_ops); + component_aggregate_unregister(&pdev->dev, &hdlcd_aggregate_driver); return 0; } -- https://chromeos.dev