Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp759223pxb; Fri, 28 Jan 2022 09:20:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzF38LBWm8k8nlQMRcOMr36hqzCjTnZUQiTWjag50LKJhpLkqxZvYlxCPU+yMVLFKOgpm9k X-Received: by 2002:a17:90b:4f87:: with SMTP id qe7mr10938992pjb.207.1643390442855; Fri, 28 Jan 2022 09:20:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643390442; cv=none; d=google.com; s=arc-20160816; b=iIegIXvmIaFPS0DkwqYQ6LI+LvXSAJ+wlBEhb3Zt16NXjTUSZtT6X6jJp+IGWNS2ZV WDYt7GMUsw56/fTixnso4Qx2pOS9s5UW+s9T3ZXG/FSPB39RJeZ7bXLqAO7lBSaHe3OO y5f7GAePhKny8A12KtairZZfeuLO33OEKJkJyq2thgdFjU/GoEpGV1R6TSWcO2sOl02D kEjNbaxtQtP4S9UsqHT5nv74RkGTcvy0ZC8uilPx3iEkrOQ5omqO5/RuV2ZvaUVt5kik B5XZzTJyRaMESow5V9kufvKUYMS3UNOMFzrxshiXBoFH5RwVHi3F7OrbZam5UdpR+2lt q41w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pg7u1QgES9vvilydf87u7mbX9H+V1JXmTaOjVr3A4N4=; b=dpt3kzorqjVdvicx4xw0iZLhDrBRlTmvjVxdp5xdJCEEgmqoZKY6bz+NzR7zVqHeKX oEQ/8GXj0UzeATMnfBRNnfITs5ptdXuVBjpo9gKQGVLz5IV3bbvwElTfmje8fCxx1f5t TdzllEiKyF7c1uo7HAu/tqw4e89fajApsFWTE6zhm4ipa1w/IDGNNQ9kbayxYQfK57zp Y+/CcjvMV3I2hkTTKTNuvCnvRboeY6eiC6RmNKws9jzRdnYb5zsw45m9v+yHU41UCQqE O6LQShVt35C2SrE0ZzG8BgA9F8G+ve3Hd6PCIyoAZGDG8a0xvbt0uQWp+sisBwcJ1tkO gvWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=SNb6+UtC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r145si5641437pgr.651.2022.01.28.09.20.29; Fri, 28 Jan 2022 09:20:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=SNb6+UtC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344017AbiA0UEB (ORCPT + 99 others); Thu, 27 Jan 2022 15:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343899AbiA0UCm (ORCPT ); Thu, 27 Jan 2022 15:02:42 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9D47C0613DE for ; Thu, 27 Jan 2022 12:02:39 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id 192so3798405pfz.3 for ; Thu, 27 Jan 2022 12:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pg7u1QgES9vvilydf87u7mbX9H+V1JXmTaOjVr3A4N4=; b=SNb6+UtCldRo3C3aKKuH53pJUKPR1QoOvhja2fFrdIZAqK2pC8avjHvs2QWwdAqY2L iDTt5Ev8TK1FUPlXG0GLJg90OtWzYd58L9jGhUvwTScxXTgeVD59clQ/6ruqJGZsIDtb VzKFMzhSCdtxWvtOoLilyZS6Je3BqrKogxJuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pg7u1QgES9vvilydf87u7mbX9H+V1JXmTaOjVr3A4N4=; b=ijLvCe+eVe+2KU/NIA3i4mBC9WOhwJfrvAu3m0rBHXwhBXWQjMx1YOfilYK2X1Y2/f DVKwp9CNRugi/rpF2RThjCFJ3F0h9VsewNphLnmYkwME5LpdMXJ5ETSoPEMGJ4km+RCM zgcLQ0movumb/mYBHpwjwrMMxPFo7qj7DkfovG9eSolgzKeEUHmMdO3BxUF8ypIQCbVg /cCw2VhaVKNeMu0KsT044bvyyXh+5XFmSywZwJOB302mXkUrIvyV30xW3BncsZrBkHec W5sy78e/aF5IXgbc40DUZHFY9TqOfINb2bIcnN0bLzAAPX06ijx2/ncdCXPVNvwfCJAZ 2peA== X-Gm-Message-State: AOAM531em430r0lqZYZN68x9UHU84D7DVzho3uLcU3b2P8tzkHTJxVmy ozphcjR0cUC02SwsLko6zXIFOhGLjaSF3Q== X-Received: by 2002:a63:dd0f:: with SMTP id t15mr3912064pgg.12.1643313759139; Thu, 27 Jan 2022 12:02:39 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:9246:1838:3243:3071]) by smtp.gmail.com with ESMTPSA id k21sm6561190pff.33.2022.01.27.12.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 12:02:38 -0800 (PST) From: Stephen Boyd To: Greg Kroah-Hartman , Douglas Anderson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stefan Binding , Lucas Tanure , Takashi Iwai , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan Subject: [PATCH v6 33/35] ALSA: hda/realtek: Migrate to aggregate driver Date: Thu, 27 Jan 2022 12:01:39 -0800 Message-Id: <20220127200141.1295328-34-swboyd@chromium.org> X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog In-Reply-To: <20220127200141.1295328-1-swboyd@chromium.org> References: <20220127200141.1295328-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Stefan Binding Cc: Lucas Tanure Cc: Takashi Iwai Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/pci/hda/patch_realtek.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 668274e52674..80a2164c99b6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6547,25 +6547,31 @@ static int find_comp_by_dev_name(struct alc_spec *spec, const char *name) return -ENODEV; } -static int comp_bind(struct device *dev) +static int realtek_aggregate_probe(struct aggregate_device *adev) { + struct device *dev = aggregate_device_parent(adev); struct hda_codec *cdc = dev_to_hda_codec(dev); struct alc_spec *spec = cdc->spec; return component_bind_all(dev, spec->comps); } -static void comp_unbind(struct device *dev) +static void realtek_aggregate_remove(struct aggregate_device *adev) { + struct device *dev = aggregate_device_parent(adev); struct hda_codec *cdc = dev_to_hda_codec(dev); struct alc_spec *spec = cdc->spec; component_unbind_all(dev, spec->comps); } -static const struct component_master_ops comp_master_ops = { - .bind = comp_bind, - .unbind = comp_unbind, +static struct aggregate_driver realtek_aggregate_driver = { + .probe = realtek_aggregate_probe, + .remove = realtek_aggregate_remove, + .driver = { + .name = "realtek_aggregate", + .owner = THIS_MODULE, + }, }; static void comp_generic_playback_hook(struct hda_pcm_stream *hinfo, struct hda_codec *cdc, @@ -6597,7 +6603,7 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char return; component_match_add(dev, &spec->match, comp_match_dev_name, name); } - ret = component_master_add_with_match(dev, &comp_master_ops, spec->match); + ret = component_aggregate_register(dev, &realtek_aggregate_driver, spec->match); if (ret) codec_err(cdc, "Fail to register component aggregator %d\n", ret); else @@ -6648,7 +6654,7 @@ static void alc287_fixup_legion_16achg6_speakers(struct hda_codec *cdc, const st "i2c-CLSA0100:00-cs35l41-hda.0"); component_match_add(dev, &spec->match, comp_match_dev_name, "i2c-CLSA0100:00-cs35l41-hda.1"); - ret = component_master_add_with_match(dev, &comp_master_ops, spec->match); + ret = component_aggregate_register(dev, &realtek_aggregate_driver, spec->match); if (ret) codec_err(cdc, "Fail to register component aggregator %d\n", ret); else -- https://chromeos.dev